From: <Conor.Dooley@microchip.com>
To: <andy.shevchenko@gmail.com>, <Lewis.Hanly@microchip.com>
Cc: <linux-gpio@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<linus.walleij@linaro.org>, <brgl@bgdev.pl>,
<linux-kernel@vger.kernel.org>, <palmer@dabbelt.com>,
<maz@kernel.org>, <Daire.McNamara@microchip.com>
Subject: Re: [PATCH v2 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Wed, 13 Jul 2022 17:44:17 +0000 [thread overview]
Message-ID: <debb6cf6-65f8-53d2-d8d7-3ed1c3d5a8c7@microchip.com> (raw)
In-Reply-To: <CAHp75VfGTd02jKYsFq94BF_Gqro2trk3iyyALBatS1Bps3HYhw@mail.gmail.com>
On 13/07/2022 12:59, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>
> Below my comments, I have tried hard not to duplicate what Conor
> already mentioned. So consider this as additional part.
>
>> +#define NUM_GPIO 32
>> +#define BYTE_BOUNDARY 0x04
>
> Without namespace?
Does byte_boundary even need to be defined?
is incrementing an address by 0x4 not kinda obvious on its own
as to what it is doing?
>> + if (gpio_cfg & MPFS_GPIO_EN_IN)
>> + return 1;
>> +
>> + return 0;
>
> Don't we have specific definitions for the directions?
FWIW Lewis, they're GPIO_LINE_DIRECTION_IN & GPIO_LINE_DIRECTION_OUT
I thought something like this would surely exist but wasn't sure.
Thanks for pointing it out Andy.
Conor.
next prev parent reply other threads:[~2022-07-13 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 10:59 [PATCH v2 0/1] Add Polarfire SoC GPIO support lewis.hanly
2022-07-13 10:59 ` [PATCH v2 1/1] gpio: mpfs: add polarfire soc gpio support lewis.hanly
2022-07-13 11:26 ` Conor.Dooley
2022-07-13 21:00 ` Lewis.Hanly
2022-07-13 11:59 ` Andy Shevchenko
2022-07-13 17:44 ` Conor.Dooley [this message]
2022-07-13 17:50 ` Andy Shevchenko
2022-07-13 21:10 ` Lewis.Hanly
2022-07-13 20:44 ` Lewis.Hanly
2022-07-13 22:14 ` Andy Shevchenko
2022-07-14 6:19 ` Conor.Dooley
2022-07-15 7:56 ` Lewis.Hanly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=debb6cf6-65f8-53d2-d8d7-3ed1c3d5a8c7@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Lewis.Hanly@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).