From: Ferry Toth <fntoth@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v1 0/3] gpiolib: acpi: More fixes to the consolidation rework
Date: Fri, 20 Oct 2023 13:50:40 +0200 [thread overview]
Message-ID: <e11ab885-10dc-4efa-8171-ebdb3ca61b24@gmail.com> (raw)
In-Reply-To: <20231019173457.2445119-1-andriy.shevchenko@linux.intel.com>
Op 19-10-2023 om 19:34 schreef Andy Shevchenko:
> On top what Hans already fixed, Ferry reported a few bugs that pointed
> out to the same consolidation rework done in v6.2.
>
> The first is most serious issue, that needs to be fixed ASAP.
>
> The second is good to have.
>
> And the third one I'm not fully okay with, so open for advice on
> how to improve.
>
> Note, that long list of parameters to a _find_gpio() functions
> can be hidden in the specifically crafted a new data structure,
> but this is out of scope of the _fixes_ series. I'm all ears as
> well for that one.
>
> Andy Shevchenko (3):
> gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data()
> gpiolib: Fix debug messaging in gpiod_find_and_request()
> gpiolib: Make debug messages in gpiod_find_by_fwnode() less confusing
For the series
Tested-by: Ferry Toth <fntoth@gmail.com>
> drivers/gpio/gpiolib-acpi.c | 10 ++++-----
> drivers/gpio/gpiolib-acpi.h | 13 ++++++------
> drivers/gpio/gpiolib-of.c | 13 ++++++------
> drivers/gpio/gpiolib-of.h | 8 ++++----
> drivers/gpio/gpiolib-swnode.c | 4 ++--
> drivers/gpio/gpiolib-swnode.h | 1 +
> drivers/gpio/gpiolib.c | 38 ++++++++++++++++++++---------------
> 7 files changed, 48 insertions(+), 39 deletions(-)
>
prev parent reply other threads:[~2023-10-20 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 17:34 [PATCH v1 0/3] gpiolib: acpi: More fixes to the consolidation rework Andy Shevchenko
2023-10-19 17:34 ` [PATCH v1 1/3] gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data() Andy Shevchenko
2023-10-19 19:20 ` Dmitry Torokhov
2023-10-20 9:25 ` Bartosz Golaszewski
2023-10-19 17:34 ` [PATCH v1 2/3] gpiolib: Fix debug messaging in gpiod_find_and_request() Andy Shevchenko
2023-10-19 19:21 ` Dmitry Torokhov
2023-11-14 15:29 ` Andy Shevchenko
2023-11-14 21:18 ` Dmitry Torokhov
2023-11-15 1:37 ` andy.shevchenko
2023-11-15 14:57 ` Dmitry Torokhov
2024-03-20 15:05 ` Andy Shevchenko
2023-11-14 20:26 ` Linus Walleij
2023-10-19 17:34 ` [PATCH v1 3/3] gpiolib: Make debug messages in gpiod_find_by_fwnode() less confusing Andy Shevchenko
2023-11-14 20:29 ` Linus Walleij
2023-10-20 11:50 ` Ferry Toth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11ab885-10dc-4efa-8171-ebdb3ca61b24@gmail.com \
--to=fntoth@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).