* [PATCH 01/10] dt-bindings: regulator: Add PMX75 compatibles
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-04 6:21 ` Krzysztof Kozlowski
2023-07-03 14:42 ` [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75 Rohit Agarwal
` (9 subsequent siblings)
10 siblings, 1 reply; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add PMX75 compatibles for PMIC found in SDX75 platform.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index b949850..cc72144 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -53,6 +53,7 @@ description: |
For PMR735A, smps1 - smps3, ldo1 - ldo7
For PMX55, smps1 - smps7, ldo1 - ldo16
For PMX65, smps1 - smps8, ldo1 - ldo21
+ For PMX75, smps1 - smps10, ldo1 - ldo21
properties:
compatible:
@@ -84,6 +85,7 @@ properties:
- qcom,pmr735a-rpmh-regulators
- qcom,pmx55-rpmh-regulators
- qcom,pmx65-rpmh-regulators
+ - qcom,pmx75-rpmh-regulators
qcom,pmic-id:
description: |
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 01/10] dt-bindings: regulator: Add PMX75 compatibles
2023-07-03 14:42 ` [PATCH 01/10] dt-bindings: regulator: Add PMX75 compatibles Rohit Agarwal
@ 2023-07-04 6:21 ` Krzysztof Kozlowski
2023-07-04 6:45 ` Rohit Agarwal
0 siblings, 1 reply; 27+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-04 6:21 UTC (permalink / raw)
To: Rohit Agarwal, agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 03/07/2023 16:42, Rohit Agarwal wrote:
> Add PMX75 compatibles for PMIC found in SDX75 platform.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> index b949850..cc72144 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> @@ -53,6 +53,7 @@ description: |
> For PMR735A, smps1 - smps3, ldo1 - ldo7
> For PMX55, smps1 - smps7, ldo1 - ldo16
> For PMX65, smps1 - smps8, ldo1 - ldo21
> + For PMX75, smps1 - smps10, ldo1 - ldo21
>
> properties:
> compatible:
> @@ -84,6 +85,7 @@ properties:
> - qcom,pmr735a-rpmh-regulators
> - qcom,pmx55-rpmh-regulators
> - qcom,pmx65-rpmh-regulators
> + - qcom,pmx75-rpmh-regulators
You miss the update to the if:then: parts.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 01/10] dt-bindings: regulator: Add PMX75 compatibles
2023-07-04 6:21 ` Krzysztof Kozlowski
@ 2023-07-04 6:45 ` Rohit Agarwal
0 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-04 6:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, lee,
robh+dt, krzysztof.kozlowski+dt, conor+dt, linus.walleij,
lgirdwood, broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 7/4/2023 11:51 AM, Krzysztof Kozlowski wrote:
> On 03/07/2023 16:42, Rohit Agarwal wrote:
>> Add PMX75 compatibles for PMIC found in SDX75 platform.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>> index b949850..cc72144 100644
>> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>> @@ -53,6 +53,7 @@ description: |
>> For PMR735A, smps1 - smps3, ldo1 - ldo7
>> For PMX55, smps1 - smps7, ldo1 - ldo16
>> For PMX65, smps1 - smps8, ldo1 - ldo21
>> + For PMX75, smps1 - smps10, ldo1 - ldo21
>>
>> properties:
>> compatible:
>> @@ -84,6 +85,7 @@ properties:
>> - qcom,pmr735a-rpmh-regulators
>> - qcom,pmx55-rpmh-regulators
>> - qcom,pmx65-rpmh-regulators
>> + - qcom,pmx75-rpmh-regulators
> You miss the update to the if:then: parts.
Thanks for your time. Will add that part as well.
Thanks,
Rohit.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
2023-07-03 14:42 ` [PATCH 01/10] dt-bindings: regulator: Add PMX75 compatibles Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-03 14:59 ` Konrad Dybcio
2023-07-03 14:42 ` [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba Rohit Agarwal
` (8 subsequent siblings)
10 siblings, 1 reply; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add RPM power domain bindings for the SDX75 SoC.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index afad313..58e1be8 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -40,6 +40,7 @@ properties:
- qcom,sdm845-rpmhpd
- qcom,sdx55-rpmhpd
- qcom,sdx65-rpmhpd
+ - qcom,sdx75-rpmhpd
- qcom,sm6115-rpmpd
- qcom,sm6125-rpmpd
- qcom,sm6350-rpmhpd
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 1bf8e87..8092d0d 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -57,6 +57,14 @@
#define SDX65_CX_AO 4
#define SDX65_MXC 5
+/* SDX75 Power Domain Indexes */
+#define SDX75_CX 0
+#define SDX75_CX_AO 1
+#define SDX75_MSS 2
+#define SDX75_MX 3
+#define SDX75_MX_AO 4
+#define SDX75_MXC 5
+
/* SM6350 Power Domain Indexes */
#define SM6350_CX 0
#define SM6350_GFX 1
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75
2023-07-03 14:42 ` [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75 Rohit Agarwal
@ 2023-07-03 14:59 ` Konrad Dybcio
2023-07-04 6:17 ` Rohit Agarwal
0 siblings, 1 reply; 27+ messages in thread
From: Konrad Dybcio @ 2023-07-03 14:59 UTC (permalink / raw)
To: Rohit Agarwal, agross, andersson, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 3.07.2023 16:42, Rohit Agarwal wrote:
> Add RPM power domain bindings for the SDX75 SoC.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> index afad313..58e1be8 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -40,6 +40,7 @@ properties:
> - qcom,sdm845-rpmhpd
> - qcom,sdx55-rpmhpd
> - qcom,sdx65-rpmhpd
> + - qcom,sdx75-rpmhpd
> - qcom,sm6115-rpmpd
> - qcom,sm6125-rpmpd
> - qcom,sm6350-rpmhpd
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index 1bf8e87..8092d0d 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -57,6 +57,14 @@
> #define SDX65_CX_AO 4
> #define SDX65_MXC 5
>
> +/* SDX75 Power Domain Indexes */
> +#define SDX75_CX 0
> +#define SDX75_CX_AO 1
> +#define SDX75_MSS 2
> +#define SDX75_MX 3
> +#define SDX75_MX_AO 4
> +#define SDX75_MXC 5
Please instead introduce a set of defines without the SoC prefix
(i.e. CX, CX_AO, MX etc.). We've been putting this off for too long
and you're the first unlucky guy that submitted new RPMhPD support after
we've concluded it'd be the way to go! :D Sadly, we can't replace the
existing ones retroactively..
Konrad
> +
> /* SM6350 Power Domain Indexes */
> #define SM6350_CX 0
> #define SM6350_GFX 1
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75
2023-07-03 14:59 ` Konrad Dybcio
@ 2023-07-04 6:17 ` Rohit Agarwal
2023-07-05 8:54 ` Rohit Agarwal
0 siblings, 1 reply; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-04 6:17 UTC (permalink / raw)
To: Konrad Dybcio, agross, andersson, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 7/3/2023 8:29 PM, Konrad Dybcio wrote:
> On 3.07.2023 16:42, Rohit Agarwal wrote:
>> Add RPM power domain bindings for the SDX75 SoC.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
>> 2 files changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> index afad313..58e1be8 100644
>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> @@ -40,6 +40,7 @@ properties:
>> - qcom,sdm845-rpmhpd
>> - qcom,sdx55-rpmhpd
>> - qcom,sdx65-rpmhpd
>> + - qcom,sdx75-rpmhpd
>> - qcom,sm6115-rpmpd
>> - qcom,sm6125-rpmpd
>> - qcom,sm6350-rpmhpd
>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
>> index 1bf8e87..8092d0d 100644
>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>> @@ -57,6 +57,14 @@
>> #define SDX65_CX_AO 4
>> #define SDX65_MXC 5
>>
>> +/* SDX75 Power Domain Indexes */
>> +#define SDX75_CX 0
>> +#define SDX75_CX_AO 1
>> +#define SDX75_MSS 2
>> +#define SDX75_MX 3
>> +#define SDX75_MX_AO 4
>> +#define SDX75_MXC 5
> Please instead introduce a set of defines without the SoC prefix
> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long
> and you're the first unlucky guy that submitted new RPMhPD support after
> we've concluded it'd be the way to go! :D Sadly, we can't replace the
> existing ones retroactively..
Surely No issues. Will update it.
Thanks,
Rohit.
> Konrad
>> +
>> /* SM6350 Power Domain Indexes */
>> #define SM6350_CX 0
>> #define SM6350_GFX 1
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75
2023-07-04 6:17 ` Rohit Agarwal
@ 2023-07-05 8:54 ` Rohit Agarwal
2023-07-05 10:43 ` Konrad Dybcio
0 siblings, 1 reply; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-05 8:54 UTC (permalink / raw)
To: Konrad Dybcio, agross, andersson, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 7/4/2023 11:47 AM, Rohit Agarwal wrote:
>
> On 7/3/2023 8:29 PM, Konrad Dybcio wrote:
>> On 3.07.2023 16:42, Rohit Agarwal wrote:
>>> Add RPM power domain bindings for the SDX75 SoC.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> ---
>>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
>>> 2 files changed, 9 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>> b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>> index afad313..58e1be8 100644
>>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>> @@ -40,6 +40,7 @@ properties:
>>> - qcom,sdm845-rpmhpd
>>> - qcom,sdx55-rpmhpd
>>> - qcom,sdx65-rpmhpd
>>> + - qcom,sdx75-rpmhpd
>>> - qcom,sm6115-rpmpd
>>> - qcom,sm6125-rpmpd
>>> - qcom,sm6350-rpmhpd
>>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h
>>> b/include/dt-bindings/power/qcom-rpmpd.h
>>> index 1bf8e87..8092d0d 100644
>>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>>> @@ -57,6 +57,14 @@
>>> #define SDX65_CX_AO 4
>>> #define SDX65_MXC 5
>>> +/* SDX75 Power Domain Indexes */
>>> +#define SDX75_CX 0
>>> +#define SDX75_CX_AO 1
>>> +#define SDX75_MSS 2
>>> +#define SDX75_MX 3
>>> +#define SDX75_MX_AO 4
>>> +#define SDX75_MXC 5
>> Please instead introduce a set of defines without the SoC prefix
>> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long
>> and you're the first unlucky guy that submitted new RPMhPD support after
>> we've concluded it'd be the way to go! :D Sadly, we can't replace the
>> existing ones retroactively..
> Surely No issues. Will update it.
I have a doubt here. Cant we completely omit the #defines here and
directly index this as 0,1,...
because if the intention of this #defines is to understand the name of
the pd then we can get
it from the .name attribute in rpmhpd as well, right?
The problems with a common set of #define would be, lets say if we
define CX_AO as 1 and some platform
doesn't have CX_AO then wouldnt it leave a null entry in the driver
entry of that platform?
Thanks,
Rohit.
>
> Thanks,
> Rohit.
>> Konrad
>>> +
>>> /* SM6350 Power Domain Indexes */
>>> #define SM6350_CX 0
>>> #define SM6350_GFX 1
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75
2023-07-05 8:54 ` Rohit Agarwal
@ 2023-07-05 10:43 ` Konrad Dybcio
2023-07-05 11:20 ` Rohit Agarwal
0 siblings, 1 reply; 27+ messages in thread
From: Konrad Dybcio @ 2023-07-05 10:43 UTC (permalink / raw)
To: Rohit Agarwal, agross, andersson, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 5.07.2023 10:54, Rohit Agarwal wrote:
>
> On 7/4/2023 11:47 AM, Rohit Agarwal wrote:
>>
>> On 7/3/2023 8:29 PM, Konrad Dybcio wrote:
>>> On 3.07.2023 16:42, Rohit Agarwal wrote:
>>>> Add RPM power domain bindings for the SDX75 SoC.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> ---
>>>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>>>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
>>>> 2 files changed, 9 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>> index afad313..58e1be8 100644
>>>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>> @@ -40,6 +40,7 @@ properties:
>>>> - qcom,sdm845-rpmhpd
>>>> - qcom,sdx55-rpmhpd
>>>> - qcom,sdx65-rpmhpd
>>>> + - qcom,sdx75-rpmhpd
>>>> - qcom,sm6115-rpmpd
>>>> - qcom,sm6125-rpmpd
>>>> - qcom,sm6350-rpmhpd
>>>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
>>>> index 1bf8e87..8092d0d 100644
>>>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>>>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>>>> @@ -57,6 +57,14 @@
>>>> #define SDX65_CX_AO 4
>>>> #define SDX65_MXC 5
>>>> +/* SDX75 Power Domain Indexes */
>>>> +#define SDX75_CX 0
>>>> +#define SDX75_CX_AO 1
>>>> +#define SDX75_MSS 2
>>>> +#define SDX75_MX 3
>>>> +#define SDX75_MX_AO 4
>>>> +#define SDX75_MXC 5
>>> Please instead introduce a set of defines without the SoC prefix
>>> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long
>>> and you're the first unlucky guy that submitted new RPMhPD support after
>>> we've concluded it'd be the way to go! :D Sadly, we can't replace the
>>> existing ones retroactively..
>> Surely No issues. Will update it.
>
> I have a doubt here. Cant we completely omit the #defines here and directly index this as 0,1,...
> because if the intention of this #defines is to understand the name of the pd then we can get
> it from the .name attribute in rpmhpd as well, right?
>
> The problems with a common set of #define would be, lets say if we define CX_AO as 1 and some platform
> doesn't have CX_AO then wouldnt it leave a null entry in the driver entry of that platform?
Yes.
We already do this in the rpmh clock driver, as:
1. there are domains that all chips share (like CX etc.)
2. wasting a couple of bytes lets us massively save on convolution
Konrad
>
> Thanks,
> Rohit.
>
>>
>> Thanks,
>> Rohit.
>>> Konrad
>>>> +
>>>> /* SM6350 Power Domain Indexes */
>>>> #define SM6350_CX 0
>>>> #define SM6350_GFX 1
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75
2023-07-05 10:43 ` Konrad Dybcio
@ 2023-07-05 11:20 ` Rohit Agarwal
0 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-05 11:20 UTC (permalink / raw)
To: Konrad Dybcio, agross, andersson, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 7/5/2023 4:13 PM, Konrad Dybcio wrote:
> On 5.07.2023 10:54, Rohit Agarwal wrote:
>> On 7/4/2023 11:47 AM, Rohit Agarwal wrote:
>>> On 7/3/2023 8:29 PM, Konrad Dybcio wrote:
>>>> On 3.07.2023 16:42, Rohit Agarwal wrote:
>>>>> Add RPM power domain bindings for the SDX75 SoC.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> ---
>>>>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>>>>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
>>>>> 2 files changed, 9 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>>> index afad313..58e1be8 100644
>>>>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>>>>> @@ -40,6 +40,7 @@ properties:
>>>>> - qcom,sdm845-rpmhpd
>>>>> - qcom,sdx55-rpmhpd
>>>>> - qcom,sdx65-rpmhpd
>>>>> + - qcom,sdx75-rpmhpd
>>>>> - qcom,sm6115-rpmpd
>>>>> - qcom,sm6125-rpmpd
>>>>> - qcom,sm6350-rpmhpd
>>>>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
>>>>> index 1bf8e87..8092d0d 100644
>>>>> --- a/include/dt-bindings/power/qcom-rpmpd.h
>>>>> +++ b/include/dt-bindings/power/qcom-rpmpd.h
>>>>> @@ -57,6 +57,14 @@
>>>>> #define SDX65_CX_AO 4
>>>>> #define SDX65_MXC 5
>>>>> +/* SDX75 Power Domain Indexes */
>>>>> +#define SDX75_CX 0
>>>>> +#define SDX75_CX_AO 1
>>>>> +#define SDX75_MSS 2
>>>>> +#define SDX75_MX 3
>>>>> +#define SDX75_MX_AO 4
>>>>> +#define SDX75_MXC 5
>>>> Please instead introduce a set of defines without the SoC prefix
>>>> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long
>>>> and you're the first unlucky guy that submitted new RPMhPD support after
>>>> we've concluded it'd be the way to go! :D Sadly, we can't replace the
>>>> existing ones retroactively..
>>> Surely No issues. Will update it.
>> I have a doubt here. Cant we completely omit the #defines here and directly index this as 0,1,...
>> because if the intention of this #defines is to understand the name of the pd then we can get
>> it from the .name attribute in rpmhpd as well, right?
>>
>> The problems with a common set of #define would be, lets say if we define CX_AO as 1 and some platform
>> doesn't have CX_AO then wouldnt it leave a null entry in the driver entry of that platform?
> Yes.
>
> We already do this in the rpmh clock driver, as:
>
> 1. there are domains that all chips share (like CX etc.)
> 2. wasting a couple of bytes lets us massively save on convolution
Ok, got it. Looks cleaner.
Thanks,
Rohit.
>
> Konrad
>> Thanks,
>> Rohit.
>>
>>> Thanks,
>>> Rohit.
>>>> Konrad
>>>>> +
>>>>> /* SM6350 Power Domain Indexes */
>>>>> #define SM6350_CX 0
>>>>> #define SM6350_GFX 1
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
2023-07-03 14:42 ` [PATCH 01/10] dt-bindings: regulator: Add PMX75 compatibles Rohit Agarwal
2023-07-03 14:42 ` [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75 Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-13 13:31 ` Lee Jones
2023-07-03 14:42 ` [PATCH 04/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support Rohit Agarwal
` (7 subsequent siblings)
10 siblings, 2 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add compatible for pmic pm7550ba used in Snapdragon series.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 36de335..3abb878 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -41,6 +41,7 @@ properties:
- qcom,pm660
- qcom,pm660l
- qcom,pm7250b
+ - qcom,pm7550ba
- qcom,pm7325
- qcom,pm8004
- qcom,pm8005
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba
2023-07-03 14:42 ` [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba Rohit Agarwal
@ 2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-13 13:31 ` Lee Jones
1 sibling, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-04 6:24 UTC (permalink / raw)
To: Rohit Agarwal, agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 03/07/2023 16:42, Rohit Agarwal wrote:
> Add compatible for pmic pm7550ba used in Snapdragon series.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba
2023-07-03 14:42 ` [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
@ 2023-07-13 13:31 ` Lee Jones
1 sibling, 0 replies; 27+ messages in thread
From: Lee Jones @ 2023-07-13 13:31 UTC (permalink / raw)
To: Rohit Agarwal
Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linus.walleij, lgirdwood, broonie, sboyd, linux-arm-msm,
devicetree, linux-kernel, linux-gpio
On Mon, 03 Jul 2023, Rohit Agarwal wrote:
> Add compatible for pmic pm7550ba used in Snapdragon series.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 04/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (2 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 03/10] dt-bindings: mfd: Add compatible for pm7550ba Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-03 14:42 ` [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75 Rohit Agarwal
` (6 subsequent siblings)
10 siblings, 1 reply; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
binding.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index eaadd5a..9470eb0 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -25,6 +25,7 @@ properties:
- qcom,pm6150l-gpio
- qcom,pm6350-gpio
- qcom,pm7250b-gpio
+ - qcom,pm7550ba-gpio
- qcom,pm7325-gpio
- qcom,pm8005-gpio
- qcom,pm8008-gpio
@@ -171,6 +172,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,pm7550ba-gpio
- qcom,pm8226-gpio
- qcom,pm8350b-gpio
- qcom,pm8550ve-gpio
@@ -411,6 +413,7 @@ $defs:
- gpio1-gpio9 for pm6350
- gpio1-gpio12 for pm7250b
- gpio1-gpio10 for pm7325
+ - gpio1-gpio8 for pm7550ba
- gpio1-gpio4 for pm8005
- gpio1-gpio2 for pm8008
- gpio1-gpio6 for pm8018
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 04/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
2023-07-03 14:42 ` [PATCH 04/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support Rohit Agarwal
@ 2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-04 6:48 ` Rohit Agarwal
0 siblings, 1 reply; 27+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-04 6:24 UTC (permalink / raw)
To: Rohit Agarwal, agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 03/07/2023 16:42, Rohit Agarwal wrote:
> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
> binding.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index eaadd5a..9470eb0 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -25,6 +25,7 @@ properties:
> - qcom,pm6150l-gpio
> - qcom,pm6350-gpio
> - qcom,pm7250b-gpio
> + - qcom,pm7550ba-gpio
> - qcom,pm7325-gpio
Keep alphanumeric order.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 04/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
2023-07-04 6:24 ` Krzysztof Kozlowski
@ 2023-07-04 6:48 ` Rohit Agarwal
0 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-04 6:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, lee,
robh+dt, krzysztof.kozlowski+dt, conor+dt, linus.walleij,
lgirdwood, broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 7/4/2023 11:54 AM, Krzysztof Kozlowski wrote:
> On 03/07/2023 16:42, Rohit Agarwal wrote:
>> Add support for the pm7550ba GPIO support to the Qualcomm PMIC GPIO
>> binding.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>> index eaadd5a..9470eb0 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>> @@ -25,6 +25,7 @@ properties:
>> - qcom,pm6150l-gpio
>> - qcom,pm6350-gpio
>> - qcom,pm7250b-gpio
>> + - qcom,pm7550ba-gpio
>> - qcom,pm7325-gpio
> Keep alphanumeric order.
It was in my mind but somehow made a mistake. Will update this immediately.
Thanks,
Rohit.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (3 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 04/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-13 13:31 ` Lee Jones
2023-07-03 14:42 ` [PATCH 06/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support Rohit Agarwal
` (5 subsequent siblings)
10 siblings, 2 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add compatible for pmic pmx75 used in Snapdragon series.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 3abb878..a185a44 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -88,6 +88,7 @@ properties:
- qcom,pms405
- qcom,pmx55
- qcom,pmx65
+ - qcom,pmx75
- qcom,smb2351
- const: qcom,spmi-pmic
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75
2023-07-03 14:42 ` [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75 Rohit Agarwal
@ 2023-07-04 6:24 ` Krzysztof Kozlowski
2023-07-13 13:31 ` Lee Jones
1 sibling, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-04 6:24 UTC (permalink / raw)
To: Rohit Agarwal, agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 03/07/2023 16:42, Rohit Agarwal wrote:
> Add compatible for pmic pmx75 used in Snapdragon series.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75
2023-07-03 14:42 ` [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75 Rohit Agarwal
2023-07-04 6:24 ` Krzysztof Kozlowski
@ 2023-07-13 13:31 ` Lee Jones
1 sibling, 0 replies; 27+ messages in thread
From: Lee Jones @ 2023-07-13 13:31 UTC (permalink / raw)
To: Rohit Agarwal
Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linus.walleij, lgirdwood, broonie, sboyd, linux-arm-msm,
devicetree, linux-kernel, linux-gpio
On Mon, 03 Jul 2023, Rohit Agarwal wrote:
> Add compatible for pmic pmx75 used in Snapdragon series.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 06/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (4 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 05/10] dt-bindings: mfd: Add compatible for pmx75 Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-04 6:25 ` Krzysztof Kozlowski
2023-07-03 14:42 ` [PATCH 07/10] soc: qcom: rpmhpd: Add SDX75 power domains Rohit Agarwal
` (4 subsequent siblings)
10 siblings, 1 reply; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add support for the pmx75 GPIO support to the Qualcomm PMIC GPIO
binding.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 9470eb0..aa66784 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -68,6 +68,7 @@ properties:
- qcom,pms405-gpio
- qcom,pmx55-gpio
- qcom,pmx65-gpio
+ - qcom,pmx75-gpio
- enum:
- qcom,spmi-gpio
@@ -301,6 +302,7 @@ allOf:
contains:
enum:
- qcom,pmx65-gpio
+ - qcom,pmx75-gpio
then:
properties:
gpio-line-names:
@@ -456,6 +458,7 @@ $defs:
- gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
and gpio11)
- gpio1-gpio16 for pmx65
+ - gpio1-gpio16 for pmx75
items:
pattern: "^gpio([0-9]+)$"
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 06/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support
2023-07-03 14:42 ` [PATCH 06/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support Rohit Agarwal
@ 2023-07-04 6:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-04 6:25 UTC (permalink / raw)
To: Rohit Agarwal, agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio
On 03/07/2023 16:42, Rohit Agarwal wrote:
> Add support for the pmx75 GPIO support to the Qualcomm PMIC GPIO
> binding.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 07/10] soc: qcom: rpmhpd: Add SDX75 power domains
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (5 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 06/10] dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-03 14:42 ` [PATCH 08/10] regulator: qcom-rpmh: Add support for SDX75 Rohit Agarwal
` (3 subsequent siblings)
10 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add power domains found in Qualcomm SDX75 SoC.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
drivers/soc/qcom/rpmhpd.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index f20e2a4..df9d22c 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -307,6 +307,21 @@ static const struct rpmhpd_desc sdx65_desc = {
.num_pds = ARRAY_SIZE(sdx65_rpmhpds),
};
+/* SDX75 RPMH powerdomains */
+static struct rpmhpd *sdx75_rpmhpds[] = {
+ [SDX75_CX] = &cx,
+ [SDX75_CX_AO] = &cx_ao,
+ [SDX75_MSS] = &mss,
+ [SDX75_MX] = &mx,
+ [SDX75_MX_AO] = &mx_ao,
+ [SDX75_MXC] = &mxc,
+};
+
+static const struct rpmhpd_desc sdx75_desc = {
+ .rpmhpds = sdx75_rpmhpds,
+ .num_pds = ARRAY_SIZE(sdx75_rpmhpds),
+};
+
/* SM6350 RPMH powerdomains */
static struct rpmhpd *sm6350_rpmhpds[] = {
[SM6350_CX] = &cx_w_mx_parent,
@@ -529,6 +544,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
{ .compatible = "qcom,sdm845-rpmhpd", .data = &sdm845_desc },
{ .compatible = "qcom,sdx55-rpmhpd", .data = &sdx55_desc},
{ .compatible = "qcom,sdx65-rpmhpd", .data = &sdx65_desc},
+ { .compatible = "qcom,sdx75-rpmhpd", .data = &sdx75_desc},
{ .compatible = "qcom,sm6350-rpmhpd", .data = &sm6350_desc },
{ .compatible = "qcom,sm8150-rpmhpd", .data = &sm8150_desc },
{ .compatible = "qcom,sm8250-rpmhpd", .data = &sm8250_desc },
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 08/10] regulator: qcom-rpmh: Add support for SDX75
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (6 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 07/10] soc: qcom: rpmhpd: Add SDX75 power domains Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-03 14:42 ` [PATCH 09/10] pinctrl: qcom-pmic-gpio: Add support for pm7550ba Rohit Agarwal
` (2 subsequent siblings)
10 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
Add support from RPMH regulators found in SDX75 platform.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
drivers/regulator/qcom-rpmh-regulator.c | 38 +++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index b0a58c6..96d8fab 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -1273,6 +1273,40 @@ static const struct rpmh_vreg_init_data pmx65_vreg_data[] = {
{}
};
+static const struct rpmh_vreg_init_data pmx75_vreg_data[] = {
+ RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps525_lv, "vdd-s1"),
+ RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps525_lv, "vdd-s2"),
+ RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps525_lv, "vdd-s3"),
+ RPMH_VREG("smps4", "smp%s4", &pmic5_ftsmps525_mv, "vdd-s4"),
+ RPMH_VREG("smps5", "smp%s5", &pmic5_ftsmps525_lv, "vdd-s5"),
+ RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps525_lv, "vdd-s6"),
+ RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps525_lv, "vdd-s7"),
+ RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps525_lv, "vdd-s8"),
+ RPMH_VREG("smps9", "smp%s9", &pmic5_ftsmps525_lv, "vdd-s9"),
+ RPMH_VREG("smps10", "smp%s10", &pmic5_ftsmps525_lv, "vdd-s10"),
+ RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo515, "vdd-l1"),
+ RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo515, "vdd-l2-18"),
+ RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo515, "vdd-l3"),
+ RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo515, "vdd-l4-l16"),
+ RPMH_VREG("ldo5", "ldo%s5", &pmic5_pldo_lv, "vdd-l5-l6"),
+ RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo_lv, "vdd-l5-l6"),
+ RPMH_VREG("ldo7", "ldo%s7", &pmic5_nldo515, "vdd-l7"),
+ RPMH_VREG("ldo8", "ldo%s8", &pmic5_nldo515, "vdd-l8-l9"),
+ RPMH_VREG("ldo9", "ldo%s9", &pmic5_nldo515, "vdd-l8-l9"),
+ RPMH_VREG("ldo10", "ldo%s10", &pmic5_pldo, "vdd-l10"),
+ RPMH_VREG("ldo11", "ldo%s11", &pmic5_pldo, "vdd-l11-l13"),
+ RPMH_VREG("ldo12", "ldo%s12", &pmic5_nldo515, "vdd-l12"),
+ RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l11-l13"),
+ RPMH_VREG("ldo14", "ldo%s14", &pmic5_nldo515, "vdd-l14"),
+ RPMH_VREG("ldo15", "ldo%s15", &pmic5_nldo515, "vdd-l15"),
+ RPMH_VREG("ldo16", "ldo%s16", &pmic5_nldo515, "vdd-l4-l16"),
+ RPMH_VREG("ldo17", "ldo%s17", &pmic5_nldo515, "vdd-l17"),
+ /* ldo18 not configured */
+ RPMH_VREG("ldo19", "ldo%s19", &pmic5_nldo515, "vdd-l19"),
+ RPMH_VREG("ldo20", "ldo%s20", &pmic5_nldo515, "vdd-l20-l21"),
+ RPMH_VREG("ldo21", "ldo%s21", &pmic5_nldo515, "vdd-l20-l21"),
+};
+
static const struct rpmh_vreg_init_data pm7325_vreg_data[] = {
RPMH_VREG("smps1", "smp%s1", &pmic5_hfsmps510, "vdd-s1"),
RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps520, "vdd-s2"),
@@ -1495,6 +1529,10 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = {
.data = pmx65_vreg_data,
},
{
+ .compatible = "qcom,pmx75-rpmh-regulators",
+ .data = pmx75_vreg_data,
+ },
+ {
.compatible = "qcom,pm7325-rpmh-regulators",
.data = pm7325_vreg_data,
},
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 09/10] pinctrl: qcom-pmic-gpio: Add support for pm7550ba
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (7 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 08/10] regulator: qcom-rpmh: Add support for SDX75 Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-03 14:42 ` [PATCH 10/10] pinctrl: qcom-pmic-gpio: Add support for pmx75 Rohit Agarwal
2023-07-03 15:27 ` [PATCH 00/10] Add Power Domains and Regulators in SDX75 Bjorn Andersson
10 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
pm7550ba pmic support gpio controller so add compatible in the driver.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 43c7857..5e8b42e 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1205,6 +1205,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pm6350-gpio", .data = (void *) 9 },
{ .compatible = "qcom,pm7250b-gpio", .data = (void *) 12 },
{ .compatible = "qcom,pm7325-gpio", .data = (void *) 10 },
+ { .compatible = "qcom,pm7550ba-gpio", .data = (void *) 8},
{ .compatible = "qcom,pm8005-gpio", .data = (void *) 4 },
{ .compatible = "qcom,pm8008-gpio", .data = (void *) 2 },
{ .compatible = "qcom,pm8019-gpio", .data = (void *) 6 },
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 10/10] pinctrl: qcom-pmic-gpio: Add support for pmx75
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (8 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 09/10] pinctrl: qcom-pmic-gpio: Add support for pm7550ba Rohit Agarwal
@ 2023-07-03 14:42 ` Rohit Agarwal
2023-07-03 15:27 ` [PATCH 00/10] Add Power Domains and Regulators in SDX75 Bjorn Andersson
10 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-03 14:42 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, lee, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linus.walleij, lgirdwood,
broonie, sboyd
Cc: linux-arm-msm, devicetree, linux-kernel, linux-gpio,
Rohit Agarwal
pmx75 pmic support gpio controller so add compatible in the driver.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 5e8b42e..3d0b896 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1251,6 +1251,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
{ .compatible = "qcom,pmx55-gpio", .data = (void *) 11 },
{ .compatible = "qcom,pmx65-gpio", .data = (void *) 16 },
+ { .compatible = "qcom,pmx75-gpio", .data = (void *) 16 },
{ },
};
--
2.7.4
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 00/10] Add Power Domains and Regulators in SDX75
2023-07-03 14:42 [PATCH 00/10] Add Power Domains and Regulators in SDX75 Rohit Agarwal
` (9 preceding siblings ...)
2023-07-03 14:42 ` [PATCH 10/10] pinctrl: qcom-pmic-gpio: Add support for pmx75 Rohit Agarwal
@ 2023-07-03 15:27 ` Bjorn Andersson
2023-07-04 6:16 ` Rohit Agarwal
10 siblings, 1 reply; 27+ messages in thread
From: Bjorn Andersson @ 2023-07-03 15:27 UTC (permalink / raw)
To: Rohit Agarwal
Cc: agross, konrad.dybcio, lee, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linus.walleij, lgirdwood, broonie, sboyd, linux-arm-msm,
devicetree, linux-kernel, linux-gpio
On Mon, Jul 03, 2023 at 08:12:16PM +0530, Rohit Agarwal wrote:
> Hello,
>
> This series adds driver and dt-bindings related changes
> in SDX75 to add power domains and regulators.
>
Thanks for your patches, Rohit. Really nice to see the SDX75 support
being upstreamed.
This series is to be merged by five (5) different maintainers, with no
dependencies between them, afaict. The likely outcome is confusion and
some of the patches being left behind on the list.
To reduce this risk of confusion and to get your patches looked at, and
merged, faster, please send independent series/patches separately in the
future.
Regards,
Bjorn
> Thanks,
> Rohit.
>
> Rohit Agarwal (10):
> dt-bindings: regulator: Add PMX75 compatibles
> dt-bindings: power: Add rpm power domains for SDX75
> dt-bindings: mfd: Add compatible for pm7550ba
> dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
> dt-bindings: mfd: Add compatible for pmx75
> dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support
> soc: qcom: rpmhpd: Add SDX75 power domains
> regulator: qcom-rpmh: Add support for SDX75
> pinctrl: qcom-pmic-gpio: Add support for pm7550ba
> pinctrl: qcom-pmic-gpio: Add support for pmx75
>
> .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 6 ++++
> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
> .../bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
> drivers/regulator/qcom-rpmh-regulator.c | 38 ++++++++++++++++++++++
> drivers/soc/qcom/rpmhpd.c | 16 +++++++++
> include/dt-bindings/power/qcom-rpmpd.h | 8 +++++
> 8 files changed, 75 insertions(+)
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 00/10] Add Power Domains and Regulators in SDX75
2023-07-03 15:27 ` [PATCH 00/10] Add Power Domains and Regulators in SDX75 Bjorn Andersson
@ 2023-07-04 6:16 ` Rohit Agarwal
0 siblings, 0 replies; 27+ messages in thread
From: Rohit Agarwal @ 2023-07-04 6:16 UTC (permalink / raw)
To: Bjorn Andersson
Cc: agross, konrad.dybcio, lee, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linus.walleij, lgirdwood, broonie, sboyd, linux-arm-msm,
devicetree, linux-kernel, linux-gpio
On 7/3/2023 8:57 PM, Bjorn Andersson wrote:
> On Mon, Jul 03, 2023 at 08:12:16PM +0530, Rohit Agarwal wrote:
>> Hello,
>>
>> This series adds driver and dt-bindings related changes
>> in SDX75 to add power domains and regulators.
>>
> Thanks for your patches, Rohit. Really nice to see the SDX75 support
> being upstreamed.
>
> This series is to be merged by five (5) different maintainers, with no
> dependencies between them, afaict. The likely outcome is confusion and
> some of the patches being left behind on the list.
>
> To reduce this risk of confusion and to get your patches looked at, and
> merged, faster, please send independent series/patches separately in the
> future.
Sure Bjorn, Thanks for the suggestion. Will surely work on this and keep
in mind
while sending patches in future.
Thanks,
Rohit.
> Regards,
> Bjorn
>
>> Thanks,
>> Rohit.
>>
>> Rohit Agarwal (10):
>> dt-bindings: regulator: Add PMX75 compatibles
>> dt-bindings: power: Add rpm power domains for SDX75
>> dt-bindings: mfd: Add compatible for pm7550ba
>> dt-bindings: pinctrl: qcom-pmic-gpio: Add pm7550ba support
>> dt-bindings: mfd: Add compatible for pmx75
>> dt-bindings: pinctrl: qcom-pmic-gpio: Add pmx75 support
>> soc: qcom: rpmhpd: Add SDX75 power domains
>> regulator: qcom-rpmh: Add support for SDX75
>> pinctrl: qcom-pmic-gpio: Add support for pm7550ba
>> pinctrl: qcom-pmic-gpio: Add support for pmx75
>>
>> .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 ++
>> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 6 ++++
>> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
>> .../bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++
>> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 ++
>> drivers/regulator/qcom-rpmh-regulator.c | 38 ++++++++++++++++++++++
>> drivers/soc/qcom/rpmhpd.c | 16 +++++++++
>> include/dt-bindings/power/qcom-rpmpd.h | 8 +++++
>> 8 files changed, 75 insertions(+)
>>
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 27+ messages in thread