From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Arnd Bergmann <arnd@arndb.de>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Tony Lindgren <tony@atomide.com>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: omap: avoid clang warning
Date: Thu, 14 Mar 2019 12:58:06 +0200 [thread overview]
Message-ID: <e15686f1-7ec7-194f-d5f2-0892964f91c5@ti.com> (raw)
In-Reply-To: <20190307103348.1591457-1-arnd@arndb.de>
Hi Arnd,
On 07.03.19 12:33, Arnd Bergmann wrote:
> clang warns about a tentative array definition in the gpio-omap driver:
>
> drivers/gpio/gpio-omap.c:1282:34: error: tentative array definition assumed to have one element [-Werror]
> static const struct of_device_id omap_gpio_match[];
>
> It's best to just reorder the entire file to avoid forward declarations,
> which lets us use the regular declaration. To do this, the unnecessary
> CONFIG_OF check must also be removed.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpio/gpio-omap.c | 549 +++++++++++++++++++--------------------
> 1 file changed, 267 insertions(+), 282 deletions(-)
Sry, for delayed reply
I do not have objection to the patch itself, so
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
but personally i do not like such changes as they kill "git blame" :(,
I assume there would be merge conflict with
https://lkml.org/lkml/2019/3/11/945
--
Best regards,
grygorii
next prev parent reply other threads:[~2019-03-14 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 10:33 [PATCH] gpio: omap: avoid clang warning Arnd Bergmann
2019-03-11 9:39 ` Bartosz Golaszewski
2019-03-11 12:09 ` Arnd Bergmann
2019-03-14 10:58 ` Grygorii Strashko [this message]
2019-04-03 16:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e15686f1-7ec7-194f-d5f2-0892964f91c5@ti.com \
--to=grygorii.strashko@ti.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=jmkrzyszt@gmail.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).