From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A63AECAAA1 for ; Tue, 30 Aug 2022 08:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbiH3I04 (ORCPT ); Tue, 30 Aug 2022 04:26:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231469AbiH3I0z (ORCPT ); Tue, 30 Aug 2022 04:26:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C992372FE7; Tue, 30 Aug 2022 01:26:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 511FC6153F; Tue, 30 Aug 2022 08:26:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6FBEC433C1; Tue, 30 Aug 2022 08:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661848013; bh=0Kcd47M1Gp8kFRDeRQ4RQQHp2Sfbb0yfmxJLbNXXTAI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tfufUU/A3QjZ3m+QLaSb6e4HmqCItYxnDxEURQDGy7MtmDrUAl7zsgv5pZqZgk8zJ N9gmw0rwi4N4GwX3DYnBDrjgzZGzKqvrVHDz0e34HIH/jj65bLQM3Wh95gV9DhfhVq mx5LMTMkGP1xU0GuZea2HCRHlTLBc8pU3Fpq7ObE9tCrDzbkPQeLYODSl1P8JgALrB /9M7b+U9/mOugZxB/DAFINjVxsmpo234dauIHV37w855hCVQ9krxtRthjRE6y7zDxQ aUzBjWYsAX+FBg03eRkNyB/gASlTXheuWRXkGkgeE0nlMyWOjP+I/ApYK1EYbWGIQf 8XpT1AHJnEBOg== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oSwaB-006fye-EW; Tue, 30 Aug 2022 09:26:51 +0100 MIME-Version: 1.0 Date: Tue, 30 Aug 2022 09:26:51 +0100 From: Marc Zyngier To: Manivannan Sadhasivam Cc: linus.walleij@linaro.org, bjorn.andersson@linaro.org, robimarko@gmail.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org, steev@kali.org Subject: Re: [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable In-Reply-To: <20220830081212.164709-1-manivannan.sadhasivam@linaro.org> References: <20220830081212.164709-1-manivannan.sadhasivam@linaro.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: manivannan.sadhasivam@linaro.org, linus.walleij@linaro.org, bjorn.andersson@linaro.org, robimarko@gmail.com, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org, steev@kali.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 2022-08-30 09:12, Manivannan Sadhasivam wrote: > The IRQCHIP implementation used inside the gpiochips are not supposed > to lower case > be changed during runtime. So let's make the one inside the spmi-gpio > gpiochip immutable. > > This fixes the below warning during boot: > gpio gpiochip0: (c440000.spmi:pmic@0:gpio@c000): not an immutable > chip, please consider fixing it! > > Separate callbacks need to be provided for irq_{mask/unmask} pointers > since > the callbacks are supposed to mask/unmask the corresponding parent IRQ > in > addition to changing the gpio_desc flags. This is all part of the existing documentation, so I don't think this is really needed. > > Signed-off-by: Manivannan Sadhasivam With the above fixed: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny...