From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32FB52475CB for ; Fri, 12 Sep 2025 09:30:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757669453; cv=none; b=GECdGhqNBczfYpnJRv4lA0OoJLyj+O+ohYpXhI+9F8Le0gos6Tq0Mqxa+64sbyOBdvfOfnF0036N/oZva5H3f9wQjtKu/QO7ivdqQHcgFpMQN+eXwTv5dWPucJmrcJ2aHgN6C3wqRvu9Sn92Kgfz/iuEJoOFUy3GH/f1zTR+0jA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757669453; c=relaxed/simple; bh=hlFmZz3SH60ObFcUVFihSDYbAv89r8HSRjShTlrdIsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=liQIKKD0L3jCyF1kdIbzZVAuoXBautN2A6ZBI7Jfh/ZCMPZFC70UvhEYpVz9YDOA7nMLNETGTm6O7WsivSF+nYIHrAsUpSHtfz7jImIgfBeorFflGVIoEF+rtzNz3kqdmSdFZeU26Gi0tTFlCGIi5zOMZVE3odUBojklLxpt1ec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cFniJmmQ; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cFniJmmQ" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-336b908cbaaso14857901fa.1 for ; Fri, 12 Sep 2025 02:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757669449; x=1758274249; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1aIzMN9zlpmsGg+d+g9UzqtnL/LipD0ZeBNikSa1LIw=; b=cFniJmmQ5Lxb0hkNPsbrIInytWJhan/X+PvCKECdZYZqKMOYXYupkd556Pfn+mWgZb rRW1F8kYDS0Vro6110NS4BHxY6ZEndURgbDHuRa1SxVxY68+ZVJPYREbgvw4cN92ObMV /K9hojIc5wxhKSVvW19VVo9/RhhBTb5q6OplQ+bFHWYo4/j3TSCpCMn6TrnBjiH9Sapx LzPZr9627aDiHobtH1lAFebqVqCDXDiq59qv0hVR0myO+ZGsOG4ax8X4OqpohyEC9lO/ kNH33uE1lfE/71zASTecwEA3y8iXW0eTXED/mXPYN79+FCWDxbmqfSaQOg2KKdtnzDtA b8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757669449; x=1758274249; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1aIzMN9zlpmsGg+d+g9UzqtnL/LipD0ZeBNikSa1LIw=; b=kE4Yr/RBcFQVJ1q6cte9gjJQ1r6Uhsq8IOy9XRhHz3m1EhWCftGlJRKrw/3hBPKJ6I Udj7dGlYet7JuPCaQMxvzbaopxRIFuCgCaCw0xCQdo+FOQCzOiJX3No8qf0rTsbioToY sOP6YUSoX5Hm/gl6Fy0nRNWT6+LRCBl8JnJ0frCJp68tHCC8joaoy4yJffXEn0U7HLMv UYKXbvHCKVTY8BZvVdsIpRUTdb/BYm1wuMH/XkJoBh4czCC2chYHJUzf9Hm17IaX/X3S ofsIU2uJEY9KvU9PTsC8hlA0ND7yyPkV4kfUTKdVlm4MwwJJdkhqid0SmUaA5G13AlWU a8lA== X-Forwarded-Encrypted: i=1; AJvYcCVs+qVa+80BEZE08sPDA6dXmlsci239co5YSwJF9L8QBt1TXsAXLrT54fDs6nvjnmcxfBUNvdxLLAlq@vger.kernel.org X-Gm-Message-State: AOJu0YzZGbhYWqBw87bWeJwDRJ/9Red2EvJb/tzWAUWXfO6CM35pvGGd TsCbhE4qqfAGJxf08b2UuxYvCiIYptiHyskYXqBtQ/ihNT/NHoCRCscF X-Gm-Gg: ASbGncsrsUGIpI3PJwCgzdpgfWoFUsdumqwmZYoAFT0SsQgrknClf+rUmvGzOoahFS4 qMAm1MDVubKbsu5TFiAq4mDmL3WpPkDuuuMdUOrfJtifah1r3KzdnEmccpORLCUUUOEaKcH5hpU ceJ4YK/xtI3V4YfYRQOvOf6dMyhAoGz3mUoYd1HAQE1pvDHcB5RI66QSCTC1LasKp36hqNmCKOm JkQkkDWmuWWVzc9Wn1Hb8uX7dAZHLf2FIrLWEO2XDc81M2DkomgUDXPTXKdTbcstBmUCl69g4sn 6oO5rqhhtge/Z1LW4OVUDpQBtYx/h2ak/xr6ABH0CNGzeqlEFJxZoIIJMBHHGSG15rTvOJ1IgHy SZ1v12QwcuUWcciwSiIB3cP9urOOID5Ez X-Google-Smtp-Source: AGHT+IHZhvTFouH7z71/PdL2eJrkzX4Jjes9ijVKOIiaqvUL1DLMmrokCFicYDILisJ+kbtNo+bM5Q== X-Received: by 2002:a2e:a231:0:b0:337:f84a:6ded with SMTP id 38308e7fff4ca-3514165afb4mr5768781fa.40.1757669448935; Fri, 12 Sep 2025 02:30:48 -0700 (PDT) Received: from [10.38.18.54] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-34f1b491f41sm7463431fa.57.2025.09.12.02.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 02:30:48 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 12:30:47 +0300 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO To: David Lechner , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20250910-bd79112-v4-0-f82f43746a8c@gmail.com> <20250910-bd79112-v4-2-f82f43746a8c@gmail.com> <92306c8a-a2ec-4a43-80d7-c8e0c1cc0ee1@baylibre.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <92306c8a-a2ec-4a43-80d7-c8e0c1cc0ee1@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/09/2025 00:20, David Lechner wrote: > On 9/10/25 6:24 AM, Matti Vaittinen wrote: > > ... > >> diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c >> new file mode 100644 >> index 0000000000000000000000000000000000000000..a2a3affe2c6dc86a237a164139c27ec66dc9d131 >> --- /dev/null >> +++ b/drivers/iio/adc/rohm-bd79112.c >> @@ -0,0 +1,553 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * ROHM ADC driver for BD79112 signal monitoring hub. >> + * Copyright (C) 2025, ROHM Semiconductor. >> + * >> + * SPI communication derived from ad7923.c and ti-ads7950.c > > Really? I wrote the ti-ads7950 driver and I can't say I see the > resemblance. ;-) Really. :) I picked the idea of populating the transfers in the probe and using buffers from the driver-data, from these drivers :) Well, I admit it ended up being a bit different - but the starting point was those drivers ;) > >> + */ >> + > > ... > >> +static int bd79112_get_gpio_pins(const struct iio_chan_spec *cs, int num_channels) > > u32 would make more sense when dealing with bit flags. > >> +{ >> + int i, gpio_channels; > > same for the local variable. Meh. Ok :) > ... > >> +static int bd79112_probe(struct spi_device *spi) >> +{ > > ... > >> + >> + data->read_xfer[0].tx_buf = &data->read_tx[0]; >> + data->read_xfer[0].len = sizeof(data->read_tx); >> + data->read_xfer[0].cs_change = 1; >> + data->read_xfer[1].rx_buf = &data->read_rx; >> + data->read_xfer[1].len = sizeof(data->read_rx); >> + spi_message_init_with_transfers(&data->read_msg, data->read_xfer, 2); >> + >> + data->write_xfer.tx_buf = &data->reg_write_tx[0]; >> + data->write_xfer.len = sizeof(data->reg_write_tx); >> + spi_message_init_with_transfers(&data->write_msg, &data->write_xfer, 1); > > If these messages never change (other than the data in the buffers), you can > call devm_spi_optimize_message() here on each message to get reduced CPU usage > on every SPI message for free. > Thanks! Yours, -- Matti