From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure Date: Sun, 16 Jul 2017 23:12:15 -0500 Message-ID: References: <20170711180339.GA17806@embeddedgus> <877ezdh3jn.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <877ezdh3jn.fsf@eliezer.anholt.net> Sender: linux-kernel-owner@vger.kernel.org To: Eric Anholt , Linus Walleij , Florian Fainelli , Ray Jui , Scott Branden , Stefan Wahren Cc: bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On 07/12/2017 02:13 PM, Eric Anholt wrote: > "Gustavo A. R. Silva" writes: > >> This structure is only used to copy into other structure, so declare >> it as const. >> >> This issue was detected using Coccinelle and the following semantic patch: > Acked-by: Eric Anholt Thank you, Eric >> --- >> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c >> index 2308831..7203f35 100644 >> --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c >> +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c >> @@ -353,7 +353,7 @@ static int bcm2835_gpio_direction_output(struct gpio_chip *chip, >> return pinctrl_gpio_direction_output(chip->base + offset); >> } >> >> -static struct gpio_chip bcm2835_gpio_chip = { >> +static const struct gpio_chip bcm2835_gpio_chip = { >> .label = MODULE_NAME, >> .owner = THIS_MODULE, >> .request = gpiochip_generic_request, >> -- >> 2.5.0 -- Gustavo A. R. Silva