linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keerthy <j-keerthy@ti.com>
To: linus.walleij@linaro.org, t-kristo@ti.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	gnurou@gmail.com, grygorii.strashko@ti.com
Subject: Re: [PATCH V2 6/6] gpio: davinci: Remove redundant macros
Date: Mon, 16 Jan 2017 12:27:12 +0530	[thread overview]
Message-ID: <e38d4a3f-1f48-142b-b5c5-b45da9c55b0d@ti.com> (raw)
In-Reply-To: <1484281215-24576-7-git-send-email-j-keerthy@ti.com>

Linus,

On Friday 13 January 2017 09:50 AM, Keerthy wrote:
> Some of the macros were needed as per old driver design.
> With the current implementation they are unwanted. Hence remove
> them.

Seems like Macros are being used in:
arch/arm/mach-davinci/board-neuros-osd2.c

So this patch can be dropped from the series.

>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  include/linux/platform_data/gpio-davinci.h | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h
> index 90ae19c..f922601 100644
> --- a/include/linux/platform_data/gpio-davinci.h
> +++ b/include/linux/platform_data/gpio-davinci.h
> @@ -45,14 +45,6 @@ struct davinci_gpio_controller {
>  	unsigned int		base;
>  };
>
> -/*
> - * basic gpio routines
> - */
> -#define	GPIO(X)		(X)	/* 0 <= X <= (DAVINCI_N_GPIO - 1) */
> -
> -/* Convert GPIO signal to GPIO pin number */
> -#define GPIO_TO_PIN(bank, gpio)	(16 * (bank) + (gpio))
> -
>  static inline u32 __gpio_mask(unsigned gpio)
>  {
>  	return 1 << (gpio % 32);
>

  parent reply	other threads:[~2017-01-16  6:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  4:20 [PATCH V2 0/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip Keerthy
2017-01-13  4:20 ` [PATCH V2 1/6] gpio: davinci: Remove gpio2regs function to accommodate multi instances Keerthy
2017-01-13  4:20 ` [PATCH V2 2/6] gpio: davinci: Remove unwanted blank line Keerthy
2017-01-13  4:20 ` [PATCH V2 3/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip Keerthy
2017-01-18 23:22   ` Linus Walleij
2017-01-13  4:20 ` [PATCH V2 4/6] gpio: davinci: Add support for multiple GPIO controllers Keerthy
2017-01-13  4:20 ` [PATCH V2 5/6] gpio: davinci: Remove custom .xlate Keerthy
2017-01-13  4:20 ` [PATCH V2 6/6] gpio: davinci: Remove redundant macros Keerthy
2017-01-15  4:31   ` kbuild test robot
2017-01-16  6:57   ` Keerthy [this message]
2017-01-13 18:02 ` [PATCH V2 0/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e38d4a3f-1f48-142b-b5c5-b45da9c55b0d@ti.com \
    --to=j-keerthy@ti.com \
    --cc=gnurou@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).