From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E089020E01A for ; Tue, 1 Apr 2025 16:20:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743524412; cv=none; b=XsrpiT+DVxoGXyghY8VRIjDtCgEuLDk8pxM/idiP50AuJMGxto2NKLf/YtIpmMj2UZvA+4FgMmy2nCQNu5NndbDOKOA3d533dDuR4D3BhrRAP5GgF4c/ynmju4evi7P+oPFctNlI6sf59Qf6nHf+fWS/zlvj2adZ0Sd9cX9Y/+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743524412; c=relaxed/simple; bh=+gL7pqviWCTSkJIhD8SI688Pv1X16XRWBd25qPBRg20=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=red3IbOTZ1aURhwsqwMfq9isoVggKnT3VNyVFTd2VTnEjIjDToXCHmUhfzRXTtGII7ww526TaF0R3s4xk/ZK+CtnSNlHln9H6TtNk2lUSXfq4KhzchOLiXjTN6YOh6lHyhOJcmIANkNJIgycJrlQsjhDLzey6TQoYjinjUK5yFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Pi6sgHw5; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Pi6sgHw5" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-2a01bcd0143so6146919fac.2 for ; Tue, 01 Apr 2025 09:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1743524410; x=1744129210; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yD6imsgkoRBmKikS0REDEdzThJO/QBBTFKUjw+FE6FA=; b=Pi6sgHw52otpqLufj5O/uy0SJWB21oxopbZRTVpNL+5t1pao36G9Y6uSaGq86Lexk4 VqJbKydPcJL9HvPRQ/yYa/i+KccGqcXxLSLIWIz/5wpk3ccDuUhJuJDWfnRZl4A0YGJk G0Cmb07GlmzMmAVyJ55EeNCVdTK4GC61+83u2cWWrVKVqyfP2AVyLJ1B0kH6VITurYOF HfHnWzGBVZ7jPQzWH1QSJFGFkTeV2IbOEftx2yy8GT4IMUSncbc91Ba/CCTayLdwJxFA TkcrUDL5DsxEbTGX8j+DxQNUad0S4s9VG62YBc5V3zRCCjg6/UbucsREaI8LEs9yU6VA zClg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743524410; x=1744129210; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yD6imsgkoRBmKikS0REDEdzThJO/QBBTFKUjw+FE6FA=; b=mg3b1UAa/I2XrxbBHcN2HdlQ3QSO+v6T67F1tZc/0WanmVzIXWR3qmlRooGjVC2wd5 0hwxrNGfQ9VAmt1VjWoM9FsaYY1IHnQUPe4FGwg4hAD6fbU+PAje4Jjf29Y2dGHIB1oc u36HVoRnRwKKh6j/GuTATUJgPpwgUlDXOvjF+s5XHv+J8jtEJEcxfEJgeMA8yTMoNlcI oGCsLomizfQ3Kzg7gb+jcP2xoDZLUJKlWrgdT2Vgl9aVE+2nwN7JRMsME2uJy+sDF71D Sl4SY74MMjGMFor6RaZEwGHSeqPdy00GjMcskxQy5X60WK3hVpzkvvSd6d+Op/oTQvfc qDBA== X-Forwarded-Encrypted: i=1; AJvYcCUFbMHoqubkDBC2lDk2qcPg78GElr4U0JZ5rm/AceP5k8w+0iFTo7vCCGCwi+oBvFNdz+UrRa0F/j/V@vger.kernel.org X-Gm-Message-State: AOJu0Yxh/iIAhHsN94Uds+nPy1lz/z3DUZ880/OWJA/64YXOktn8Fl5r 0zOcDYxSR1yEgJtJZxVSUdW0mbnTYKmPpPjfgoMi/DcvnwXMkYb04z4Lm7u+Bc0= X-Gm-Gg: ASbGncvn9RE+8sEOeVw4VnGuhMcx/jJurLLUfwPRYLSbxAHUXMy8rFTzaiJkDr8W4Q+ erjDvQk8zIp68gCRVrf8RO/JrTdBdQu5ufTDJQ6xExUjBeadZEVYb6IthIEpq05bv1mtkov5n/Z khzp1Mh0f79ZPchhoeILyEIDYSVya//BBqNFXTyc1P/fq69U+raah5pexFJISWtMMgOol1fGstN aADeUUCAFS6zuqaBAKORs37F54GE4h9rieAh0v2ArNaosro8kDt9vbILf59zkN5t0Jnc5bbOt0z SbygZnFw8jgu2C2Df3ZjXVipGMudJdDLzodAB/MXXsOyacgUE+iAL+dTfmX9PRA61l7vFB5mL+r +UhuVtQ== X-Google-Smtp-Source: AGHT+IGRdAdsC+0OxQWe8MfCLWx67HbEd+4baPkKY8LWeRb8Ft8zVGD3dRLKm+iYNatE7FTS7a5YKQ== X-Received: by 2002:a05:6870:4d16:b0:2a7:d8cb:5284 with SMTP id 586e51a60fabf-2cbcf4216a3mr8115424fac.7.1743524409757; Tue, 01 Apr 2025 09:20:09 -0700 (PDT) Received: from [192.168.0.113] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2c86a497aedsm2345282fac.16.2025.04.01.09.20.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 09:20:09 -0700 (PDT) Message-ID: Date: Tue, 1 Apr 2025 11:20:08 -0500 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/17] dt-bindings: iio: adc: ad7768-1: document regulator provider property To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: lars@metafoo.de, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org, marcelo.schmitt1@gmail.com, jonath4nns@gmail.com, Conor Dooley References: <7125eea4c3386777d2211224c73e38d8f576e4f0.1741268122.git.Jonathan.Santos@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <7125eea4c3386777d2211224c73e38d8f576e4f0.1741268122.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/6/25 3:01 PM, Jonathan Santos wrote: > The AD7768-1 provides a buffered common-mode voltage output > on the VCM pin that can be used to bias analog input signals. > > Add regulators property to enable the use of the VCM output, > referenced here as vcm-output, by any other device. > > Acked-by: Conor Dooley > Signed-off-by: Jonathan Santos > --- > v4 Changes: > * replace "vcm_output" property name for "vcm-output". > > v3 Changes: > * VCM is now provided as a regulator within the device, instead of a > custom property. > > v2 Changes: > * New patch in v2. > --- > .../bindings/iio/adc/adi,ad7768-1.yaml | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml > index e2f9782b5fc8..12358ea9138a 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml > @@ -59,6 +59,19 @@ properties: > in any way, for example if the filter decimation rate changes. > As the line is active low, it should be marked GPIO_ACTIVE_LOW. > > + regulators: > + type: object > + description: > + list of regulators provided by this controller. > + > + properties: > + vcm-output: > + $ref: /schemas/regulator/regulator.yaml# > + type: object > + unevaluatedProperties: false > + > + additionalProperties: false > + > reset-gpios: > maxItems: 1 > > @@ -152,6 +165,14 @@ examples: > reg = <0>; > label = "channel_0"; > }; > + > + regulators { > + vcm_reg: vcm-output { > + regulator-name = "ad7768-1-vcm"; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <2500000>; Why do we have the min and max properties? Aren't these always going to be the same for all chips? It seems unnecessary to have to write that in the devicetree. > + }; > + }; > }; > }; > ...