From: Randy Dunlap <rdunlap@infradead.org>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>,
Arnd Bergmann <arnd@arndb.de>, Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Cc: Linus Walleij <linusw@kernel.org>,
Enrico Weigelt <info@metux.net>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: apuv2: select LEDS_CLASS
Date: Mon, 4 Mar 2019 16:09:08 -0800 [thread overview]
Message-ID: <e5f1511e-c750-8fb2-0bfe-c73bc7905b22@infradead.org> (raw)
In-Reply-To: <24c191e1-f607-1320-2474-3db92383e383@metux.net>
On 3/4/19 4:03 PM, Enrico Weigelt, metux IT consult wrote:
> On 04.03.19 21:19, Arnd Bergmann wrote:
>> LEDS_GPIO can only be selected when LEDS_CLASS is already enabled:
>>
>> WARNING: unmet direct dependencies detected for LEDS_GPIO
>> Depends on [m]: NEW_LEDS [=y] && LEDS_CLASS [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y])
>> Selected by [y]:
>> - PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && INPUT_KEYBOARD [=y]
>>
>> Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/platform/x86/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index 4d65d37b0c86..d64529352a9c 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -1308,6 +1308,7 @@ config PCENGINES_APU2
>> depends on INPUT && INPUT_KEYBOARD
>> select GPIO_AMD_FCH
>> select KEYBOARD_GPIO_POLLED
>> + select LEDS_CLASS
>> select LEDS_GPIO
>> help
>> This driver provides support for the front button and LEDs on
>>
>
> ACK. Just was about to post the same :)
>
> Reviewed-by: Enrico Weigelt, metux It consult <info@metux.net>
>
Enrico, you were also cc-ed on this patch on Feb.25, 2019:
https://marc.info/?l=linux-kernel&m=155113875310485&w=2
>
> thx.
>
> --mtx
>
--
~Randy
next prev parent reply other threads:[~2019-03-05 0:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 20:19 [PATCH 1/3] x86: apuv2: remove unused variable Arnd Bergmann
2019-03-04 20:19 ` [PATCH 2/3] x86: apuv2: fix input dependencies Arnd Bergmann
2019-03-05 0:18 ` Enrico Weigelt, metux IT consult
2019-03-05 8:23 ` Arnd Bergmann
2019-03-05 13:50 ` Enrico Weigelt, metux IT consult
2019-03-05 13:56 ` Andy Shevchenko
2019-03-07 0:10 ` Enrico Weigelt, metux IT consult
2019-03-07 7:03 ` Darren Hart
2019-03-05 16:46 ` Arnd Bergmann
2019-03-04 20:19 ` [PATCH 3/3] x86: apuv2: select LEDS_CLASS Arnd Bergmann
2019-03-05 0:03 ` Enrico Weigelt, metux IT consult
2019-03-05 0:09 ` Randy Dunlap [this message]
2019-03-08 9:05 ` Linus Walleij
2019-03-05 0:04 ` [PATCH 1/3] x86: apuv2: remove unused variable Enrico Weigelt, metux IT consult
2019-03-05 13:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f1511e-c750-8fb2-0bfe-c73bc7905b22@infradead.org \
--to=rdunlap@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=dvhart@infradead.org \
--cc=info@metux.net \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).