From: Krzysztof Kozlowski <krzk@kernel.org>
To: Detlev Casanova <detlev.casanova@collabora.com>,
linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Steven Liu <steven.liu@rock-chips.com>
Subject: Re: [PATCH 1/2] pinctrl: rockchip: Add rk3576 pinctrl support
Date: Sun, 4 Aug 2024 11:58:17 +0200 [thread overview]
Message-ID: <e65160a7-53c6-48d2-bfb2-50c807e56299@kernel.org> (raw)
In-Reply-To: <20240802145458.291890-2-detlev.casanova@collabora.com>
On 02/08/2024 16:52, Detlev Casanova wrote:
> From: Steven Liu <steven.liu@rock-chips.com>
>
> Add support for the 5 rk3576 GPIO banks.
>
> +static struct rockchip_pin_ctrl rk3576_pin_ctrl __maybe_unused = {
> + .pin_banks = rk3576_pin_banks,
> + .nr_banks = ARRAY_SIZE(rk3576_pin_banks),
> + .label = "RK3576-GPIO",
> + .type = RK3576,
> + .pull_calc_reg = rk3576_calc_pull_reg_and_bit,
> + .drv_calc_reg = rk3576_calc_drv_reg_and_bit,
> + .schmitt_calc_reg = rk3576_calc_schmitt_reg_and_bit,
> +};
> +
> static struct rockchip_pin_bank rk3588_pin_banks[] = {
> RK3588_PIN_BANK_FLAGS(0, 32, "gpio0",
> IOMUX_WIDTH_4BIT, PULL_TYPE_IO_1V8_ONLY),
> @@ -4005,6 +4231,8 @@ static const struct of_device_id rockchip_pinctrl_dt_match[] = {
> .data = &rk3399_pin_ctrl },
> { .compatible = "rockchip,rk3568-pinctrl",
> .data = &rk3568_pin_ctrl },
> + { .compatible = "rockchip,rk3576-pinctrl",
> + .data = &rk3576_pin_ctrl },
Undocumented compatible. Bindings come before users.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-04 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 14:52 [PATCH 0/2] Add pinctrl support for rk3576 Detlev Casanova
2024-08-02 14:52 ` [PATCH 1/2] pinctrl: rockchip: Add rk3576 pinctrl support Detlev Casanova
2024-08-04 9:58 ` Krzysztof Kozlowski [this message]
2024-08-02 14:52 ` [PATCH 2/2] dt-bindings: pinctrl: Add rk3576 pinctrl bindings Detlev Casanova
2024-08-04 9:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e65160a7-53c6-48d2-bfb2-50c807e56299@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=steven.liu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox