Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>,
	linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format
Date: Tue, 22 Oct 2024 09:28:04 +0200	[thread overview]
Message-ID: <e766b50c-818c-421a-a71d-e2529b56bd24@kernel.org> (raw)
In-Reply-To: <20241022060157.36372-1-himanshu.bhavani@siliconsignals.io>

On 22/10/2024 08:01, Himanshu Bhavani wrote:
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +    
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        
> +        mcp23017: gpio@20 {
> +            compatible = "microchip,mcp23017";
> +            reg = <0x20>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <17 IRQ_TYPE_LEVEL_LOW>; // Check this line

Hm? Left-over?

BTW, did you test this before sending?

Best regards,
Krzysztof


  parent reply	other threads:[~2024-10-22  7:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22  6:01 [PATCH] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format Himanshu Bhavani
2024-10-22  6:33 ` Krzysztof Kozlowski
2024-10-22  8:19   ` Himanshu Bhavani
2024-10-22  7:25 ` Rob Herring (Arm)
2024-10-22  9:22   ` Himanshu Bhavani
2024-10-22 14:12     ` Rob Herring
2024-10-22  7:28 ` Krzysztof Kozlowski [this message]
2024-10-22  7:58   ` Himanshu Bhavani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e766b50c-818c-421a-a71d-e2529b56bd24@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=himanshu.bhavani@siliconsignals.io \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox