From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26756C4321E for ; Thu, 3 Feb 2022 14:56:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351589AbiBCO4G (ORCPT ); Thu, 3 Feb 2022 09:56:06 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:39456 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351577AbiBCO4B (ORCPT ); Thu, 3 Feb 2022 09:56:01 -0500 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4BD554003F for ; Thu, 3 Feb 2022 14:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1643900160; bh=JKwlxtatWZQCVG4GF4BszucWwjVQTt2PxoebrxL5ciY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i6yA7t9Cv2ukmUXvHhtNRdUE9hNLWOnYQ2g7APjSZAMHCMKpeANi/B1ZtgoguxDA5 Nm8VGjt1PXrQCyAjvavzejgvqNwBlvEgSHGjKPyLksrXFul6IDWxivqgsLUUGcCUjS fYm9h6Pyw0RXim93IOsKpnABcf1QYGK+V8qRcDxd11bioFzHas2El667YHdN3q+EGT 2qj40Z0/CY+7lpUpF8OMylyrNyz35bRpUel+rnHAY/Czwj0Tnr1Wlb+rKxCPcM4sIj 7RfT/OhKWfuiBotVjERE1wg8fEM53q7Hpi+txS+3Vpb2pmHIpb1VidkUD8X5eEaxz4 C9+xoRt97/5cg== Received: by mail-ed1-f72.google.com with SMTP id c23-20020a056402159700b00406aa42973eso1591154edv.2 for ; Thu, 03 Feb 2022 06:56:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JKwlxtatWZQCVG4GF4BszucWwjVQTt2PxoebrxL5ciY=; b=wGu/0CJSPlB7jfz3xjDNMrGX90LDdoEz2ajcT7E9CxWlvDJ/jQBBeR5iJM/VMCrpjM jcvNmJLaeCzFb+/3j2UzOKuo8in1Nzeph77PerFV5S9/Q8pFCHmv1C4jGd8kMyNpmjOt xsHAfKpYku8w2OC78ubh6f9Llc0ENP++UrYlXSWTuttld5rGYhZz0YdUtuRh/rtHXNP9 AQKYZXlDl3L4z8aFOBihkjBo44dXCiAU3Tx1xffO4mBClQps0iATGKh093zOaQLH7KTm xxtaQSece979YGIb6idpeVWHaumKcqGyV0G3F3M8GW+ensnkiBSVbL4SZfW3pPqIBH3p f1Aw== X-Gm-Message-State: AOAM532tS1KUr2z7DbetifLklqjUAfhxyd4z+7mWL7j9A7u03yzYBKOL Erzx/TRfs2hSNW3jckb51wHS4tJZzTd6w/Z6L7MwWC3ZGbpWZbLB3qakkbO4A3HdVH+qo2tsPQT FWhrVrvAiNJKQPYappYpfM/7HH3n5zcL7WjiC4kA= X-Received: by 2002:a17:907:c14:: with SMTP id ga20mr1992505ejc.243.1643900159540; Thu, 03 Feb 2022 06:55:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxET41+skPJ0t2ws3cpvdAuE3SIGtoLLzPApxhNtKVWxdECIqy/nqXcAWE2tMCANk5h/+crhA== X-Received: by 2002:a17:907:c14:: with SMTP id ga20mr1992450ejc.243.1643900159293; Thu, 03 Feb 2022 06:55:59 -0800 (PST) Received: from [192.168.0.81] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id z19sm7573934eja.18.2022.02.03.06.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 06:55:58 -0800 (PST) Message-ID: Date: Thu, 3 Feb 2022 15:55:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] HPE BMC GXP SUPPORT Content-Language: en-US To: Rob Herring , nick.hawkins@hpe.com Cc: verdun@hpe.com, David Airlie , Daniel Vetter , Linus Walleij , Bartosz Golaszewski , Corey Minyard , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "David S. Miller" , Jakub Kicinski , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Lee Jones , Greg Kroah-Hartman , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Russell King , Arnd Bergmann , Olof Johansson , SoC Team , Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Hao Fang , "Russell King (Oracle)" , Mark Rutland , Marc Zyngier , Ard Biesheuvel , Anshuman Khandual , Wang Kefeng , Lukas Bulwahn , Masahiro Yamada , dri-devel , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Linux I2C , openipmi-developer@lists.sourceforge.net, MTD Maling List , netdev , Linux PWM List , "open list:SERIAL DRIVERS" , linux-spi , "open list:THERMAL" , Linux USB List , LINUX-WATCHDOG , linux-arm-kernel References: <20220202165315.18282-1-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 03/02/2022 15:29, Rob Herring wrote: > On Wed, Feb 2, 2022 at 10:55 AM wrote: >> >> From: Nick Hawkins >> (...) >> + >> + vuart_a: vuart_a@80fd0200 { > > serial@... Maybe it does not look like, but this is actually a v2. Nick was asked to change the naming for the nodes already in v1. Unfortunately it did not happen, so we have vuart, spifi, vic and more. It is a waste of reviewers' time to ask them to perform the same review twice or to ignore their comments. > >> + compatible = "hpe,gxp-vuart"; >> + reg = <0x80fd0200 0x100>; >> + interrupts = <2>; >> + interrupt-parent = <&vic1>; >> + clock-frequency = <1846153>; >> + reg-shift = <0>; >> + status = "okay"; >> + serial-line = <3>; >> + vuart_cfg = <&vuart_a_cfg>; >> + }; (...) >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml >> index 294093d45a23..913f722a6b8d 100644 >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml >> @@ -514,7 +514,9 @@ patternProperties: >> "^hoperun,.*": >> description: Jiangsu HopeRun Software Co., Ltd. >> "^hp,.*": >> - description: Hewlett Packard >> + description: Hewlett Packard Inc. > > Why are you changing this one? I guess this is squashing of my patch: https://lore.kernel.org/all/20220127075229.10299-1-krzysztof.kozlowski@canonical.com/ which is fine to me, but vendor changve should be a separate commit with its own explanation. Now it looks indeed weird. > >> + "^hpe,.*": > > You used HPE elsewhere... Lowercase is preferred. Best regards, Krzysztof