From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: qcom-msm8960-cdp: align TLMM pin configuration with DT schema
Date: Tue, 8 Nov 2022 19:49:32 +0100 [thread overview]
Message-ID: <e858e76a-17d6-9f11-e0f1-90cd3c888689@linaro.org> (raw)
In-Reply-To: <20221108184529.26857-3-krzysztof.kozlowski@linaro.org>
On 08/11/2022 19:45, Krzysztof Kozlowski wrote:
> DT schema expects TLMM pin configuration nodes to be named with
> '-state' suffix and their optional children with '-pins' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-msm8960-cdp.dts | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> index 3a484ac53917..9a3a510f88ca 100644
> --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
> @@ -60,33 +60,32 @@ &gsbi5_serial {
> };
>
> &msmgpio {
> - spi1_default: spi1_default {
> - mux {
> - pins = "gpio6", "gpio7", "gpio9";
> - function = "gsbi1";
> - };
> -
> - mosi {
> + spi1_default: spi1-default-state {
> + mosi-pins {
> pins = "gpio6";
> + function = "gsbi1";
> drive-strength = <12>;
> bias-disable;
> };
>
> - miso {
> + miso-pins {
> pins = "gpio7";
> + function = "gsbi1";
> drive-strength = <12>;
> bias-disable;
> };
>
> - cs {
> + cs-pins {
> pins = "gpio8";
> + function = "gpio";
> drive-strength = <12>;
> bias-disable;
> output-low;
> };
>
> - clk {
> + clk-pins {
> pins = "gpio9";
> + function = "gsbi1";
> drive-strength = <12>;
> bias-disable;
> };
next prev parent reply other threads:[~2022-11-08 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 18:45 [PATCH 1/3] dt-bindings: pinctrl: qcom,msm8960: convert to dtschema Krzysztof Kozlowski
2022-11-08 18:45 ` [PATCH 2/3] ARM: dts: qcom-msm8960: use define for interrupt constants Krzysztof Kozlowski
2022-11-08 18:49 ` Konrad Dybcio
2022-11-08 18:45 ` [PATCH 3/3] ARM: dts: qcom-msm8960-cdp: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-11-08 18:49 ` Konrad Dybcio [this message]
2022-11-09 10:28 ` [PATCH 1/3] dt-bindings: pinctrl: qcom,msm8960: convert to dtschema Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e858e76a-17d6-9f11-e0f1-90cd3c888689@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).