From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8BAC433FE for ; Tue, 8 Nov 2022 18:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbiKHSu2 (ORCPT ); Tue, 8 Nov 2022 13:50:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbiKHSuD (ORCPT ); Tue, 8 Nov 2022 13:50:03 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06E0C6CA04 for ; Tue, 8 Nov 2022 10:49:36 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id a13so23958923edj.0 for ; Tue, 08 Nov 2022 10:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=901AouGB9Xg2LgWXbPxYdin3rXeDsm5qAW0ykXSOses=; b=ehr2ShxEm9RLIvfr3sNgzoAbvo2A51ZnO0kwCV56E6a1JjYKUBFXTq/3PYdg03dlpF uf6FOkBuWOT5IjJgUPcz4eV4QqyTWxZoL2HF+ZrFDNuzu77OHWPKp4rf+G6FDgA0vtpb lG1MxqlwxnvnOyHc5iF3MMC6XdTD3HFCexEIao53GW/p6OjWaaV0a/mVZX2lpT7GMO8y OryiRfch6g0PNhzsFjnqCQ6xg7eaCTBSzMjlAGVn+e5C6UbmMV8yn0NkDEdzJgq69hD/ EOCZH6G6ERtz5EB1If+Qu7ldWWvSkKCHwHzzZFiaydOHVyaJZ3XoBDl/ygFNoxaBISFH E4hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=901AouGB9Xg2LgWXbPxYdin3rXeDsm5qAW0ykXSOses=; b=p5+t/ipYQEEM27qOmMpwX+KoLMAdbQLV9qFtTRw+pEWjl5zdW+nlGuKiyKo/n09IZt bfxIxafHsvcctAxqx2bitG/qEvrpveQuMR6cDFcS54BAbWOznYafgR6Eb2ACr3RbAXGM wn+alcn7UjiONyxHr+COtiYa7CQo+JEjBFHzQrx4h/OuYY5pFtr3azB62R1MnWvOueIQ nYsh0S9Jqse6iDr1WuOF/34G8DItMYSEQdXQg6fA/dLI3Ogwh+spUmA3kLLdoWPRHpgz 923cDHDnVi0a86dYoT7JZOoong3CNirxONwUM7IO0SX52lccsf8lYTrAHshKV3Kkh+tA EnpQ== X-Gm-Message-State: ACrzQf3czkXATjRf/HXdX9qHdJ1WRi1CKHaMDz3+J7uTR0NyKOVgzBfE 2Q9djV1RbYnAuVDsg63JApZlG+hoMUgOjn6a X-Google-Smtp-Source: AMsMyM7bPFokM1yFe/uSfDmKd/Qw9LPK6GyYQwK49gEHNuAYyDK/gImACuLE+LaCJDcZi+yrJQZlBQ== X-Received: by 2002:a05:6402:3896:b0:45c:93c3:3569 with SMTP id fd22-20020a056402389600b0045c93c33569mr26507912edb.37.1667933374572; Tue, 08 Nov 2022 10:49:34 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id kz5-20020a17090777c500b0077b523d309asm4930540ejc.185.2022.11.08.10.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 10:49:34 -0800 (PST) Message-ID: Date: Tue, 8 Nov 2022 19:49:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 3/3] ARM: dts: qcom-msm8960-cdp: align TLMM pin configuration with DT schema To: Krzysztof Kozlowski , Bjorn Andersson , Andy Gross , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221108184529.26857-1-krzysztof.kozlowski@linaro.org> <20221108184529.26857-3-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221108184529.26857-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 08/11/2022 19:45, Krzysztof Kozlowski wrote: > DT schema expects TLMM pin configuration nodes to be named with > '-state' suffix and their optional children with '-pins' suffix. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm/boot/dts/qcom-msm8960-cdp.dts | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts > index 3a484ac53917..9a3a510f88ca 100644 > --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts > +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts > @@ -60,33 +60,32 @@ &gsbi5_serial { > }; > > &msmgpio { > - spi1_default: spi1_default { > - mux { > - pins = "gpio6", "gpio7", "gpio9"; > - function = "gsbi1"; > - }; > - > - mosi { > + spi1_default: spi1-default-state { > + mosi-pins { > pins = "gpio6"; > + function = "gsbi1"; > drive-strength = <12>; > bias-disable; > }; > > - miso { > + miso-pins { > pins = "gpio7"; > + function = "gsbi1"; > drive-strength = <12>; > bias-disable; > }; > > - cs { > + cs-pins { > pins = "gpio8"; > + function = "gpio"; > drive-strength = <12>; > bias-disable; > output-low; > }; > > - clk { > + clk-pins { > pins = "gpio9"; > + function = "gsbi1"; > drive-strength = <12>; > bias-disable; > };