From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 189.cn (ptr.189.cn [183.61.185.101]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D6DD18A6D4; Fri, 13 Dec 2024 10:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=183.61.185.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734085531; cv=none; b=OINafjL5PEgP62ihwTrZNzsnNHKVuqW/iikIhC45fDtBYM5q2yhmSyGhm6eyyfkfWjN0fH2x1FBkEGPt4SB8firQHxK32LAbgZetcV+BGGSs7LS0c0Zx7U79f+OnqvxzXyzk7l1j5JURBcp5sQ6JChXKSzVqyHdcmAvSEQMNSbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734085531; c=relaxed/simple; bh=5s/jjuh8AVRCqrdEFxix5vhyI/mt2fAlSTzCpz97cGQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cZ8alTbn/0A6Zpv/bjLITFQsljPKSuvmCcbb6C3hPbUjTNzHcwxCkUiVtQDjwpLgSstnV5MagsBkILK7t0uWfK66C9QYZ2O+l0Eia4oEqkrQBpuDsLkJRNJLngmUXiotZmILwzFxKbB8C8D3ymEgIEwMjNQYLCg2KOM9zA90QDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=189.cn; spf=pass smtp.mailfrom=189.cn; arc=none smtp.client-ip=183.61.185.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=189.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=189.cn HMM_SOURCE_IP:10.158.243.220:44887.575670444 HMM_ATTACHE_NUM:0000 HMM_SOURCE_TYPE:SMTP Received: from clientip-123.150.8.42 (unknown [10.158.243.220]) by 189.cn (HERMES) with SMTP id 27A541002A1; Fri, 13 Dec 2024 18:25:19 +0800 (CST) Received: from ([123.150.8.42]) by gateway-153622-dep-5c5f88b874-f78lq with ESMTP id c343a56593534b629cd8b1f3e3536872 for brgl@bgdev.pl; Fri, 13 Dec 2024 18:25:20 CST X-Transaction-ID: c343a56593534b629cd8b1f3e3536872 X-Real-From: chensong_2000@189.cn X-Receive-IP: 123.150.8.42 X-MEDUSA-Status: 0 Sender: chensong_2000@189.cn Message-ID: Date: Fri, 13 Dec 2024 18:25:18 +0800 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] regulator:s5m8767: Fully convert to GPIO descriptors To: Bartosz Golaszewski Cc: krzk@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, lee@kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <20241211051019.176131-1-chensong_2000@189.cn> Content-Language: en-US From: Song Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Bart, 在 2024/12/12 18:29, Bartosz Golaszewski 写道: > On Thu, Dec 12, 2024 at 6:55 AM Song Chen wrote: >> >> Or we can use devm_gpiod_get_array, it's pretty much equivalent effect >> in s5m8767 even without fwnode specified. >> > > Can you use it though? I was thinking you need the fwnode variant > because it's the child (regulator) node of the device? > > If you can, that would be great. > > Bart > yes, i believe so, eventually both devm_gpiod_get_array and devm_fwnode_gpiod_get_index use of_fwnode_handle(iodev->dev->of_node) in this case. But, i think it's a good idea to introduce a helper to get gpio descriptor array with fwnode, i have made a patch, would appreciate it if you can help me have a look. Best regards, Song