From: Jonas Jelonek <jelonek.jonas@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Peter Rosin <peda@axentia.se>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Richard <thomas.richard@bootlin.com>
Subject: Re: [PATCH v4 2/2] gpio: add gpio-line-mux driver
Date: Wed, 5 Nov 2025 16:49:31 +0100 [thread overview]
Message-ID: <ebeada4e-d739-4a8f-8e5f-a8de0d4e885e@gmail.com> (raw)
In-Reply-To: <CAMRc=MdkkRnwxx3vcMB3duOteQNdC9eb+A1P4GActou=xY9yJQ@mail.gmail.com>
Hi,
On 05.11.25 16:37, Bartosz Golaszewski wrote:
> Ah, that's what you get for revieweing with a fever. :/
>
> You're right of course.
>
> And yes, we'd need to modify the bindings.
>
>> Or, are we talking about
>>
>> glm->shared_gpio = devm_gpiod_get(dev, "muxed", GPIOD_ASIS);
>>
>> and
>>
>> muxed-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
>>
>> ?
>>
> I would make it: glm->muxed_gpio = devm_gpiod_get(dev, "muxed", GPIOD_ASIS);
>
> Jonas, could you please send another version with that addressed both
> here and in the bindings?
Yes, I'll do.
> Bartosz
Best,
Jonas
next prev parent reply other threads:[~2025-11-05 15:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 10:36 [PATCH v4 0/2] add gpio-line-mux Jonas Jelonek
2025-11-05 10:36 ` [PATCH v4 1/2] dt-bindings: gpio: add gpio-line-mux controller Jonas Jelonek
2025-11-05 10:36 ` [PATCH v4 2/2] gpio: add gpio-line-mux driver Jonas Jelonek
2025-11-05 13:15 ` Bartosz Golaszewski
2025-11-05 13:23 ` Jonas Jelonek
2025-11-05 13:24 ` Bartosz Golaszewski
2025-11-05 14:19 ` Peter Rosin
2025-11-05 14:37 ` Jonas Jelonek
2025-11-05 15:37 ` Bartosz Golaszewski
2025-11-05 15:49 ` Jonas Jelonek [this message]
2025-11-05 13:28 ` Jonas Jelonek
2025-11-05 13:26 ` Thomas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebeada4e-d739-4a8f-8e5f-a8de0d4e885e@gmail.com \
--to=jelonek.jonas@gmail.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).