From mboxrd@z Thu Jan 1 00:00:00 1970 From: sathyanarayanan kuppuswamy Subject: Re: [PATCH v1 1/2] gpio: gpio-wcove: fix GPIO irq status mask Date: Thu, 20 Apr 2017 17:52:36 -0700 Message-ID: References: Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:1514 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S948299AbdDUAz7 (ORCPT ); Thu, 20 Apr 2017 20:55:59 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Andy Shevchenko Cc: Alexandre Courbot , Linus Walleij , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sathyanarayanan Kuppuswamy Natarajan Hi Andy, Thanks for the review. On 04/19/2017 01:41 PM, Andy Shevchenko wrote: > On Fri, Apr 14, 2017 at 8:29 PM, > wrote: >> From: Kuppuswamy Sathyanarayanan >> >> According to Whiskey cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to > cove -> Cove Will fix it in next version. > >> battery IO. So we should skip this bit when checking for GPIO irq pending > irq -> IRQ Ditto. > >> status. Otherwise, wcove_gpio_irq_handler() might go into the infinite >> loop until irq "pending" status becomes 0. This patch fixes this issue. > Ditto. > >> +#define GPIO_IRQ0_MASK 0x7f >> +#define GPIO_IRQ1_MASK 0x3f > GENMASK() Ditto. > >> - pending = p[0] | (p[1] << 8); >> + pending = (p[0] & GPIO_IRQ0_MASK) | >> + ((p[1] & GPIO_IRQ1_MASK) << 7); > I would leave this on one line despite 80 characters limit (actually > how long is it?). It comes to 84 characters. Should I leave it as it is ? > -- Sathyanarayanan Kuppuswamy Android kernel developer