linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hawa, Hanna" <hhhawa@amazon.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: <andy.shevchenko@gmail.com>, <tony@atomide.com>,
	<haojian.zhuang@linaro.org>, <linus.walleij@linaro.org>,
	<dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
	<talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
	<tgershi@amazon.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show()
Date: Wed, 24 Mar 2021 16:03:41 +0200	[thread overview]
Message-ID: <ecaae08b-a8b7-ad36-1f71-af08c0cc6a88@amazon.com> (raw)
In-Reply-To: <20210322055631.GB392062@x1>



On 3/22/2021 7:56 AM, Drew Fustini wrote:
> I'm curious what SoC are you using?

I'm working on Amazon Annapurna Labs SoCs (based on ARM cortex 
processors). That include multiple pins controlled with same register.

> 
> It's good to know who has hardware to test bits_per_mux in the future.
> 
> I pay attention to pinctrl-single as that is the driver used for the TI
> AM3358 SoC used in a variety of BeagleBone boards.  It does not use
> bits_per_mux, but I can verify that this does not cause any regression
> for the AM3358 SoC:
> 
>    /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single# cat pins
>    registered pins: 142
>    pin 0 (PIN0) 0:? 44e10800 00000027 pinctrl-single
>    pin 1 (PIN1) 0:? 44e10804 00000027 pinctrl-single
>    pin 2 (PIN2) 0:? 44e10808 00000027 pinctrl-single
>    pin 3 (PIN3) 0:? 44e1080c 00000027 pinctrl-single
>    pin 4 (PIN4) 0:? 44e10810 00000027 pinctrl-single
>    pin 5 (PIN5) 0:? 44e10814 00000027 pinctrl-single
>    pin 6 (PIN6) 0:? 44e10818 00000027 pinctrl-single
>    pin 7 (PIN7) 0:? 44e1081c 00000027 pinctrl-single
>    pin 8 (PIN8) 22:gpio-96-127 44e10820 00000027 pinctrl-single
>    pin 9 (PIN9) 23:gpio-96-127 44e10824 00000037 pinctrl-single
>    pin 10 (PIN10) 26:gpio-96-127 44e10828 00000037 pinctrl-single
>    pin 11 (PIN11) 27:gpio-96-127 44e1082c 00000037 pinctrl-single
>    pin 12 (PIN12) 0:? 44e10830 00000037 pinctrl-single
>    <snip>
>    pin 140 (PIN140) 0:? 44e10a30 00000028 pinctrl-single
>    pin 141 (PIN141) 13:gpio-64-95 44e10a34 00000020 pinctrl-single
> 
> Reviewed-by: Drew Fustini<drew@beagleboard.org>

Thanks for review and verify the change.

Thanks,
Hanna

> 
> Thanks,
> Drew

  reply	other threads:[~2021-03-24 14:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 15:21 [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show() Hanna Hawa
2021-03-19 15:21 ` [PATCH v4 1/3] pinctrl: pinctrl-single: remove unused variable Hanna Hawa
2021-03-24 12:16   ` Tony Lindgren
2021-03-19 15:21 ` [PATCH v4 2/3] pinctrl: pinctrl-single: remove unused parameter Hanna Hawa
2021-03-24 12:16   ` Tony Lindgren
2021-03-19 15:21 ` [PATCH v4 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is not zero Hanna Hawa
2021-03-24 12:17   ` Tony Lindgren
2021-03-22  5:56 ` [PATCH v4 0/3] Fix pinctrl-single pcs_pin_dbg_show() Drew Fustini
2021-03-24 14:03   ` Hawa, Hanna [this message]
2021-03-25  8:07 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecaae08b-a8b7-ad36-1f71-af08c0cc6a88@amazon.com \
    --to=hhhawa@amazon.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=benh@amazon.com \
    --cc=drew@beagleboard.org \
    --cc=dwmw@amazon.co.uk \
    --cc=hanochu@amazon.com \
    --cc=haojian.zhuang@linaro.org \
    --cc=jonnyc@amazon.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=ronenk@amazon.com \
    --cc=talel@amazon.com \
    --cc=tgershi@amazon.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).