* [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname
@ 2025-04-03 7:50 shao.mingyin
2025-04-03 11:43 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: shao.mingyin @ 2025-04-03 7:50 UTC (permalink / raw)
To: andersson
Cc: linus.walleij, linux-arm-msm, linux-gpio, linux-kernel,
yang.yang29, xu.xin16, ye.xingchen, xie.ludan
From: Xie Ludan <xie.ludan@zte.com.cn>
Introduce devm_platform_ioremap_resource_byname() to simplify
resource retrieval and mapping.This new function consolidates
platform_get_resource_byname() and devm_ioremap_resource() into a single
call, improving code readability and reducing API call overhead.
Signed-off-by: Xie Ludan <xie.ludan@zte.com.cn>
Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 13cdd6c0fbd7..264ac0e7152d 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -1548,7 +1548,7 @@ int msm_pinctrl_probe(struct platform_device *pdev,
if (soc_data->tiles) {
for (i = 0; i < soc_data->ntiles; i++) {
- pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev,
+ pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev,
soc_data->tiles[i]);
if (IS_ERR(pctrl->regs[i]))
return PTR_ERR(pctrl->regs[i]);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname
2025-04-03 7:50 [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname shao.mingyin
@ 2025-04-03 11:43 ` Dmitry Baryshkov
2025-04-04 6:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-04-03 11:43 UTC (permalink / raw)
To: shao.mingyin
Cc: andersson, linus.walleij, linux-arm-msm, linux-gpio, linux-kernel,
yang.yang29, xu.xin16, ye.xingchen, xie.ludan
On Thu, Apr 03, 2025 at 03:50:14PM +0800, shao.mingyin@zte.com.cn wrote:
> From: Xie Ludan <xie.ludan@zte.com.cn>
>
> Introduce devm_platform_ioremap_resource_byname() to simplify
> resource retrieval and mapping.This new function consolidates
> platform_get_resource_byname() and devm_ioremap_resource() into a single
> call, improving code readability and reducing API call overhead.
Commit message is incorrect. You are not introducing anything, you are
removing a whitespace.
>
> Signed-off-by: Xie Ludan <xie.ludan@zte.com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 13cdd6c0fbd7..264ac0e7152d 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -1548,7 +1548,7 @@ int msm_pinctrl_probe(struct platform_device *pdev,
>
> if (soc_data->tiles) {
> for (i = 0; i < soc_data->ntiles; i++) {
> - pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev,
> + pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev,
> soc_data->tiles[i]);
> if (IS_ERR(pctrl->regs[i]))
> return PTR_ERR(pctrl->regs[i]);
> --
> 2.25.1
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname
2025-04-03 11:43 ` Dmitry Baryshkov
@ 2025-04-04 6:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-04 6:06 UTC (permalink / raw)
To: Dmitry Baryshkov, shao.mingyin
Cc: andersson, linus.walleij, linux-arm-msm, linux-gpio, linux-kernel,
yang.yang29, xu.xin16, ye.xingchen, xie.ludan
On 03/04/2025 13:43, Dmitry Baryshkov wrote:
> On Thu, Apr 03, 2025 at 03:50:14PM +0800, shao.mingyin@zte.com.cn wrote:
>> From: Xie Ludan <xie.ludan@zte.com.cn>
>>
>> Introduce devm_platform_ioremap_resource_byname() to simplify
>> resource retrieval and mapping.This new function consolidates
>> platform_get_resource_byname() and devm_ioremap_resource() into a single
>> call, improving code readability and reducing API call overhead.
>
> Commit message is incorrect. You are not introducing anything, you are
> removing a whitespace.
>
This is another example of automated zte patches which sometimes are
note tested or make no sense. They still keep generating them via
automation and sending without actual review.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-04 6:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-03 7:50 [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname shao.mingyin
2025-04-03 11:43 ` Dmitry Baryshkov
2025-04-04 6:06 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).