* [PATCH] pinctrl: sprd: Fix the kconfig warning
@ 2020-03-03 3:32 Baolin Wang
2020-03-03 4:45 ` Randy Dunlap
2020-03-03 12:46 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Baolin Wang @ 2020-03-03 3:32 UTC (permalink / raw)
To: linus.walleij
Cc: rdunlap, orsonzhai, zhang.lyra, baolin.wang7, linux-gpio,
linux-kernel
On X86 plaform, if the CONFIG_OF is not selected, and set the
CONFIG_SPRD_SC9860 as 'm', that will cause below waring:
WARNING: unmet direct dependencies detected for PINCTRL_SPRD
Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
Selected by [m]:
- PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
Thus move the configuration dependency under CONFIG_PINCTRL_SPRD_SC9860
to fix the warning.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
---
drivers/pinctrl/sprd/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
index c9e7f0b..eef35d0 100644
--- a/drivers/pinctrl/sprd/Kconfig
+++ b/drivers/pinctrl/sprd/Kconfig
@@ -4,9 +4,7 @@
#
config PINCTRL_SPRD
- tristate "Spreadtrum pinctrl driver"
- depends on OF
- depends on ARCH_SPRD || COMPILE_TEST
+ tristate
select PINMUX
select PINCONF
select GENERIC_PINCONF
@@ -16,6 +14,8 @@ config PINCTRL_SPRD
config PINCTRL_SPRD_SC9860
tristate "Spreadtrum SC9860 pinctrl driver"
+ depends on OF
+ depends on ARCH_SPRD || COMPILE_TEST
select PINCTRL_SPRD
help
Say Y here to enable Spreadtrum SC9860 pinctrl driver
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: sprd: Fix the kconfig warning
2020-03-03 3:32 [PATCH] pinctrl: sprd: Fix the kconfig warning Baolin Wang
@ 2020-03-03 4:45 ` Randy Dunlap
2020-03-03 5:02 ` Baolin Wang
2020-03-03 12:46 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-03-03 4:45 UTC (permalink / raw)
To: Baolin Wang, linus.walleij
Cc: orsonzhai, zhang.lyra, linux-gpio, linux-kernel
On 3/2/20 7:32 PM, Baolin Wang wrote:
> On X86 plaform, if the CONFIG_OF is not selected, and set the
> CONFIG_SPRD_SC9860 as 'm', that will cause below waring:
>
> WARNING: unmet direct dependencies detected for PINCTRL_SPRD
> Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
> Selected by [m]:
> - PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
>
> Thus move the configuration dependency under CONFIG_PINCTRL_SPRD_SC9860
> to fix the warning.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> drivers/pinctrl/sprd/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/Kconfig b/drivers/pinctrl/sprd/Kconfig
> index c9e7f0b..eef35d0 100644
> --- a/drivers/pinctrl/sprd/Kconfig
> +++ b/drivers/pinctrl/sprd/Kconfig
> @@ -4,9 +4,7 @@
> #
>
> config PINCTRL_SPRD
> - tristate "Spreadtrum pinctrl driver"
> - depends on OF
> - depends on ARCH_SPRD || COMPILE_TEST
> + tristate
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> @@ -16,6 +14,8 @@ config PINCTRL_SPRD
>
> config PINCTRL_SPRD_SC9860
> tristate "Spreadtrum SC9860 pinctrl driver"
> + depends on OF
> + depends on ARCH_SPRD || COMPILE_TEST
> select PINCTRL_SPRD
> help
> Say Y here to enable Spreadtrum SC9860 pinctrl driver
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: sprd: Fix the kconfig warning
2020-03-03 4:45 ` Randy Dunlap
@ 2020-03-03 5:02 ` Baolin Wang
0 siblings, 0 replies; 4+ messages in thread
From: Baolin Wang @ 2020-03-03 5:02 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linus Walleij, Orson Zhai, Chunyan Zhang, linux-gpio, LKML
On Tue, Mar 3, 2020 at 12:45 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 3/2/20 7:32 PM, Baolin Wang wrote:
> > On X86 plaform, if the CONFIG_OF is not selected, and set the
> > CONFIG_SPRD_SC9860 as 'm', that will cause below waring:
> >
> > WARNING: unmet direct dependencies detected for PINCTRL_SPRD
> > Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
> > Selected by [m]:
> > - PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
> >
> > Thus move the configuration dependency under CONFIG_PINCTRL_SPRD_SC9860
> > to fix the warning.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
>
> Works for me. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks for your reporting and testing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: sprd: Fix the kconfig warning
2020-03-03 3:32 [PATCH] pinctrl: sprd: Fix the kconfig warning Baolin Wang
2020-03-03 4:45 ` Randy Dunlap
@ 2020-03-03 12:46 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-03-03 12:46 UTC (permalink / raw)
To: Baolin Wang
Cc: Randy Dunlap, Orson Zhai, Lyra Zhang, open list:GPIO SUBSYSTEM,
linux-kernel@vger.kernel.org
On Tue, Mar 3, 2020 at 4:32 AM Baolin Wang <baolin.wang7@gmail.com> wrote:
> On X86 plaform, if the CONFIG_OF is not selected, and set the
> CONFIG_SPRD_SC9860 as 'm', that will cause below waring:
>
> WARNING: unmet direct dependencies detected for PINCTRL_SPRD
> Depends on [n]: PINCTRL [=y] && OF [=n] && (ARCH_SPRD || COMPILE_TEST [=y])
> Selected by [m]:
> - PINCTRL_SPRD_SC9860 [=m] && PINCTRL [=y]
>
> Thus move the configuration dependency under CONFIG_PINCTRL_SPRD_SC9860
> to fix the warning.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Oh there is a fix.
Patch applied, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-03 12:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-03 3:32 [PATCH] pinctrl: sprd: Fix the kconfig warning Baolin Wang
2020-03-03 4:45 ` Randy Dunlap
2020-03-03 5:02 ` Baolin Wang
2020-03-03 12:46 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).