From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sasha Levin" <sashal@kernel.org>,
patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Mark Brown" <broonie@kernel.org>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-arm-kernel@lists.infradead.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 6.17-5.4] ASoC: pxa: add GPIOLIB_LEGACY dependency
Date: Mon, 27 Oct 2025 10:23:35 +0100 [thread overview]
Message-ID: <eeb6d1ab-e8ec-48dd-b8f0-0de3eaf545a6@app.fastmail.com> (raw)
In-Reply-To: <20251025160905.3857885-71-sashal@kernel.org>
On Sat, Oct 25, 2025, at 17:55, Sasha Levin wrote:
>
> LLM Generated explanations, may be completely bogus:
>
> YES
It is indeed bogus.
> Rationale
> - Fixes a real build failure during COMPILE_TEST when legacy GPIO APIs
> are disabled. The failure stems from `gpio_request_one()` in the PXA
> AC97 support code: `sound/arm/pxa2xx-ac97-lib.c:374` uses legacy GPIO
> (gpio_request_one/`GPIOF_OUT_INIT_HIGH`). When `GPIOLIB_LEGACY` is not
> enabled, these legacy interfaces are not available, leading to the
> implicit declaration error cited in the commit message.
The build error would only happen after we make GPIOLIB_LEGACY optional,
but in 6.17 it is still always-enabled.
>
> Notes on applicability
> - This backport is most relevant to stable series that already have the
> `GPIOLIB_LEGACY` split. Older stable trees that predate
> `GPIOLIB_LEGACY` either won’t need this change (no build break) or may
> require adjusting the dependency accordingly.
On older kernels, this would actively break configurations that need
the symbols.
Arnd
next prev parent reply other threads:[~2025-10-27 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251025160905.3857885-1-sashal@kernel.org>
2025-10-25 15:55 ` [PATCH AUTOSEL 6.17-5.4] ASoC: pxa: add GPIOLIB_LEGACY dependency Sasha Levin
2025-10-27 9:23 ` Arnd Bergmann [this message]
2025-11-04 13:48 ` Sasha Levin
2025-10-25 15:55 ` [PATCH AUTOSEL 6.17-5.15] media: em28xx: add special case for legacy gpiolib interface Sasha Levin
2025-10-27 9:24 ` Arnd Bergmann
2025-11-04 13:55 ` Sasha Levin
2025-10-25 15:57 ` [PATCH AUTOSEL 6.17] ASoC: codecs: wsa883x: Handle shared reset GPIO for WSA883x speakers Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb6d1ab-e8ec-48dd-b8f0-0de3eaf545a6@app.fastmail.com \
--to=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=robert.jarzmik@free.fr \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).