From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>,
Chen Wang <unicorn_wang@outlook.com>
Cc: Yixun Lan <dlan@gentoo.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor@kernel.org>,
devicetree@vger.kernel.org,
Meng Zhang <zhangmeng.kevin@spacemit.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jesse Taube <jesse@rivosinc.com>, Yangyu Chen <cyy@cyyself.name>,
Inochi Amaoto <inochiama@outlook.com>,
Jisheng Zhang <jszhang@kernel.org>,
Meng Zhang <kevin.z.m@hotmail.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 1/4] dt-bindings: pinctrl: spacemit: add support for K1 SoC
Date: Mon, 2 Sep 2024 10:03:31 +0200 [thread overview]
Message-ID: <eff3f5c5-3a25-498e-80da-ad8e039f7575@kernel.org> (raw)
In-Reply-To: <20240830-tidy-identify-90dce7a21abc@wendy>
On 30/08/2024 09:06, Conor Dooley wrote:
> On Fri, Aug 30, 2024 at 07:48:17AM +0800, Chen Wang wrote:
>>
>> On 2024/8/28 19:30, Yixun Lan wrote:
>>> Add dt-bindings for the pinctrl driver of SpacemiT's K1 SoC.
>>>
>>> Signed-off-by: Yixun Lan <dlan@gentoo.org>
>>> ---
>>> Changes in v3:
>>> - drop spacemit,slew-rate-{enable,disable} property
>>> - use drive-strength instead of drive-strength-microamp
>>> - fold strong-pull-up into bias-pull-up
>>> - format fixed
>>> - title fixed
>>
>> Drop this change history here, you can add this in the cover letter.
>>
>> [......]
>
> It's perfectly fine to provide per-patch changelogs fyi, rather than in
> the cover letter.
>
And honestly, since some time I prefer it much more. Much, much easier
to spot which patch changed instead of something in cover letter like:
1. Patch #1: changed foo
2. Patch #3: dropped
3. Patch #4 (so patch #5 or #4?): changed bar
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-02 8:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 11:30 [PATCH v3 0/4] riscv: spacemit: add pinctrl support to K1 SoC Yixun Lan
2024-08-28 11:30 ` [PATCH v3 1/4] dt-bindings: pinctrl: spacemit: add support for " Yixun Lan
2024-08-29 18:36 ` Rob Herring (Arm)
2024-08-29 23:48 ` Chen Wang
2024-08-30 7:06 ` Conor Dooley
2024-09-02 8:03 ` Krzysztof Kozlowski [this message]
2024-08-28 11:30 ` [PATCH v3 2/4] pinctrl: spacemit: add support for SpacemiT " Yixun Lan
2024-08-30 1:46 ` Inochi Amaoto
2024-08-30 8:09 ` Yixun Lan
2024-09-02 7:57 ` Linus Walleij
2024-09-02 15:47 ` Yixun Lan
2024-08-28 11:30 ` [PATCH v3 3/4] riscv: dts: spacemit: add pinctrl support for " Yixun Lan
2024-08-30 1:36 ` Inochi Amaoto
2024-08-30 7:56 ` Yixun Lan
2024-08-30 8:47 ` Inochi Amaoto
2024-08-28 11:30 ` [PATCH v3 4/4] riscv: dts: spacemit: add pinctrl property to uart0 in BPI-F3 Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff3f5c5-3a25-498e-80da-ad8e039f7575@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=cyy@cyyself.name \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=jesse@rivosinc.com \
--cc=jszhang@kernel.org \
--cc=kevin.z.m@hotmail.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
--cc=zhangmeng.kevin@spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).