From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F96C433EF for ; Wed, 11 May 2022 16:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344340AbiEKQIv (ORCPT ); Wed, 11 May 2022 12:08:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243315AbiEKQIu (ORCPT ); Wed, 11 May 2022 12:08:50 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7A68120D259 for ; Wed, 11 May 2022 09:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652285327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0TAjuarkhLQxoAHeLGfylbueNIUv/uakgBC3ZhGbIR8=; b=DJgqCw0CieDzc9XywtWhZC+5EuXp1NEWgY4kkMub06MK/wwRf2/q1RWPfUS7UdwrkJPGPE FRoGcqLFVbwhn7dzlAVorQnmumRS3JFt6Y9gBabMeAX6miAV5/R97EFH5K2f3smxcbhX7i RdInRZLFVTbMvc0Sf1hmBZ/B5ABVI0s= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-C9dnrGDwPNqrTdownm3rbg-1; Wed, 11 May 2022 12:08:46 -0400 X-MC-Unique: C9dnrGDwPNqrTdownm3rbg-1 Received: by mail-ed1-f70.google.com with SMTP id r30-20020a50d69e000000b00425e1e97671so1597063edi.18 for ; Wed, 11 May 2022 09:08:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0TAjuarkhLQxoAHeLGfylbueNIUv/uakgBC3ZhGbIR8=; b=1SuDskOgEjYqZz5dsUz21fJy2ktDZE7x2YmPcXXCSZfm08ogCit7b4D7wEw+glS3Jq 5vaHT0Iki/kZ7vAg30FGYqOeF1nDyPWh0OkXRwtqCCmlg0qjICaZjMRkT3gKS+xuc8NG D+UdNFRO+b6UKYviurkzoQMKUzL+dzG11vSDxDSnsSgDScyvU1jrj1MnUbdm2POyahNL +knwHk7sn23lP5bNxslHwwYfTkyD71og+97Z7YM2AkmfNwZH/jQy/Igy8j9Rx35OTinK Ixdb3t43oWoaMwlw2uN72Q7ugtIHmFLuiPiDWxCvokK2u2nuSFRYF2Ic8tm3iGqZJwZB GSlg== X-Gm-Message-State: AOAM531Ob3D20Q80vDwBH440tfdETqtdWyVps1xtyzdHtc9gVlbnDU4f AvEqSf4wheFqsj2o7JAKUaYdgKilj7dOvHFC9fT8r3PBRUOoQ17TwWqnOW11OBceeHWhpxaV9Xo uhwvZtXUvlno9Z4t9dLLHjg== X-Received: by 2002:a17:907:70c4:b0:6f3:d23f:d711 with SMTP id yk4-20020a17090770c400b006f3d23fd711mr24653685ejb.205.1652285325206; Wed, 11 May 2022 09:08:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmTsJIO4z+aRs4UiV4aYVuseJVmDaOGsHevOquQ3R7A40zTHs5eGgHEtcyWYgi3gqrT2wi6A== X-Received: by 2002:a17:907:70c4:b0:6f3:d23f:d711 with SMTP id yk4-20020a17090770c400b006f3d23fd711mr24653656ejb.205.1652285324948; Wed, 11 May 2022 09:08:44 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id cn16-20020a0564020cb000b0042617ba63bfsm1339395edb.73.2022.05.11.09.08.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 09:08:44 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 18:08:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v5 0/8] platform/x86: introduce p2sb_bar() helper Content-Language: en-US To: Andy Shevchenko , Tony Luck , Wolfram Sang , Jean Delvare , Heiner Kallweit , Lee Jones , =?UTF-8?Q?=c5=81ukasz_Bartosik?= , Linus Walleij , Jonathan Yong , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Borislav Petkov , Mauro Carvalho Chehab , James Morse , Robert Richter , Jean Delvare , Peter Tyser , Mika Westerberg , Andy Shevchenko , Mark Gross References: <20220510151451.85561-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede In-Reply-To: <20220510151451.85561-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi All, On 5/10/22 17:14, Andy Shevchenko wrote: > There are a few users and at least one more is coming (*1) that would > like to utilize P2SB mechanism of hiding and unhiding a device from > the PCI configuration space. > > Here is the series to consolidate p2sb handling code for existing users > and provide a generic way for new comer(s). > > It also includes a patch to enable GPIO controllers on Apollo Lake > when it's used with ABL bootloader w/o ACPI support (*2). > > The patch that brings the helper ("platform/x86/intel: Add Primary to > Sideband (P2SB) bridge support") has a commit message that sheds a light > on what the P2SB is and why this is needed. > > The changes made in v5 do not change the main idea and the functionality > in a big scale. What we need is probably one more retest done by Henning > (*3). I hope to have it merged to v5.19-rc1 that Siemens can develop > their changes based on this series (*4). > > I have tested this on Apollo Lake platform (I'm able to see SPI NOR and > since we have an ACPI device for GPIO I do not see any attempts to recreate > one). > > *1) One in this series, and one is a recent merge of the Simatic IPC drivers > *2) This patch can be postponed as Lee hasn't given his tag yet. > *3) Henning gave his tag and I dared to used it even against changed patch 1 > *4) The changes were posted in between of v4 and v5 of this series, but need > more work. > > Taking into account the *2) the series is ready to be merged via PDx86 tree. I must admit I have lost track of all the Ack-s / Reviewed-by-s a bit. So from the above I take it that the Ack-s resp. Reviewed-by-s on the other non drivers/platform/x86 bits also signal an Ack to merge the entire series through the pdx86 tree? Lee, any chance you can take a look at patches 3-5 and give your Ack for merging these through the pdx86 tree together with the rest? Regards, Hans p.s. Since this is mostly a cleanup series and since we are getting close to the next merge-window I believe that it likely is best to merge this after 5.19-rc1 has been released. I can then also provide an immutable branch for other maintainers early on in the 5.19 cycle which should help to avoid merge conflicts. > > Changes in v5: > - rewritten patch 1 to use pci_scan_single_device() (Lukas, Bjorn) > - rebased patch 2 on top of the new Intel SPI NOR codebase > - fixed a potential bug and rewritten resource filling in patch 5 (Lee) > - added many different tags in a few patches (Jean, Wolfram, Henning) > > Changes in v4: > - added tag to the entire series (Hans) > - added tag to pin control patch (Mika) > - dropped PCI core changes (PCI core doesn't want modifications to be made) > - as a consequence of the above merged necessary bits into p2sb.c > - added a check that p2sb is really hidden (Hans) > - added EDAC patches (reviewed by maintainer internally) > > Changes in v3: > - resent with cover letter > > Changes in v2: > - added parentheses around bus in macros (Joe) > - added tag (Jean) > - fixed indentation and wrapping in the header (Christoph) > - moved out of PCI realm to PDx86 as the best common denominator (Bjorn) > - added a verbose commit message to explain P2SB thingy (Bjorn) > - converted first parameter from pci_dev to pci_bus > - made first two parameters (bus and devfn) optional (Henning, Lee) > - added Intel pin control patch to the series (Henning, Mika) > - fixed English style in the commit message of one of MFD patch (Lee) > - added tags to my MFD LPC ICH patches (Lee) > - used consistently (c) (Lee) > - made indexing for MFD cell and resource arrays (Lee) > - fixed the resource size in i801 (Jean) > > Andy Shevchenko (6): > pinctrl: intel: Check against matching data instead of ACPI companion > mfd: lpc_ich: Factor out lpc_ich_enable_spi_write() > mfd: lpc_ich: Switch to generic p2sb_bar() > i2c: i801: convert to use common P2SB accessor > EDAC, pnd2: Use proper I/O accessors and address space annotation > EDAC, pnd2: convert to use common P2SB accessor > > Jonathan Yong (1): > platform/x86/intel: Add Primary to Sideband (P2SB) bridge support > > Tan Jui Nee (1): > mfd: lpc_ich: Add support for pinctrl in non-ACPI system > > drivers/edac/Kconfig | 1 + > drivers/edac/pnd2_edac.c | 62 +++------- > drivers/i2c/busses/Kconfig | 1 + > drivers/i2c/busses/i2c-i801.c | 39 ++---- > drivers/mfd/Kconfig | 1 + > drivers/mfd/lpc_ich.c | 161 +++++++++++++++++++------ > drivers/pinctrl/intel/pinctrl-intel.c | 14 +-- > drivers/platform/x86/intel/Kconfig | 12 ++ > drivers/platform/x86/intel/Makefile | 2 + > drivers/platform/x86/intel/p2sb.c | 133 ++++++++++++++++++++ > include/linux/platform_data/x86/p2sb.h | 28 +++++ > 11 files changed, 338 insertions(+), 116 deletions(-) > create mode 100644 drivers/platform/x86/intel/p2sb.c > create mode 100644 include/linux/platform_data/x86/p2sb.h > > > base-commit: 3bf222d317a20170ee17f082626c1e0f83537e13