From: "Arnd Bergmann" <arnd@arndb.de>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"kernel test robot" <lkp@intel.com>,
"Peng Fan" <peng.fan@nxp.com>,
"Koichiro Den" <koichiro.den@canonical.com>,
"Lee Jones" <lee@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"André Draszik" <andre.draszik@linaro.org>,
"Niko Pasaloukos" <nikolaos.pasaloukos@blaize.com>,
"Thomas Richard" <thomas.richard@bootlin.com>,
"Yixun Lan" <dlan@gentoo.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: enable CONFIG_GPIOLIB_LEGACY even for !GPIOLIB
Date: Tue, 29 Jul 2025 13:57:45 +0200 [thread overview]
Message-ID: <f0a2a000-381e-40d8-a9ac-4d75dba332e9@app.fastmail.com> (raw)
In-Reply-To: <CAMuHMdU6Akz0GC2hooAxn=C2F0WjagPkzRKcH1SJiW0CBeUOaw@mail.gmail.com>
On Tue, Jul 29, 2025, at 12:47, Geert Uytterhoeven wrote:
>>
>> -if GPIOLIB
>> -
>> config GPIOLIB_LEGACY
>> def_bool y
>>
>> +if GPIOLIB
>> +
>> config GPIOLIB_FASTPATH_LIMIT
>> int "Maximum number of GPIOs for fast path"
>> range 32 512
>
> This won't work for everything.
> While I now get CONFIG_GPIOLIB_LEGACY=y in all m68k defconfigs, and
> simple inline functions like gpio_is_valid() are now available, more
> complex functions will still fail, as drivers/gpio/gpiolib-legacy.c
> is not built.
>
> drivers/Makefile:
>
> obj-$(CONFIG_GPIOLIB) += gpio/
>
Hi Geert,
Do you have an example config that shows this problem?
I've tried a couple of configurations on m68k now but are unable
to reproduce this, using 'defconfig' (without GPIOLIB) and
'm5475evb_defconfig' (with GPIOLIB).
The intention of this patch (in combination with the previous one)
was that the legacy interfaces would still behave exactly like
before, falling back to the stubs when GPIOLIB is disabled.
Arnd
next prev parent reply other threads:[~2025-07-29 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-26 21:10 [PATCH] gpiolib: enable CONFIG_GPIOLIB_LEGACY even for !GPIOLIB Arnd Bergmann
2025-07-27 8:27 ` Bartosz Golaszewski
2025-07-29 10:47 ` Geert Uytterhoeven
2025-07-29 11:57 ` Arnd Bergmann [this message]
2025-07-29 12:12 ` Geert Uytterhoeven
2025-07-29 14:11 ` Arnd Bergmann
2025-08-13 22:26 ` Rob Herring
2025-09-01 11:44 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0a2a000-381e-40d8-a9ac-4d75dba332e9@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexander.sverdlin@gmail.com \
--cc=andre.draszik@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=dlan@gentoo.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=koichiro.den@canonical.com \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nikolaos.pasaloukos@blaize.com \
--cc=peng.fan@nxp.com \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).