From: Stephen Boyd <sboyd@codeaurora.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>,
bjorn.andersson@linaro.org, linus.walleij@linaro.org,
robh+dt@kernel.org, andy.gross@linaro.org,
linux-arm-msm@vger.kernel.org
Cc: rnayak@codeaurora.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios
Date: Thu, 27 Jul 2017 14:00:15 -0700 [thread overview]
Message-ID: <f0ad95d2-f79e-c3d4-1ac6-48d5d6e21956@codeaurora.org> (raw)
In-Reply-To: <1501137036-20155-2-git-send-email-vivek.gautam@codeaurora.org>
On 07/26/2017 11:30 PM, Vivek Gautam wrote:
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> index d3879a4e8076..3b04ca63c31e 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> @@ -8,6 +8,23 @@
> reg = <0x2 SPMI_USID>;
> #address-cells = <1>;
> #size-cells = <0>;
> +
> + pmi8994_gpios: gpios@c000 {
> + compatible = "qcom,pmi8994-gpio";
Please also include the generic "qcom,spmi-gpio" compatible. We really
don't need to add the "qcom,pmi8994-gpio" one to the driver right now so
I would leave that out of the driver but leave it here in the dtsi file
of course.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-07-27 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 6:30 [PATCH 1/2] pinctrl: qcom: spmi-gpio: Add pmi8994 gpio support Vivek Gautam
2017-07-27 6:30 ` [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios Vivek Gautam
2017-07-27 21:00 ` Stephen Boyd [this message]
2017-07-28 6:01 ` Vivek Gautam
2017-07-27 21:02 ` [PATCH 1/2] pinctrl: qcom: spmi-gpio: Add pmi8994 gpio support Stephen Boyd
2017-08-03 20:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ad95d2-f79e-c3d4-1ac6-48d5d6e21956@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).