From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios Date: Thu, 27 Jul 2017 14:00:15 -0700 Message-ID: References: <1501137036-20155-1-git-send-email-vivek.gautam@codeaurora.org> <1501137036-20155-2-git-send-email-vivek.gautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:55374 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbdG0VAS (ORCPT ); Thu, 27 Jul 2017 17:00:18 -0400 In-Reply-To: <1501137036-20155-2-git-send-email-vivek.gautam@codeaurora.org> Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Vivek Gautam , bjorn.andersson@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, andy.gross@linaro.org, linux-arm-msm@vger.kernel.org Cc: rnayak@codeaurora.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 07/26/2017 11:30 PM, Vivek Gautam wrote: > Signed-off-by: Vivek Gautam > --- > arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > index d3879a4e8076..3b04ca63c31e 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > @@ -8,6 +8,23 @@ > reg = <0x2 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > + > + pmi8994_gpios: gpios@c000 { > + compatible = "qcom,pmi8994-gpio"; Please also include the generic "qcom,spmi-gpio" compatible. We really don't need to add the "qcom,pmi8994-gpio" one to the driver right now so I would leave that out of the driver but leave it here in the dtsi file of course. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project