* [PATCH] gpio: xilinx: remove excess kernel doc
@ 2023-12-15 9:09 Bartosz Golaszewski
2023-12-15 11:08 ` Michal Simek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-12-15 9:09 UTC (permalink / raw)
To: Shubhrajyoti Datta, Srinivas Neeli, Michal Simek, Andy Shevchenko,
Linus Walleij, Marc Zyngier
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Bartosz Golaszewski,
kernel test robot
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The irqchip field has been removed from struct xgpio_instance so remove
the doc as well.
Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-xilinx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 823198368250..7348df385198 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -52,7 +52,6 @@
* @dir: GPIO direction shadow register
* @gpio_lock: Lock used for synchronization
* @irq: IRQ used by GPIO device
- * @irqchip: IRQ chip
* @enable: GPIO IRQ enable/disable bitfield
* @rising_edge: GPIO IRQ rising edge enable/disable bitfield
* @falling_edge: GPIO IRQ falling edge enable/disable bitfield
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: xilinx: remove excess kernel doc
2023-12-15 9:09 [PATCH] gpio: xilinx: remove excess kernel doc Bartosz Golaszewski
@ 2023-12-15 11:08 ` Michal Simek
2023-12-15 17:09 ` Randy Dunlap
2023-12-18 8:57 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2023-12-15 11:08 UTC (permalink / raw)
To: Bartosz Golaszewski, Shubhrajyoti Datta, Srinivas Neeli,
Andy Shevchenko, Linus Walleij, Marc Zyngier
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Bartosz Golaszewski,
kernel test robot
On 12/15/23 10:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
>
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpio-xilinx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
> * @dir: GPIO direction shadow register
> * @gpio_lock: Lock used for synchronization
> * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
> * @enable: GPIO IRQ enable/disable bitfield
> * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
> * @falling_edge: GPIO IRQ falling edge enable/disable bitfield
Interesting because kernel-doc is not reporting any issue but issue is there.
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: xilinx: remove excess kernel doc
2023-12-15 9:09 [PATCH] gpio: xilinx: remove excess kernel doc Bartosz Golaszewski
2023-12-15 11:08 ` Michal Simek
@ 2023-12-15 17:09 ` Randy Dunlap
2023-12-18 8:57 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-12-15 17:09 UTC (permalink / raw)
To: Bartosz Golaszewski, Shubhrajyoti Datta, Srinivas Neeli,
Michal Simek, Andy Shevchenko, Linus Walleij, Marc Zyngier
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Bartosz Golaszewski,
kernel test robot
On 12/15/23 01:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
>
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/gpio/gpio-xilinx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
> * @dir: GPIO direction shadow register
> * @gpio_lock: Lock used for synchronization
> * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
> * @enable: GPIO IRQ enable/disable bitfield
> * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
> * @falling_edge: GPIO IRQ falling edge enable/disable bitfield
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: xilinx: remove excess kernel doc
2023-12-15 9:09 [PATCH] gpio: xilinx: remove excess kernel doc Bartosz Golaszewski
2023-12-15 11:08 ` Michal Simek
2023-12-15 17:09 ` Randy Dunlap
@ 2023-12-18 8:57 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-12-18 8:57 UTC (permalink / raw)
To: Shubhrajyoti Datta, Srinivas Neeli, Michal Simek, Andy Shevchenko,
Linus Walleij, Marc Zyngier
Cc: linux-gpio, linux-arm-kernel, linux-kernel, Bartosz Golaszewski,
kernel test robot
On Fri, Dec 15, 2023 at 10:09 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
>
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpio-xilinx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
> * @dir: GPIO direction shadow register
> * @gpio_lock: Lock used for synchronization
> * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
> * @enable: GPIO IRQ enable/disable bitfield
> * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
> * @falling_edge: GPIO IRQ falling edge enable/disable bitfield
> --
> 2.40.1
>
Patch applied.
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-18 8:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-15 9:09 [PATCH] gpio: xilinx: remove excess kernel doc Bartosz Golaszewski
2023-12-15 11:08 ` Michal Simek
2023-12-15 17:09 ` Randy Dunlap
2023-12-18 8:57 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).