From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BBFFC433FE for ; Tue, 15 Nov 2022 11:54:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229787AbiKOLyF (ORCPT ); Tue, 15 Nov 2022 06:54:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbiKOLyE (ORCPT ); Tue, 15 Nov 2022 06:54:04 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C71C913D65 for ; Tue, 15 Nov 2022 03:54:02 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id g7so24068356lfv.5 for ; Tue, 15 Nov 2022 03:54:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=01M9df8tHEyJsnDu3Von3eC66Ovw8+fdVMK/4EPvKL4=; b=lw04QckrbhSCNd9EHeNnNZtyF2InJ2jFPBT4yGMDCzayGNKo8xubNc2hm34mroaHxX fridHOemeNkwKAhfN0kcO8Qu3IbMO8trPOiqVXRVLU6kPv3B4ydLPnr8X1W9Pqk+rNKG fQXbE//yjDsvbl6xIOZncN33sErj7c6iafdd1FNpMhubil62TX1u1CItdGovO2DyHAZg J/HoI4Gg84ieh+Kxb3ouwggakpliJbZJaBMh25NI8eCknSNzEM0fOaevriEhy9I5pFiq 8JhhkY1yLPCSMlHhoPdfiwzUoE+jVC+3PVXG2eU78QIAYdg0917nl/hnFCGkXpkELEFl m00A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=01M9df8tHEyJsnDu3Von3eC66Ovw8+fdVMK/4EPvKL4=; b=Xzno87OAeyuof7nL/6GiKCB41yiu+jXclBJIWpoqEeK9xTHAJV2qUCObSnSVLvVJ6o M6bGpkQ0B9qh9J+mzysVq2S+NGN/1QVDVL0PiWgGVsXNQoH4/tSqmwY4WM/5TWar8bgD X81YPqyf/UcbBk+kgfbyROkz7mscNTA6EY3eaI6MSf52MDgDft+unybk5o62uD9S7mve N1nqR31JLN2VLgdR+9zpzDQxlGr6qny96S7fi/x+mveu5AX8J6NDEIfc+6i8upWhTEuU BCEPTPtSmqm788F6z4cVTjyM8VsLisA0BOhqYdqHMBIDeOz7sVbh/nqV2Jbfi8vIXFXC 7O9Q== X-Gm-Message-State: ANoB5plc93lT3ggxiw7qFeSZCrQ99FrMlU2r743rF2DJ91H8WUvZNGIG 5qeq2bm/F/IcbzXf9mvoUepHY6HL9FnIGPlI X-Google-Smtp-Source: AA0mqf4nVRlkN4WXp0Xq3TTm+K7JwtvEIeRQzNdksjvfhcJNcg2gAd2Ht4d73oXkbZ4mpOD227iRGw== X-Received: by 2002:a05:6512:400f:b0:4a2:b42a:6d7 with SMTP id br15-20020a056512400f00b004a2b42a06d7mr6071339lfb.649.1668513241192; Tue, 15 Nov 2022 03:54:01 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id c10-20020a056512324a00b0048af3c090f8sm2201764lfr.13.2022.11.15.03.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 03:54:00 -0800 (PST) Message-ID: Date: Tue, 15 Nov 2022 12:53:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH RFC] gpiolib: ensure that fwnode is properly set To: Brian Masney , linus.walleij@linaro.org, brgl@bgdev.pl Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, psodagud@quicinc.com, quic_shazhuss@quicinc.com, quic_ppareek@quicinc.com, ahalaney@redhat.com, echanude@redhat.com, nicolas.dechesne@linaro.org References: <20221114202943.2389489-1-bmasney@redhat.com> From: Konrad Dybcio In-Reply-To: <20221114202943.2389489-1-bmasney@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 14/11/2022 21:29, Brian Masney wrote: > Note that this is a RFC patch and not meant to be merged. I looked into > a problem with linux-next-20221110 on the Qualcomm SA8540P automotive > board (sc8280xp) where the UFS host controller would fail to probe due > to repeated probe deferrals when trying to get reset-gpios via > devm_gpiod_get_optional(). > > of_get_named_gpiod_flags() returns -EPROBE_DEFER, which is caused by > of_gpiochip_match_node_and_xlate() returning 0 since the of_xlate function > pointer is not set for the qcom,sc8280xp-tlmm pinctrl driver. The > pinctrl driver doesn't define one, so of_gpiochip_add() should > automatically setup of_gpio_simple_xlate() on it's behalf. This doesn't > happen since the fwnode member on the struct gpiochip is set to null > when of_gpiochip_add() is called. Let's work around this by ensuring > that it's set if available. > > Note that this broke sometime within the last few weeks within > linux-next and I haven't bisected this. I'm posting this in the hopes > that someone may know offhand which patch(es) may have broken this. > > Signed-off-by: Brian Masney > --- Fixes boot on 8450 on next-20221115 Tested-by: Konrad Dybcio Konrad > drivers/gpio/gpiolib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 11fb7ec883e9..8bec66008869 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -678,7 +678,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, > * Assign fwnode depending on the result of the previous calls, > * if none of them succeed, assign it to the parent's one. > */ > - gdev->dev.fwnode = dev_fwnode(&gdev->dev) ?: fwnode; > + gc->fwnode = gdev->dev.fwnode = dev_fwnode(&gdev->dev) ?: fwnode; > > gdev->id = ida_alloc(&gpio_ida, GFP_KERNEL); > if (gdev->id < 0) {