* [PATCH] gpio: aspeed: fix ast2600 bank properties
@ 2020-10-19 4:50 Billy Tsai
2020-10-19 5:33 ` Tao Ren
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Billy Tsai @ 2020-10-19 4:50 UTC (permalink / raw)
To: linus.walleij, rentao.bupt, bgolaszewski, joel, andrew,
linux-gpio, linux-arm-kernel, linux-aspeed
Cc: BMC-SW
GPIO_T is mapped to the most significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_T is input only. All
the other bits need to be 1 because GPIO_Q/R/S support both input and
output modes.
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
drivers/gpio/gpio-aspeed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index d07bf2c3f136..f24754b3f6d1 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
static const struct aspeed_bank_props ast2600_bank_props[] = {
/* input output */
+ {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */
{5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
{6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
{ },
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
2020-10-19 4:50 [PATCH] gpio: aspeed: fix ast2600 bank properties Billy Tsai
@ 2020-10-19 5:33 ` Tao Ren
2020-10-19 7:29 ` Joel Stanley
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Tao Ren @ 2020-10-19 5:33 UTC (permalink / raw)
To: Billy Tsai
Cc: linus.walleij, bgolaszewski, joel, andrew, linux-gpio,
linux-arm-kernel, linux-aspeed, BMC-SW
Hi Billy,
On Mon, Oct 19, 2020 at 12:50:26PM +0800, Billy Tsai wrote:
> GPIO_T is mapped to the most significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_T is input only. All
> the other bits need to be 1 because GPIO_Q/R/S support both input and
> output modes.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
You may want to add "Fixes" tag if you take it as a bug fix? For
example:
Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> ---
> drivers/gpio/gpio-aspeed.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index d07bf2c3f136..f24754b3f6d1 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
>
> static const struct aspeed_bank_props ast2600_bank_props[] = {
> /* input output */
> + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
> {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
> {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
> { },
> --
> 2.17.1
>
Cheers,
Tao
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
2020-10-19 4:50 [PATCH] gpio: aspeed: fix ast2600 bank properties Billy Tsai
2020-10-19 5:33 ` Tao Ren
@ 2020-10-19 7:29 ` Joel Stanley
2020-10-21 23:38 ` Andrew Jeffery
2020-10-26 14:53 ` Bartosz Golaszewski
3 siblings, 0 replies; 9+ messages in thread
From: Joel Stanley @ 2020-10-19 7:29 UTC (permalink / raw)
To: Billy Tsai
Cc: Linus Walleij, Tao Ren, Bartosz Golaszewski, Andrew Jeffery,
open list:GPIO SUBSYSTEM, Linux ARM, linux-aspeed, BMC-SW
Hi Billy,
On Mon, 19 Oct 2020 at 04:50, Billy Tsai <billy_tsai@aspeedtech.com> wrote:
>
> GPIO_T is mapped to the most significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_T is input only. All
> the other bits need to be 1 because GPIO_Q/R/S support both input and
> output modes.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
This is a very similar commit message to the one that Tao sent out, so
I thought for a moment that it was a duplicate patch. I can see now
that it's a different change.
Reviewed-by: Joel Stanley <joel@jms.id.au>
Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
Cheers,
Joel
> ---
> drivers/gpio/gpio-aspeed.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index d07bf2c3f136..f24754b3f6d1 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
>
> static const struct aspeed_bank_props ast2600_bank_props[] = {
> /* input output */
> + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */
> {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
> {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
> { },
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
2020-10-19 4:50 [PATCH] gpio: aspeed: fix ast2600 bank properties Billy Tsai
2020-10-19 5:33 ` Tao Ren
2020-10-19 7:29 ` Joel Stanley
@ 2020-10-21 23:38 ` Andrew Jeffery
2020-10-26 14:53 ` Bartosz Golaszewski
3 siblings, 0 replies; 9+ messages in thread
From: Andrew Jeffery @ 2020-10-21 23:38 UTC (permalink / raw)
To: Billy Tsai, Linus Walleij, Tao Ren, Bartosz Golaszewski,
Joel Stanley, linux-gpio, linux-arm-kernel, linux-aspeed
Cc: BMC-SW
On Mon, 19 Oct 2020, at 15:20, Billy Tsai wrote:
> GPIO_T is mapped to the most significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_T is input only. All
> the other bits need to be 1 because GPIO_Q/R/S support both input and
> output modes.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Good catch, thanks Billy.
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
2020-10-19 4:50 [PATCH] gpio: aspeed: fix ast2600 bank properties Billy Tsai
` (2 preceding siblings ...)
2020-10-21 23:38 ` Andrew Jeffery
@ 2020-10-26 14:53 ` Bartosz Golaszewski
3 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2020-10-26 14:53 UTC (permalink / raw)
To: Billy Tsai
Cc: Linus Walleij, rentao.bupt, Joel Stanley, Andrew Jeffery,
linux-gpio, arm-soc, linux-aspeed, BMC-SW
On Mon, Oct 19, 2020 at 6:50 AM Billy Tsai <billy_tsai@aspeedtech.com> wrote:
>
> GPIO_T is mapped to the most significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_T is input only. All
> the other bits need to be 1 because GPIO_Q/R/S support both input and
> output modes.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> drivers/gpio/gpio-aspeed.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index d07bf2c3f136..f24754b3f6d1 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config =
>
> static const struct aspeed_bank_props ast2600_bank_props[] = {
> /* input output */
> + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */
> {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
> {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
> { },
> --
> 2.17.1
>
Applied to fixes with reviews collected and added the Fixes: tag.
Bartosz
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] gpio: aspeed: fix ast2600 bank properties
@ 2020-09-16 20:42 rentao.bupt
2020-09-16 23:12 ` Andrew Jeffery
2020-09-24 13:37 ` Bartosz Golaszewski
0 siblings, 2 replies; 9+ messages in thread
From: rentao.bupt @ 2020-09-16 20:42 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Joel Stanley, Andrew Jeffery,
linux-gpio, linux-arm-kernel, linux-aspeed, linux-kernel, openbmc,
taoren
Cc: Tao Ren
From: Tao Ren <rentao.bupt@gmail.com>
GPIO_U is mapped to the least significant byte of input/output mask, and
the byte in "output" mask should be 0 because GPIO_U is input only. All
the other bits need to be 1 because GPIO_V/W/X support both input and
output modes.
Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
according bits need to be 1 because GPIO_Y/Z support both input and
output modes.
Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
---
drivers/gpio/gpio-aspeed.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 879db23d8454..d07bf2c3f136 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1114,8 +1114,8 @@ static const struct aspeed_gpio_config ast2500_config =
static const struct aspeed_bank_props ast2600_bank_props[] = {
/* input output */
- {5, 0xffffffff, 0x0000ffff}, /* U/V/W/X */
- {6, 0xffff0000, 0x0fff0000}, /* Y/Z */
+ {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
+ {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
{ },
};
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
2020-09-16 20:42 rentao.bupt
@ 2020-09-16 23:12 ` Andrew Jeffery
2020-09-18 4:18 ` Tao Ren
2020-09-24 13:37 ` Bartosz Golaszewski
1 sibling, 1 reply; 9+ messages in thread
From: Andrew Jeffery @ 2020-09-16 23:12 UTC (permalink / raw)
To: Tao Ren, Linus Walleij, Bartosz Golaszewski, Joel Stanley,
linux-gpio, linux-arm-kernel, linux-aspeed, linux-kernel, openbmc,
Tao Ren
On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote:
> From: Tao Ren <rentao.bupt@gmail.com>
>
> GPIO_U is mapped to the least significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_U is input only. All
> the other bits need to be 1 because GPIO_V/W/X support both input and
> output modes.
>
> Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> according bits need to be 1 because GPIO_Y/Z support both input and
> output modes.
>
> Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
Thanks Tao,
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
2020-09-16 23:12 ` Andrew Jeffery
@ 2020-09-18 4:18 ` Tao Ren
0 siblings, 0 replies; 9+ messages in thread
From: Tao Ren @ 2020-09-18 4:18 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Linus Walleij, Bartosz Golaszewski, Joel Stanley, linux-gpio,
linux-arm-kernel, linux-aspeed, linux-kernel, openbmc, Tao Ren
On Thu, Sep 17, 2020 at 08:42:27AM +0930, Andrew Jeffery wrote:
>
>
> On Thu, 17 Sep 2020, at 06:12, rentao.bupt@gmail.com wrote:
> > From: Tao Ren <rentao.bupt@gmail.com>
> >
> > GPIO_U is mapped to the least significant byte of input/output mask, and
> > the byte in "output" mask should be 0 because GPIO_U is input only. All
> > the other bits need to be 1 because GPIO_V/W/X support both input and
> > output modes.
> >
> > Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> > according bits need to be 1 because GPIO_Y/Z support both input and
> > output modes.
> >
> > Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> > Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
>
> Thanks Tao,
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Thanks Andrew for the quick review.
Cheers,
Tao
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: aspeed: fix ast2600 bank properties
2020-09-16 20:42 rentao.bupt
2020-09-16 23:12 ` Andrew Jeffery
@ 2020-09-24 13:37 ` Bartosz Golaszewski
1 sibling, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2020-09-24 13:37 UTC (permalink / raw)
To: rentao.bupt
Cc: Linus Walleij, Joel Stanley, Andrew Jeffery, linux-gpio, arm-soc,
linux-aspeed, LKML, openbmc, taoren
On Wed, Sep 16, 2020 at 10:42 PM <rentao.bupt@gmail.com> wrote:
>
> From: Tao Ren <rentao.bupt@gmail.com>
>
> GPIO_U is mapped to the least significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_U is input only. All
> the other bits need to be 1 because GPIO_V/W/X support both input and
> output modes.
>
> Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> according bits need to be 1 because GPIO_Y/Z support both input and
> output modes.
>
> Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
> ---
> drivers/gpio/gpio-aspeed.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index 879db23d8454..d07bf2c3f136 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -1114,8 +1114,8 @@ static const struct aspeed_gpio_config ast2500_config =
>
> static const struct aspeed_bank_props ast2600_bank_props[] = {
> /* input output */
> - {5, 0xffffffff, 0x0000ffff}, /* U/V/W/X */
> - {6, 0xffff0000, 0x0fff0000}, /* Y/Z */
> + {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */
> + {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */
> { },
> };
>
> --
> 2.17.1
>
Queued for fixes, thanks!
Bartosz
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-26 14:53 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-19 4:50 [PATCH] gpio: aspeed: fix ast2600 bank properties Billy Tsai
2020-10-19 5:33 ` Tao Ren
2020-10-19 7:29 ` Joel Stanley
2020-10-21 23:38 ` Andrew Jeffery
2020-10-26 14:53 ` Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2020-09-16 20:42 rentao.bupt
2020-09-16 23:12 ` Andrew Jeffery
2020-09-18 4:18 ` Tao Ren
2020-09-24 13:37 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).