From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA782C54E94 for ; Thu, 26 Jan 2023 14:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229446AbjAZOkJ (ORCPT ); Thu, 26 Jan 2023 09:40:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbjAZOkI (ORCPT ); Thu, 26 Jan 2023 09:40:08 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6357B26BB; Thu, 26 Jan 2023 06:40:07 -0800 (PST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 0E6763200A69; Thu, 26 Jan 2023 09:40:05 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 26 Jan 2023 09:40:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674744005; x=1674830405; bh=2y4ifRRBY2 zAJdRnpFIN5yh9VL5vAaJGv1a4q1ONRxY=; b=nmLi29PHmhe7Mt1UUCxqHDFwV8 Ydw/Al6jYtzGI9Fn5PDw67OEMYW/e54wH36cbLEcUsturGaSxLj0FizjrQ3bIwWh ENEolmTgll+nzxxv7pYkagVf4V0TXti7ixi57adlpY6tUQEI/nKTbQ/4LbM0u9vo mXp2Vlq2cT59FjaFUYykCUhycj85oKkl8efo9a/zJMrJCq/5i1qZer5DOG2679ma 4XtVDlYqonTPCKnuH6uw+2yueW/izFLHXBf7Voxgw/toR+Q6GVbvnVNWreRleCdi zh04G1RP6FZuN6DGdEcXRjP63wOLjcUZVMc5IZxJDHne4EZwlU597xY1hNBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674744005; x=1674830405; bh=2y4ifRRBY2zAJdRnpFIN5yh9VL5v AaJGv1a4q1ONRxY=; b=ZOh7Ea7S7GeZG9kQ6b/qG3acCa+eJqb97eVnHWk+RX1D my+5BC9JVi6PChQIcVRMrklJu3vLN9/pCqXhCMZeHloB1BqxjTSXJlrrD61RQx4U ILHi8l7rvuOYAB8iZ6lWaJLnixKEiQDb2PO7sIpACKeCZpRaaV0C3pi/XpIys+4D J6bgHWMIHvHRVkEUfzw684yeQQKW5nn+uv4gaM4DTV9rwmVLsxAZVGQLLnpBvhyw VSrlc86hHeGtH9svDv64u6BMu3KK2/bKDxuBamOvxBknt4UtX0XKCsjZSAoowFmV Qy3C2NAzylIKm76PJ99awpj2OohXBaohM0GDFlGq/w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvgedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E670AB60086; Thu, 26 Jan 2023 09:40:04 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0 Mime-Version: 1.0 Message-Id: In-Reply-To: <20230126151243.3acc1fe2@xps-13> References: <20230126135215.3387820-1-arnd@kernel.org> <20230126151243.3acc1fe2@xps-13> Date: Thu, 26 Jan 2023 15:39:45 +0100 From: "Arnd Bergmann" To: "Miquel Raynal" , "Arnd Bergmann" Cc: "Alexander Aring" , "Stefan Schmidt" , "open list:GPIO SUBSYSTEM" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Andy Shevchenko" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-wpan@vger.kernel.org, Netdev Subject: Re: [PATCH] at86rf230: convert to gpio descriptors Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Jan 26, 2023, at 15:12, Miquel Raynal wrote: >> @@ -1682,7 +1650,7 @@ MODULE_DEVICE_TABLE(spi, at86rf230_device_id); >> static struct spi_driver at86rf230_driver = { >> .id_table = at86rf230_device_id, >> .driver = { >> - .of_match_table = of_match_ptr(at86rf230_of_match), >> + .of_match_table = at86rf230_of_match, > > Looks like an unrelated change? Or is it a consequence of "not having > any in-tree users of platform_data" that plays a role here? I probably did it because I thought I had removed the matching #ifdef for at86rf230_of_match in the process of making the driver DT-only. Without this trivial change, building the driver as built-in with CONFIG_OF=n can result in a warning like drivers/net/ieee802154/at86rf230.c:1632:28: error: unused variable 'at86rf230_of_match' [-Werror,-Wunused-variable] It looks like this was already removed in a8b66db804f0 ("at86rf230: remove #ifdef CONFIG_OF"), which was not technically correct, but nobody noticed, including me. I could split this out as a separate patch, but it's probably not worth it. > Anyhow, the changes in the driver look good, so: > > Reviewed-by: Miquel Raynal Thanks, Arnd