From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37BB1A38DB for ; Sat, 23 Mar 2024 11:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711191737; cv=none; b=cirZ+/rMeIzAKigy7LvbJ4H+qg+8ipABYn7fRyOuq2MwhUQhw2pNK7hqFvInpxT7wPWcvH7WXxtpE9sV4BB6O4wwgUDY34jGBRax1K9+2IyANCL5gzl4PicJs0uBSwh20QfJJRE5bTGH7fRzjbJ6Hq/LsFn2968KaCHMeVYJg34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711191737; c=relaxed/simple; bh=1/lBuUFFu47E80gX2+9hmCehguCK5DlCp9iszbTL8W8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Mmqt6E3spcrQBuWP7WDL2RvcVkq+nOCAvr/Qdg018rn2JDeuUQwZTzf2/lbM+AUCMwMOu78SImNR5+lfoTexIXO4TpDFlJnssWiyZA+j63f8WEodVjZK6Lv0exaNyCywvbRR9x2vZRs7BxKSWoOllkV9zLWEvX/gw3XKGoGvMso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NUEeaANx; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NUEeaANx" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-56be4efb63fso1688950a12.1 for ; Sat, 23 Mar 2024 04:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711191734; x=1711796534; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dq9iZxQWSEhkDSaw4XzDPMOvLVbhwjj2yH4g9CSlP7k=; b=NUEeaANxSvY6cqP0HEgPY2MNARXFZ1lETLH0gDk9dJSubCH2vXFbTN1qZE1e0See84 O1Etmw0tR1SkUBBzaKsOFD1hvdnwfv39qw7i2gJTsSZ71VKZYpESrKSPq1werUWhUeRD X1zGwC5W8UubuqRWDfbX3FqZyLSTaS8SGTL/NS/SsdCfUWc10X8FH1qMEPEteHSxJIjr Hy1SkGy/zCLdDEtCeXns3L+u4Fo2aebofzyh0W9MT58ZOOHfsE0vTJ0cyWq/Kh4Siw2C zfPNdDxz+nIVq/gPaIUUuejDnVV+0Z0jed9rzYr0ol2RWIozPah0jKL2Iucp//+V6H4K RoAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711191734; x=1711796534; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dq9iZxQWSEhkDSaw4XzDPMOvLVbhwjj2yH4g9CSlP7k=; b=RlprsgHhlPQkoU0RpV7/a5rNHPL6JaYLnqZJsc7e+Jla2jHTLqbgRQkr7OKDysYYQ6 1UHb7FmH/tfK9b4YKRZOn++9sMaGMBtTBioy7AHqfKZgLHe4nn+cd/T7zGJ3oK9SvbPV jiLeSq/X+1YFwbKOa+aSqPEurjNzUt26XG/k+sNnBKfsEkf+jzyj7hnre87P/mUWbrCx zFjpkfn+ncFbSYwrcnzRjIysvaF5ZM3iBocH8YcG1nKBaDqtprG+WC1hqo1g/yLqsanW 6G5ocpx2l1ZfISUYcCcXTaX3Rbv8nUBjHH449jx7tVBPBz94I1GRovvMnu1mL/YIJmgN vmAA== X-Forwarded-Encrypted: i=1; AJvYcCUzL40qonZhwOUYacd0ylVb1ZmEM/+EmzCkJT9j1axqvRm+2n8ryDcHfPLnJ5mDTx8ih9YDIG8QS00FjjHCYUWy7q9UuKa0RY+USQ== X-Gm-Message-State: AOJu0Yxbnd+Asu5iEdr34AHraVhMqBu+BGJxYE6A+qLKG9OZ+nq4Sz3U osC1ZbMtJd8S8/XjVBSXbq3qdU83N5V59Igcws6EdTEywvmxCqq9CUS5W82eYZA= X-Google-Smtp-Source: AGHT+IFgRdL1ldCMZPGdtxNQwCeQt6fRjLSGiWKoxzjM+E933CWvgDGRRxcb0E5RDdjN2Q3HQajR3Q== X-Received: by 2002:a50:9984:0:b0:56b:f2d6:4be1 with SMTP id m4-20020a509984000000b0056bf2d64be1mr1436258edb.4.1711191734212; Sat, 23 Mar 2024 04:02:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id q3-20020a5085c3000000b005645961ad39sm767848edh.47.2024.03.23.04.02.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Mar 2024 04:02:13 -0700 (PDT) Message-ID: Date: Sat, 23 Mar 2024 12:02:11 +0100 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: Add rk816 binding To: Alex Bee , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Linus Walleij , Liam Girdwood , Mark Brown Cc: Chris Zhong , Zhang Qing , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20240323085852.116756-1-knaerzche@gmail.com> <20240323085852.116756-2-knaerzche@gmail.com> <3c0d5aa2-55fb-4827-bcd4-256e6ae55ee9@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <3c0d5aa2-55fb-4827-bcd4-256e6ae55ee9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/03/2024 11:56, Alex Bee wrote: > Hi Krzysztof, > > Am 23.03.24 um 11:32 schrieb Krzysztof Kozlowski: >> On 23/03/2024 09:58, Alex Bee wrote: >>> Add DT binding document for Rockchip's RK816 PMIC >>> >>> Signed-off-by: Alex Bee >>> --- >>> changes since v1: >>> - lowercase/hyphens for regulator node names >>> - rename "-reg" to "-regulator" to make node names generic >> I don't understand why did you do it. I did not ask for it. If you want >> to rename, drop redundant regulator or reg suffix from node names. > You didn't ask for that, thats true. > > I did it regardless, since node names should be generic and the "-reg" device node names, here you do not have devices. > suffix is not. They are all subnodes of "regulators", indeed, but I don't > think dropping the suffix completely makes the binding any better, since > there is a boost(-switch) and an otg-switch which are also subnodes of > "regulators" and they are just switches. Adding "regulator" suffix does not make them more generic... anyway, that's not expected pattern. First, do you see such code anywhere? Second, the regulator node names should be usually named as the name of physical component. That's the most common pattern. Please do not bring some exceptions from coding style just for your device. Your device is not special. You did not respond to rest of my comments, so I assume you agree 100% with them. Also, please trim the replies from unneeded context. Best regards, Krzysztof