[PATCH 0/2] pinctrl: pinconf-generic: Add "input-schmitt-microvolt" property

[PATCH 0/2] pinctrl: pinconf-generic: Add "input-schmitt-microvolt" property

[Inochi Amaoto]

On Sophgo CV18XX platform, threshold strength of schmitt trigger can
be configured. As this standard property is already supported by the
common pinconf code. Add "input-schmitt-microvolt" property in
pincfg-node.yaml so that other platforms requiring such feature can
make use of this property.

See the previous patch discussion about why add "microvolt" suffix:
https://lore.kernel.org/all/IA1PR20MB4953BB6E71CA3216E652E8B8BBA02@IA1PR20MB4953.namprd20.prod.outlook.com/

Changed for the original patch series:
1. add "microvolt" suffix

Inochi Amaoto (2):
  dt-bindings: pincfg-node: Add "input-schmitt-microvolt" property
  pinctrl: pinconf-generic: Add support for "input-schmitt-microvolt"
    property

 Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 3 +++
 drivers/pinctrl/pinconf-generic.c                          | 2 ++
 include/linux/pinctrl/pinconf-generic.h                    | 3 +++
 3 files changed, 8 insertions(+)

--
2.45.2

[PATCH 1/2] dt-bindings: pincfg-node: Add "input-schmitt-microvolt" property

[Inochi Amaoto]

On Sophgo CV18XX platform, threshold strength of schmitt trigger can
be configured. As this standard property is already supported by the
common pinconf code. Add "input-schmitt-microvolt" property in
pincfg-node.yaml so that other platforms requiring such feature can
make use of this property.

Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
---
 Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
index d0af21a564b4..cbfcf215e571 100644
--- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
@@ -96,6 +96,9 @@ properties:
     type: boolean
     description: disable schmitt-trigger mode

+  input-schmitt-microvolt:
+    description: threshold strength for schmitt-trigger
+
   input-debounce:
     $ref: /schemas/types.yaml#/definitions/uint32-array
     description: Takes the debounce time in usec as argument or 0 to disable
--
2.45.2

[PATCH 2/2] pinctrl: pinconf-generic: Add support for "input-schmitt-microvolt" property

[Inochi Amaoto]

Add "input-schmitt-microvolt" property to generic options used for DT
parsing files. This enables drivers, which use generic pin configurations,
to get the value passed to this property.

Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
---
 drivers/pinctrl/pinconf-generic.c       | 2 ++
 include/linux/pinctrl/pinconf-generic.h | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c
index 80de389199bd..b9860fd31cbf 100644
--- a/drivers/pinctrl/pinconf-generic.c
+++ b/drivers/pinctrl/pinconf-generic.c
@@ -44,6 +44,7 @@ static const struct pin_config_item conf_items[] = {
 	PCONFDUMP(PIN_CONFIG_INPUT_DEBOUNCE, "input debounce", "usec", true),
 	PCONFDUMP(PIN_CONFIG_INPUT_ENABLE, "input enabled", NULL, false),
 	PCONFDUMP(PIN_CONFIG_INPUT_SCHMITT, "input schmitt trigger", NULL, false),
+	PCONFDUMP(PIN_CONFIG_INPUT_SCHMITT_UV, "input schmitt threshold", "uV", true),
 	PCONFDUMP(PIN_CONFIG_INPUT_SCHMITT_ENABLE, "input schmitt enabled", NULL, false),
 	PCONFDUMP(PIN_CONFIG_MODE_LOW_POWER, "pin low power", "mode", true),
 	PCONFDUMP(PIN_CONFIG_OUTPUT_ENABLE, "output enabled", NULL, false),
@@ -177,6 +178,7 @@ static const struct pinconf_generic_params dt_params[] = {
 	{ "input-schmitt", PIN_CONFIG_INPUT_SCHMITT, 0 },
 	{ "input-schmitt-disable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 0 },
 	{ "input-schmitt-enable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 1 },
+	{ "input-schmitt-microvolts", PIN_CONFIG_INPUT_SCHMITT_UV, 0 },
 	{ "low-power-disable", PIN_CONFIG_MODE_LOW_POWER, 0 },
 	{ "low-power-enable", PIN_CONFIG_MODE_LOW_POWER, 1 },
 	{ "output-disable", PIN_CONFIG_OUTPUT_ENABLE, 0 },
diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h
index a65d3d078e58..53cfde98433d 100644
--- a/include/linux/pinctrl/pinconf-generic.h
+++ b/include/linux/pinctrl/pinconf-generic.h
@@ -81,6 +81,8 @@ struct pinctrl_map;
  * @PIN_CONFIG_INPUT_SCHMITT_ENABLE: control schmitt-trigger mode on the pin.
  *      If the argument != 0, schmitt-trigger mode is enabled. If it's 0,
  *      schmitt-trigger mode is disabled.
+ * @PIN_CONFIG_INPUT_SCHMITT_UV: this will configure an input pin to run in
+ *	schmitt-trigger mode. The argument is in uV.
  * @PIN_CONFIG_MODE_LOW_POWER: this will configure the pin for low power
  *	operation, if several modes of operation are supported these can be
  *	passed in the argument on a custom form, else just use argument 1
@@ -132,6 +134,7 @@ enum pin_config_param {
 	PIN_CONFIG_INPUT_ENABLE,
 	PIN_CONFIG_INPUT_SCHMITT,
 	PIN_CONFIG_INPUT_SCHMITT_ENABLE,
+	PIN_CONFIG_INPUT_SCHMITT_UV,
 	PIN_CONFIG_MODE_LOW_POWER,
 	PIN_CONFIG_MODE_PWM,
 	PIN_CONFIG_OUTPUT,
--
2.45.2

Re: [PATCH 1/2] dt-bindings: pincfg-node: Add "input-schmitt-microvolt" property

[Krzysztof Kozlowski]

On 18/07/2024 04:23, Inochi Amaoto wrote:
> On Sophgo CV18XX platform, threshold strength of schmitt trigger can
> be configured. As this standard property is already supported by the
> common pinconf code. Add "input-schmitt-microvolt" property in
> pincfg-node.yaml so that other platforms requiring such feature can
> make use of this property.
> 
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH 0/2] pinctrl: pinconf-generic: Add "input-schmitt-microvolt" property

[Linus Walleij]

On Thu, Jul 18, 2024 at 4:23 AM Inochi Amaoto <inochiama@outlook.com> wrote:

> On Sophgo CV18XX platform, threshold strength of schmitt trigger can
> be configured. As this standard property is already supported by the
> common pinconf code. Add "input-schmitt-microvolt" property in
> pincfg-node.yaml so that other platforms requiring such feature can
> make use of this property.
>
> See the previous patch discussion about why add "microvolt" suffix:
> https://lore.kernel.org/all/IA1PR20MB4953BB6E71CA3216E652E8B8BBA02@IA1PR20MB4953.namprd20.prod.outlook.com/
>
> Changed for the original patch series:
> 1. add "microvolt" suffix
>
> Inochi Amaoto (2):
>   dt-bindings: pincfg-node: Add "input-schmitt-microvolt" property
>   pinctrl: pinconf-generic: Add support for "input-schmitt-microvolt"
>     property

Patches applied!

Yours,
Linus Walleij