From: Greg Ungerer <gerg@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH] m68k: coldfire: Include the GPIO driver header
Date: Wed, 21 Aug 2019 22:22:19 +1000 [thread overview]
Message-ID: <fb01f312-5cc5-03a1-a1a5-a12819e2ff7b@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdWF1GXYtFbjrALRMObqzezd-cBwDPAqhC-9d=RbrLxNyQ@mail.gmail.com>
On 21/8/19 5:19 pm, Geert Uytterhoeven wrote:
> CC Greg (coldfire)
Thanks Geert.
I am happy to take it via the m68knommu tree if you prefer?
Regards
Greg
> On Wed, Aug 21, 2019 at 9:09 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>> The Coldfire GPIO driver needs to explicitly incldue the
>> GPIO driver header since it is providing a driver.
>>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Geert can you pick this up for m68k?
>> ---
>> arch/m68k/coldfire/gpio.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/m68k/coldfire/gpio.c b/arch/m68k/coldfire/gpio.c
>> index a83898426127..ca26de257871 100644
>> --- a/arch/m68k/coldfire/gpio.c
>> +++ b/arch/m68k/coldfire/gpio.c
>> @@ -9,6 +9,7 @@
>> #include <linux/module.h>
>> #include <linux/init.h>
>> #include <linux/device.h>
>> +#include <linux/gpio/driver.h>
>>
>> #include <linux/io.h>
>> #include <asm/coldfire.h>
>> --
>> 2.21.0
>
next prev parent reply other threads:[~2019-08-21 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 7:09 [PATCH] m68k: coldfire: Include the GPIO driver header Linus Walleij
2019-08-21 7:19 ` Geert Uytterhoeven
2019-08-21 12:22 ` Greg Ungerer [this message]
2019-08-21 12:50 ` Geert Uytterhoeven
2019-08-22 0:50 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb01f312-5cc5-03a1-a1a5-a12819e2ff7b@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=bgolaszewski@baylibre.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).