From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Arnd Bergmann <arnd@arndb.de>, Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Cc: linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, platform-driver-x86@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Randy Dunlap <rdunlap@infradead.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: pcengines-apu2 needs gpiolib
Date: Sat, 13 Jul 2019 16:36:36 +0200 [thread overview]
Message-ID: <fb36b507-e637-e4d9-fdd4-2947eb7faf14@metux.net> (raw)
In-Reply-To: <20190712085437.4007720-1-arnd@arndb.de>
On 12.07.19 10:54, Arnd Bergmann wrote:
Hi,
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index e869a5c760b6..cf48b9068843 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1324,8 +1324,8 @@ config PCENGINES_APU2
> tristate "PC Engines APUv2/3 front button and LEDs driver"
> depends on INPUT && INPUT_KEYBOARD
> depends on LEDS_CLASS
> - select GPIO_AMD_FCH
> - select KEYBOARD_GPIO_POLLED
> + select GPIO_AMD_FCH if GPIOLIB
> + select KEYBOARD_GPIO_POLLED if GPIOLIB
> select LEDS_GPIO
> help
> This driver provides support for the front button and LEDs on
That might compile but the driver won't work, if KEYBOARD_GPIO_POLLED
or GPIO_AMD_FCH isn't there.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2019-07-13 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 8:54 [PATCH] platform/x86: pcengines-apu2 needs gpiolib Arnd Bergmann
2019-07-13 14:36 ` Enrico Weigelt, metux IT consult [this message]
2019-07-13 15:34 ` Arnd Bergmann
2019-07-14 16:41 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb36b507-e637-e4d9-fdd4-2947eb7faf14@metux.net \
--to=lkml@metux.net \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=dvhart@infradead.org \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox