Re: [PATCH v3 1/2] dt-bindings: pinctrl: eswin: Document for EIC7700 SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/05/2025 10:11, Yulin Lu wrote:
> +
> +          - if:
> +              properties:
> +                pins:
> +                  anyOf:
> +                    - pattern: '^rgmii'
> +                    - const: lpddr_ref_clk
> +            then:
> +              properties:
> +                drive-strength-microamp:
> +                  enum: [3000, 6000, 9000, 12000, 15000, 18000, 21000, 24000]
> +            else:
> +              properties:
> +                drive-strength-microamp:
> +                  enum: [6000, 9000, 12000, 15000, 18000, 21000, 24000, 27000]
> +
> +

Just one blank line

> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pinctrl@51600080 {
> +      compatible = "eswin,eic7700-pinctrl";
> +      reg = <0x51600080 0x1fff80>;
> +      vrgmii-supply = <&vcc_1v8>;
> +
> +      dev-active-grp{

Missing space before {


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

> +    };


Best regards,
Krzysztof