* [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF
@ 2016-07-22 18:06 Randy Dunlap
2016-07-22 18:09 ` Ray Jui
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2016-07-22 18:06 UTC (permalink / raw)
To: linux-next@vger.kernel.org
Cc: Ray Jui, bcm-kernel-feedback-list, linux-arm-kernel,
Linus Walleij, linux-gpio, LKML
From: Randy Dunlap <rdunlap@infradead.org>
Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
but COMPILE_TEST is enabled by making the driver depend on OF.
../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
.dt_node_to_map = pinconf_generic_dt_node_to_map_group,
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Ray Jui <rjui@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
---
drivers/pinctrl/bcm/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
+++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
@@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
config PINCTRL_CYGNUS_MUX
bool "Broadcom Cygnus IOMUX driver"
depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
+ depends on OF
select PINMUX
select GENERIC_PINCONF
default ARCH_BCM_CYGNUS
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF
2016-07-22 18:06 [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF Randy Dunlap
@ 2016-07-22 18:09 ` Ray Jui
2016-07-22 18:17 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Ray Jui @ 2016-07-22 18:09 UTC (permalink / raw)
To: Randy Dunlap, linux-next@vger.kernel.org
Cc: Ray Jui, bcm-kernel-feedback-list, linux-arm-kernel,
Linus Walleij, linux-gpio, LKML
Hi Randy,
On 7/22/2016 11:06 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
> but COMPILE_TEST is enabled by making the driver depend on OF.
>
> ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> ---
> drivers/pinctrl/bcm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
> +++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
> @@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
> config PINCTRL_CYGNUS_MUX
> bool "Broadcom Cygnus IOMUX driver"
> depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
> + depends on OF
> select PINMUX
> select GENERIC_PINCONF
> default ARCH_BCM_CYGNUS
>
Thanks, but a fix was already submitted by Arnd and picked up by Linus:
https://lkml.org/lkml/2016/7/15/649
Ray
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF
2016-07-22 18:09 ` Ray Jui
@ 2016-07-22 18:17 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2016-07-22 18:17 UTC (permalink / raw)
To: Ray Jui, linux-next@vger.kernel.org
Cc: Ray Jui, bcm-kernel-feedback-list, linux-arm-kernel,
Linus Walleij, linux-gpio, LKML
On 07/22/16 11:09, Ray Jui wrote:
> Hi Randy,
>
> On 7/22/2016 11:06 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix pinctrl-cygnus-mux.c build when ARCH_BCM_CYGNUS is not enabled
>> but COMPILE_TEST is enabled by making the driver depend on OF.
>>
>> ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function)
>> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Ray Jui <rjui@broadcom.com>
>> Cc: bcm-kernel-feedback-list@broadcom.com
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: linux-gpio@vger.kernel.org
>> ---
>> drivers/pinctrl/bcm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20160722.orig/drivers/pinctrl/bcm/Kconfig
>> +++ linux-next-20160722/drivers/pinctrl/bcm/Kconfig
>> @@ -60,6 +60,7 @@ config PINCTRL_IPROC_GPIO
>> config PINCTRL_CYGNUS_MUX
>> bool "Broadcom Cygnus IOMUX driver"
>> depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
>> + depends on OF
>> select PINMUX
>> select GENERIC_PINCONF
>> default ARCH_BCM_CYGNUS
>>
>
> Thanks, but a fix was already submitted by Arnd and picked up by Linus: https://lkml.org/lkml/2016/7/15/649
OK, it's just not in linux-next yet.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-22 18:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-22 18:06 [PATCH -next] pinctrl: fix build, PINCTRL_CYGNUS_MUX depends on OF Randy Dunlap
2016-07-22 18:09 ` Ray Jui
2016-07-22 18:17 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).