Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Marco Scardovi <scardracs@disroot.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Basavaraj Natikar <bnatikar@amd.com>,
	w_armin@gmx.de, brgl@kernel.org, linusw@kernel.org,
	linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, westeri@kernel.org
Subject: Re: [PATCH v2 0/1] gpiolib: acpi: Add quirk for ASUS ROG Strix G16 G614 series
Date: Sun, 21 Jun 2026 00:58:22 -0700	[thread overview]
Message-ID: <fc25f967-ab71-499c-8e50-ac74286bdf2d@amd.com> (raw)
In-Reply-To: <JL9AWbK0SzeIHPRy6K6QhA@disroot.org>



On 6/20/26 00:20, Marco Scardovi wrote:
> In data sabato 20 giugno 2026 08:52:27 Ora legale dell’Europa centrale, Andy Shevchenko ha scritto:
>> On Fri, Jun 19, 2026 at 12:28:49PM +0200, Marco Scardovi wrote:
>>> In data venerdì 19 giugno 2026 12:17:17 Ora legale dell’Europa centrale, Basavaraj Natikar ha scritto:
>>>> On 6/18/2026 11:37 PM, Marco Scardovi wrote:
>>>>> In data giovedì 18 giugno 2026 20:01:40 Ora legale dell’Europa centrale, Andy Shevchenko ha scritto:
>>>>>> On Thu, Jun 18, 2026 at 06:59:15PM +0200, Marco Scardovi wrote:
>>>>>>> On Thu, Jun 18, 2026 at 16:35:37 CEST, Andy Shevchenko wrote:
>>>>>>>> On Thu, Jun 18, 2026 at 06:46:28PM +0530, Basavaraj Natikar wrote:
>>>>>>>>> On 6/18/2026 4:44 AM, Marco Scardovi wrote:
>>>>>>>>>> On Wed, Jun 17, 2026 at 10:33 PM, Armin Wolf wrote:
>>
>> ...
>>
>>>> I also checked the BIOS 316 ACPI dump — the stalling path is byte‑for‑byte identical
>>>> to 315, so the AML is unchanged and it'll still stall if pin 21 boots low.
>>>>
>>>> On the OEM side, I'm connecting internally with our AMD contact for ASUS to report
>>>> this behavior and follow up on a firmware fix.
>>>
>>> Thank you. Does that mean that my patch will not be required anymore?
>>> If that's the case you can consider it as null. I don't mind having the boot
>>> flag added until it's completely fixed on ASUS' side. BTW I have the suspect
>>> that my model is not the only one with the long boot bug on ASUS [1] [2]
>>> but actually the only one who came up with an actual patch on the kernel.
>>
>> I believe your patch is still needed. Not every model might get a BIOS update,
>> and no guarantee that everybody who possesses the problematic platforms
>> actually *will* update the BIOS. But it's AMD's call. I will happily accept
>> the changes acknowledged by AMD.
>>
> Uhm, right. Not everyone are crazy over updating everything.
> 
> As soon as I have a complete response from AMD and Asus I'll proceed
> with a proper patch.
> 
> For now, thank you all for checking it out and giving your time for feedback.

Maybe it's clear to everyone else but me; but if this is ASL used for 
the dGPU shouldn't we get someone from NVIDIA to add their 2¢?

Maybe *they* had intended this to be both edge triggered and that's how 
it got here.

I can't imagine this is going to be the only case we see of this.  So 
before we go down that quirk path can we get them to weigh in?  Maybe 
send to dri-devel and CC the nvidia folks that work on the kernel.

  reply	other threads:[~2026-06-21  7:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  9:08 [PATCH] gpiolib: acpi: Add quirk for ASUS ROG Strix G614 series Marco Scardovi
2026-06-16  9:31 ` Andy Shevchenko
2026-06-16  9:43   ` Marco Scardovi
2026-06-16  9:58     ` Andy Shevchenko
2026-06-16 10:24       ` Mika Westerberg
2026-06-16 10:58         ` Marco Scardovi
2026-06-16 11:04           ` Andy Shevchenko
2026-06-17  8:51             ` Marco Scardovi
2026-06-17  8:52             ` Marco Scardovi
2026-06-17 18:34 ` Basavaraj Natikar
2026-06-17 18:50   ` [PATCH v2 0/1] gpiolib: acpi: Add quirk for ASUS ROG Strix G16 " Marco Scardovi
2026-06-17 18:50     ` [PATCH v2 1/1] " Marco Scardovi
2026-06-17 21:23     ` [PATCH v2 0/1] " Armin Wolf
2026-06-17 23:14       ` Marco Scardovi
2026-06-18 13:16         ` Basavaraj Natikar
2026-06-18 14:35           ` Andy Shevchenko
2026-06-18 16:59             ` Marco Scardovi
2026-06-18 18:01               ` Andy Shevchenko
2026-06-18 18:07                 ` Marco Scardovi
2026-06-19 10:17                   ` Basavaraj Natikar
2026-06-19 10:28                     ` Marco Scardovi
2026-06-20  6:52                       ` Andy Shevchenko
2026-06-20  7:20                         ` Marco Scardovi
2026-06-21  7:58                           ` Mario Limonciello [this message]
2026-06-21 11:00     ` Hans de Goede
2026-06-21 12:38       ` Marco Scardovi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc25f967-ab71-499c-8e50-ac74286bdf2d@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bnatikar@amd.com \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scardracs@disroot.org \
    --cc=w_armin@gmx.de \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox