* [PATCH v1] drivers/pinctrl/samsung: Use kmemdup_array instead of kmemdup for multiple allocation
@ 2024-08-23 8:24 Shen Lichuan
2024-08-23 8:56 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Shen Lichuan @ 2024-08-23 8:24 UTC (permalink / raw)
To: krzk, s.nawrocki, linus.walleij
Cc: alim.akhtar, linux-arm-kernel, linux-samsung-soc, linux-gpio,
linux-kernel, opensource.kernel, Shen Lichuan
Let the kememdup_array() take care about
multiplication and possible overflows.
Using kmemdup_array() is more appropriate
and makes the code easier to audit.
Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index e4464ee815f9..da24890f27f7 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -122,8 +122,8 @@ static int add_map_configs(struct device *dev, struct pinctrl_map **map,
if (WARN_ON(*num_maps == *reserved_maps))
return -ENOSPC;
- dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs),
- GFP_KERNEL);
+ dup_configs = kmemdup_array(configs, num_configs,
+ sizeof(*dup_configs), GFP_KERNEL);
if (!dup_configs)
return -ENOMEM;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] drivers/pinctrl/samsung: Use kmemdup_array instead of kmemdup for multiple allocation
2024-08-23 8:24 [PATCH v1] drivers/pinctrl/samsung: Use kmemdup_array instead of kmemdup for multiple allocation Shen Lichuan
@ 2024-08-23 8:56 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-23 8:56 UTC (permalink / raw)
To: Shen Lichuan, s.nawrocki, linus.walleij
Cc: alim.akhtar, linux-arm-kernel, linux-samsung-soc, linux-gpio,
linux-kernel, opensource.kernel
On 23/08/2024 10:24, Shen Lichuan wrote:
> Let the kememdup_array() take care about
> multiplication and possible overflows.
>
> Using kmemdup_array() is more appropriate
> and makes the code easier to audit.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index e4464ee815f9..da24890f27f7 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -122,8 +122,8 @@ static int add_map_configs(struct device *dev, struct pinctrl_map **map,
> if (WARN_ON(*num_maps == *reserved_maps))
> return -ENOSPC;
>
> - dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs),
> - GFP_KERNEL);
> + dup_configs = kmemdup_array(configs, num_configs,
> + sizeof(*dup_configs), GFP_KERNEL);
Misaligned and wrapped too early.
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-23 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-23 8:24 [PATCH v1] drivers/pinctrl/samsung: Use kmemdup_array instead of kmemdup for multiple allocation Shen Lichuan
2024-08-23 8:56 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).