From: Alexey Dobriyan <adobriyan@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: WARNING: fs/proc/generic.c:173 __xlate_proc_name
Date: Sun, 25 Feb 2024 19:27:35 +0300 [thread overview]
Message-ID: <fe33dcf1-79c0-4f56-8848-474caa014c10@p183> (raw)
In-Reply-To: <c51a282a-bdbf-4ced-9fcf-e38a33152761@gmx.net>
On Sun, Feb 25, 2024 at 11:47:30AM +0100, Stefan Wahren wrote:
> Hi Alexey,
>
> Am 25.02.24 um 11:37 schrieb Alexey Dobriyan:
> > > WARNING: CPU: 0 PID: 429 at fs/proc/generic.c:173
> > > __xlate_proc_name+0x78/0x98 name 'R1/S1'
> > proc_mkdir() didn't find 'R1' directory.
> >
> > In other words, you can't have slashes in irq names.
> we already came to the point in the discussion before (link in my last
> mail). The problem is no libgpiod user (userspace) is aware of this.
Changing '/' to '-' or '.' should be OK. Whatever you do, don't change
to '!' because it will make these paths annoying to use in bash.
> So the next question is where it should be fixed?
libgpiod silently weren't getting directory inside /proc/irq/${irq}
and nobody noticed until now.
I think returning error may be too harsh but replacing characters is not.
> Sorry, i took my original message because posting the last message to
> linux-fsdevel without context would be pointless.
next prev parent reply other threads:[~2024-02-25 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 10:37 WARNING: fs/proc/generic.c:173 __xlate_proc_name Alexey Dobriyan
2024-02-25 10:47 ` Stefan Wahren
2024-02-25 16:27 ` Alexey Dobriyan [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-10 10:06 Stefan Wahren
2024-02-12 10:56 ` Bartosz Golaszewski
2024-02-12 13:34 ` Linus Walleij
2024-02-12 13:46 ` Geert Uytterhoeven
2024-02-12 14:11 ` Bartosz Golaszewski
2024-02-13 3:04 ` Kent Gibson
2024-02-25 10:13 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe33dcf1-79c0-4f56-8848-474caa014c10@p183 \
--to=adobriyan@gmail.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wahrenst@gmx.net \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox