From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Huqiang Qin <huqiang.qin@amlogic.com>,
linus.walleij@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
brgl@bgdev.pl, andy@kernel.org
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: Add compatibles for Amlogic T7 SoCs
Date: Thu, 14 Sep 2023 09:19:29 +0200 [thread overview]
Message-ID: <ff4f2b93-7e22-8b15-aaad-b7d6f8b5517d@linaro.org> (raw)
In-Reply-To: <cde944c4-acfe-b3fb-32b8-072740475e35@amlogic.com>
On 14/09/2023 09:00, Huqiang Qin wrote:
> Hi Krzysztof,
>
> On 2023/9/14 14:16, Krzysztof Kozlowski wrote:
> ...
>>> diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>>> new file mode 100644
>>> index 000000000000..2bab9a99501a
>>> --- /dev/null
>>> +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>>
>> Use compatible syntax.
>
> The amlogic-t7-gpio.h is not a file in the dt-bindings/pinctrl/ directory.
> Does it also need to be named according to the compatible name of pinctrl?
The convention, which we introduced since ~1-2 years, is to use the
device compatible or binding filename as the headers filename. Now,
where you put what does not affect it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-14 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 5:45 [PATCH 0/3] Add pinctrl driver support for Amlogic T7 SoCs Huqiang Qin
2023-09-14 5:45 ` [PATCH 1/3] dt-bindings: pinctrl: Add compatibles " Huqiang Qin
2023-09-14 6:16 ` Krzysztof Kozlowski
2023-09-14 7:00 ` Huqiang Qin
2023-09-14 7:19 ` Krzysztof Kozlowski [this message]
2023-09-14 8:24 ` Huqiang Qin
2023-09-14 5:45 ` [PATCH 2/3] pinctrl: Add driver support " Huqiang Qin
2023-09-14 8:27 ` neil.armstrong
2023-09-14 5:45 ` [PATCH 3/3] arm64: dts: Add pinctrl node " Huqiang Qin
2023-09-14 8:27 ` neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4f2b93-7e22-8b15-aaad-b7d6f8b5517d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).