From: Mukesh Ojha <mojha@codeaurora.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Benoit Parrot <bparrot@ti.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] gpio: Remove obsolete comment about gpiochip_free_hogs() usage
Date: Thu, 28 Mar 2019 20:31:48 +0530 [thread overview]
Message-ID: <ff6d95d6-9022-4cab-bc53-bb9ffd14ed68@codeaurora.org> (raw)
In-Reply-To: <20190328131349.18838-4-geert+renesas@glider.be>
On 3/28/2019 6:43 PM, Geert Uytterhoeven wrote:
> gpiochip_free_hogs() was always called from gpiochip_remove(), not
> of_gpiochip_remove(). It is now also called from the failure patch in
> gpiochip_add_data_with_key().
>
> Fixes: f625d4601759f1cf ("gpio: add GPIO hogging mechanism")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks good to be removed.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> ---
> drivers/gpio/gpiolib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index ed4da07effe0ac40..ec326bd84b1f1c50 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -4449,8 +4449,6 @@ int gpiod_hog(struct gpio_desc *desc, const char *name,
> /**
> * gpiochip_free_hogs - Scan gpio-controller chip and release GPIO hog
> * @chip: gpio chip to act on
> - *
> - * This is only used by of_gpiochip_remove to free hogged gpios
> */
> static void gpiochip_free_hogs(struct gpio_chip *chip)
> {
next prev parent reply other threads:[~2019-03-28 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 13:13 [PATCH 0/3] gpio: Failure path fixes Geert Uytterhoeven
2019-03-28 13:13 ` [PATCH 1/3] gpio: of: Fix of_gpiochip_add() error path Geert Uytterhoeven
2019-03-28 15:37 ` Mukesh Ojha
2019-03-28 16:58 ` Linus Walleij
2019-03-28 13:13 ` [PATCH 2/3] gpio: Fix gpiochip_add_data_with_key() " Geert Uytterhoeven
2019-03-28 15:31 ` Mukesh Ojha
2019-03-28 18:20 ` Geert Uytterhoeven
2019-03-28 17:03 ` Linus Walleij
2019-03-28 13:13 ` [PATCH 3/3] gpio: Remove obsolete comment about gpiochip_free_hogs() usage Geert Uytterhoeven
2019-03-28 15:01 ` Mukesh Ojha [this message]
2019-03-28 17:00 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff6d95d6-9022-4cab-bc53-bb9ffd14ed68@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=bgolaszewski@baylibre.com \
--cc=bparrot@ti.com \
--cc=geert+renesas@glider.be \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).