From: Dmitry Osipenko <digetx@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/6] gpio: max77620: Don't set of_node
Date: Thu, 9 Jul 2020 13:38:26 +0300 [thread overview]
Message-ID: <ff7985a4-58be-b466-62c2-abce9ae1c0f0@gmail.com> (raw)
In-Reply-To: <CAHp75Vd89QpwaGvkpzG+pxnLd8S2guPCARLW5xPwhxXL8ZRfFw@mail.gmail.com>
09.07.2020 12:07, Andy Shevchenko пишет:
> On Thu, Jul 9, 2020 at 12:44 AM Dmitry Osipenko <digetx@gmail.com> wrote:
>> 08.07.2020 23:57, Andy Shevchenko пишет:
>>> On Wednesday, July 8, 2020, Dmitry Osipenko <digetx@gmail.com
>>> <mailto:digetx@gmail.com>> wrote:
>
> ...
>
>>> I gave a second look and I think my suggestion is wrong. Here is an
>>> interesting propagation of the parent device node to its grand son,
>>> leaving son’s one untouched. Original code has intentions to do that way.
>>
>> The [1] says that gpio_chip.parent should point at the "device providing
>> the GPIOs".
>
> Yes, physical device I believe.
>
>> That's the pdev->dev.parent in the case of this driver.
>> MAX77620 is an MFD PMIC device that has virtual sub-devices like GPIO
>> controller, PINCTRL and RTC. The MFD is the parent device that provides
>> the GPIOs [2].
>>
>> [1]
>> https://elixir.bootlin.com/linux/v5.8-rc3/source/include/linux/gpio/driver.h#L276
>>
>> [2]
>> https://elixir.bootlin.com/linux/v5.8-rc3/source/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi#L48
>>
>> I think the old code was wrong and this patch is correct, please correct
>> me if I'm missing something.
>
> Hmm... I have checked through GPIO drivers I have knowledge of / care
> about and PMIC ones do like you suggested in this patch, the rest
> (which are instantiated from MFD) take a virtual platform device.
>
> Looking at DT excerpt I think you're rather right than wrong, so I
> leave it to you and maintainers.
> Thanks!
Okay, waiting for the maintainers then :)
Thank you very much for the review!
next prev parent reply other threads:[~2020-07-09 10:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 20:23 [PATCH v3 0/6] Improvements for MAX77620 GPIO driver Dmitry Osipenko
2020-07-08 20:23 ` [PATCH v3 1/6] gpio: max77620: Replace 8 with MAX77620_GPIO_NR Dmitry Osipenko
2020-07-09 14:54 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 2/6] gpio: max77620: Fix missing release of interrupt Dmitry Osipenko
2020-07-09 14:57 ` Laxman Dewangan
2020-07-09 16:36 ` Dmitry Osipenko
2020-07-08 20:23 ` [PATCH v3 3/6] gpio: max77620: Don't set of_node Dmitry Osipenko
[not found] ` <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ@mail.gmail.com>
2020-07-08 21:44 ` Dmitry Osipenko
2020-07-09 9:07 ` Andy Shevchenko
2020-07-09 10:38 ` Dmitry Osipenko [this message]
2020-07-09 14:58 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 4/6] gpio: max77620: Don't shadow error code of platform_get_irq() Dmitry Osipenko
2020-07-09 15:01 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 5/6] gpio: max77620: Use irqchip template Dmitry Osipenko
2020-07-09 15:03 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 6/6] gpio: max77620: Initialize hardware state of interrupts Dmitry Osipenko
2020-07-09 15:03 ` Laxman Dewangan
[not found] ` <CAHp75VcNao84UajMYDJRH2gX7t8n=uo_Th8VVgcxJj3YkiA+pA@mail.gmail.com>
2020-07-08 21:49 ` [PATCH v1 0/5] Improvements for MAX77620 GPIO driver Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7985a4-58be-b466-62c2-abce9ae1c0f0@gmail.com \
--to=digetx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox