From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C22FEC43334 for ; Sun, 26 Jun 2022 04:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233918AbiFZEsx (ORCPT ); Sun, 26 Jun 2022 00:48:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233703AbiFZEsv (ORCPT ); Sun, 26 Jun 2022 00:48:51 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD04013CD4; Sat, 25 Jun 2022 21:48:50 -0700 (PDT) X-UUID: bb63f37a39444690989f5c3506ccfa1c-20220626 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.6,REQID:2cdadda3-9fb6-4760-a526-160f989ce651,OB:10,L OB:60,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,A CTION:release,TS:45 X-CID-INFO: VERSION:1.1.6,REQID:2cdadda3-9fb6-4760-a526-160f989ce651,OB:10,LOB :60,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,RULE:Release_Ham,ACT ION:release,TS:45 X-CID-META: VersionHash:b14ad71,CLOUDID:2f9a91d8-850a-491d-a127-60d9309b2b3e,C OID:0a685b5cea48,Recheck:0,SF:28|17|19|48,TC:nil,Content:-5,EDM:-3,IP:nil, URL:1,File:nil,QS:nil,BEC:nil,COL:0 X-UUID: bb63f37a39444690989f5c3506ccfa1c-20220626 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 863720791; Sun, 26 Jun 2022 12:48:45 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Sun, 26 Jun 2022 12:48:43 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sun, 26 Jun 2022 12:48:43 +0800 Message-ID: Subject: Re: [PATCH v2 3/5] pinctrl: mediatek: add rsel setting on mt8192 From: Guodong Liu To: "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" CC: Linus Walleij , Rob Herring , Matthias Brugger , Sean Wang , Sean Wang , Zhiyong Tao , , , , , , Date: Sun, 26 Jun 2022 12:48:42 +0800 In-Reply-To: <20220624152926.76hvymguryhfv4sq@notapiano> References: <20220624133700.15487-1-guodong.liu@mediatek.com> <20220624133700.15487-4-guodong.liu@mediatek.com> <20220624152926.76hvymguryhfv4sq@notapiano> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org -----Original Message----- From: Nícolas F. R. A. Prado To: Guodong Liu Cc: Linus Walleij , Rob Herring < robh+dt@kernel.org>, Matthias Brugger , Sean Wang , Sean Wang , Zhiyong Tao , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2 3/5] pinctrl: mediatek: add rsel setting on mt8192 Date: Fri, 24 Jun 2022 11:29:26 -0400 Hi Guodong, thanks for the patch. Please see comments below. On Fri, Jun 24, 2022 at 09:36:58PM +0800, Guodong Liu wrote: > 1. I2C pins's resistance value can be controlled by rsel register. > This patch provides rsel (resistance selection) setting on mt8192. > 2. Also add the missing pull type array for mt8192 to document the > pull type of each pin and prevent invalid pull type settings. > > Signed-off-by: Guodong Liu > --- > drivers/pinctrl/mediatek/pinctrl-mt8192.c | 136 > ++++++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > index efabeb422aea..ffb0b04f0e3c 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > + MTK_PULL_PU_PD_TYPE,/*100* MTK_PULL_PU_PD_TYPE,/*101*/ > + MTK_PULL_PU_PD_TYPE,/*102* MTK_PULL_PU_PD_TYPE,/*103*/ > + MTK_PULL_PU_PD_TYPE,/*104* MTK_PULL_PU_PD_TYPE,/*105*/ > + MTK_PULL_PU_PD_TYPE,/*106* MTK_PULL_PU_PD_TYPE,/*107*/ > + MTK_PULL_PU_PD_TYPE,/*108* MTK_PULL_PU_PD_TYPE,/*109*/ > + MTK_PULL_PU_PD_TYPE,/*110* MTK_PULL_PU_PD_TYPE,/*111*/ > + MTK_PULL_PU_PD_TYPE,/*112* MTK_PULL_PU_PD_TYPE,/*113*/ > + MTK_PULL_PU_PD_TYPE,/*114* MTK_PULL_PU_PD_TYPE,/*115*/ > + MTK_PULL_PU_PD_TYPE,/*116* MTK_PULL_PU_PD_TYPE,/*117*/ The comments on pins 100 - 116 are missing the closing '/', effectively commenting out pins 101 - 117 and leading to errors. Please fix this. Other than that, Fixed in next patch,thanks! Reviewed-by: Nícolas F. R. A. Prado Tested-by: Nícolas F. R. A. Prado Thanks, Nícolas