From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] pinctrl: meson: Drop pinctrl_unregister for devm_ registered device Date: Tue, 26 Jul 2016 14:56:44 -0700 Message-ID: References: <1469544718-32001-1-git-send-email-weiyj.lk@gmail.com> <20160726170053.GA40841@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pf0-f182.google.com ([209.85.192.182]:34356 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757444AbcGZV4r (ORCPT ); Tue, 26 Jul 2016 17:56:47 -0400 Received: by mail-pf0-f182.google.com with SMTP id p64so3592049pfb.1 for ; Tue, 26 Jul 2016 14:56:46 -0700 (PDT) In-Reply-To: <20160726170053.GA40841@dtor-ws> (Dmitry Torokhov's message of "Tue, 26 Jul 2016 10:00:53 -0700") Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Dmitry Torokhov Cc: Wei Yongjun , Linus Walleij , Carlo Caione , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Dmitry Torokhov writes: > On Tue, Jul 26, 2016 at 02:51:58PM +0000, Wei Yongjun wrote: >> It's not necessary to unregister pin controller device registered >> with devm_pinctrl_register() and using pinctrl_unregister() leads >> to a double free. >> >> This is detected by Coccinelle semantic patch. >> >> Signed-off-by: Wei Yongjun > > Fixes: e649f7ec8c5f ("pinctrl: meson: Use devm_pinctrl_register() for > pinctrl registration") > > Reviewed-by: Dmitry Torokhov Acked-by: Kevin Hilman