From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F38FC6FD1D for ; Thu, 23 Mar 2023 13:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbjCWNuD (ORCPT ); Thu, 23 Mar 2023 09:50:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231825AbjCWNuA (ORCPT ); Thu, 23 Mar 2023 09:50:00 -0400 X-Greylist: delayed 436 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 23 Mar 2023 06:49:57 PDT Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C219EC48 for ; Thu, 23 Mar 2023 06:49:57 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Pj63M2Y1Fz1r2Z4; Thu, 23 Mar 2023 14:42:39 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Pj63M1gxDz1qqlb; Thu, 23 Mar 2023 14:42:39 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id L941TGtA4KFG; Thu, 23 Mar 2023 14:42:38 +0100 (CET) X-Auth-Info: Y9ljV7DUgiDa0xJFxkULtCmdxBb9ocJEGCmvDHDXVPnz+6sqxe7kkrxP8wnJBm45 Received: from hawking (unknown [81.95.8.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 23 Mar 2023 14:42:38 +0100 (CET) From: Andreas Schwab To: Linus Walleij Cc: Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] m68k: Pass a pointer to virt_to_pfn() virt_to_page() References: <20230323133656.679478-1-linus.walleij@linaro.org> X-Yow: I fill MY industrial waste containers with old copies of the ``WATCHTOWER'' and then add HAWAIIAN PUNCH to the top.. They look NICE in the yard-- Date: Thu, 23 Mar 2023 14:42:37 +0100 In-Reply-To: <20230323133656.679478-1-linus.walleij@linaro.org> (Linus Walleij's message of "Thu, 23 Mar 2023 14:36:56 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mär 23 2023, Linus Walleij wrote: > diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c > index 911301224078..0a9bc8292f78 100644 > --- a/arch/m68k/mm/motorola.c > +++ b/arch/m68k/mm/motorola.c > @@ -102,7 +102,7 @@ static struct list_head ptable_list[2] = { > LIST_HEAD_INIT(ptable_list[1]), > }; > > -#define PD_PTABLE(page) ((ptable_desc *)&(virt_to_page(page)->lru)) > +#define PD_PTABLE(page) ((ptable_desc *)&(virt_to_page((void *)page)->lru)) That should probably get a pair of parens around the macro argument. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."