From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: linux-gpio@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64
Date: Fri, 09 Oct 2026 20:52:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-166062@kernel.org> (raw)
In-Reply-To: <20261009-helios64-pca9655-v1-2-673ee4432650@iav.lv>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: gpio: undocumented compatible string 'onnn,pca9655' breaks schema validation
--
commit 668c971a564e2ffdacc4bbee425f902a28c78be0
Author: Igor Velkov <iav@iav.lv>
arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64
This commit adds the ON Semiconductor PCA9655E 16-bit GPIO expander at 0x20
on I2C2 for the Kobol Helios64 board.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index d146e5075b4f8..a860bd2b3afc0 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -453,6 +453,20 @@ &i2c2 {
> i2c-scl-falling-time-ns = <30>;
> status = "okay";
>
> + gpio@20 {
> + compatible = "onnn,pca9655", "nxp,pca9555";
[Severity: Low]
Will this compatible string array in the gpio@20 node cause a dt-bindings
schema validation warning?
The "onnn,pca9655" string does not appear to be documented in the dt-bindings
for PCA95xx.
Additionally, schema files typically restrict "nxp,pca9555" to be a standalone
string via a single-item enum. Using an array of two strings could violate the
length and content restrictions when running make dtbs_check.
> + reg = <0x20>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&exp16_int_l>;
> + vcc-supply = <&vcc3v3_sys_s3>;
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-helios64-pca9655-v1-0-673ee4432650@iav.lv?part=2
next prev parent reply other threads:[~2026-10-09 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 20:45 [PATCH 0/2] Add the PCA9655E GPIO expander to Kobol Helios64 Igor Velkov via B4 Relay
2026-10-09 20:45 ` [PATCH 1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback Igor Velkov via B4 Relay
2026-10-12 9:07 ` Krzysztof Kozlowski
2026-10-09 20:45 ` [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64 Igor Velkov via B4 Relay
2026-10-09 20:52 ` sashiko-bot [this message]
2026-10-09 21:00 ` Igor Velkov
2026-10-12 14:01 ` (subset) [PATCH 0/2] Add the PCA9655E " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-166062@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iav@iav.lv \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox