Re: [PATCH 01/11] dt-bindings: gpio: Add NVIDIA LSTP GPIO

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing interrupt-controller in required list
--

commit aeb4a4fc6444001bea560a7fa11534922cb0e28e
Author: Adrian Ambrozewicz <aambrozewicz@nvidia.com>

dt-bindings: gpio: Add NVIDIA LSTP GPIO
    
Add the binding for a GPIO channel of an NVIDIA LSTP USB adapter. The
node is a child of the adapter's USB device or interface node, matched
to a channel the device reports by reg and compatible.

> diff --git a/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml b/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml
> new file mode 100644
> index 0000000000000..4ca5081e509d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/nvidia,lstp-gpio.yaml

[ ... ]

> +dependentRequired:
> +  interrupt-controller: ["#interrupt-cells"]
> +  "#interrupt-cells": [interrupt-controller]
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - "#gpio-cells"

[Severity: Medium]
The documentation states this hardware is also an interrupt controller, but
this required list omits the interrupt-controller and #interrupt-cells
properties.

Should interrupt-controller and #interrupt-cells be moved from
dependentRequired into this unconditional required list? Subsystem rules
mandate that core hardware provider capabilities like an interrupt controller
must be globally required with appropriate constraints. Placing them in
dependentRequired treats them as optional rather than globally required.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    /* Minimal: let firmware define pin count and names */
> +    interface {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        gpio@3 {
> +            compatible = "nvidia,lstp-gpio";
> +            reg = <3>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +        };
> +    };

[Severity: Medium]
Does this example omit the interrupt provider capabilities?

Subsystem rules require that all examples include all required properties.
If the interrupt-controller properties are made globally required, examples
1, 2, and 4 will also need to be updated to include them.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012-lstp-usb-adapter-v1-0-aambrozewicz@nvidia.com?part=1