Re: [PATCH v2 04/11] gpio: Add Cortina Systems CS75xx GPIO driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: unmet direct dependency on HAS_IOMEM when selecting GPIO_GENERIC
--

commit c0cf3f24c2d064770186cd2502b93c7a6f2518be
Author: Fil Dunsky <filipp.dunsky@gmail.com>

gpio: Add Cortina Systems CS75xx GPIO driver
    
This commit introduces a new GPIO driver for the Cortina Systems CS75xx SoCs.
It handles data and direction registers using gpio-mmio, manages GPIO line 
pin multiplexing, and provides interrupt support.

> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index dfdc9ee1a6b38..6b9524f25d24c 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -300,6 +300,18 @@ config GPIO_CLPS711X
>  	help
>  	  Say yes here to support GPIO on CLPS711X SoCs.
>  
> +config GPIO_CS75XX
> +	tristate "Cortina Systems CS75xx GPIO support"
> +	depends on ARCH_CORTINA_ACCESS || COMPILE_TEST
> +	select GPIO_GENERIC

[Severity: Low]
Does this select statement cause a Kconfig unmet dependency warning?

Since GPIO_GENERIC depends on HAS_IOMEM, selecting it here without inheriting
the HAS_IOMEM dependency might cause build warnings or failures when compiling
with COMPILE_TEST enabled on architectures that lack HAS_IOMEM (such as UML).

Should this config also have a depends on HAS_IOMEM to prevent this?

> +	select GPIOLIB_IRQCHIP
> +	help
> +	  Say yes here to support the GPIO banks of the Cortina Systems
> +	  CS75xx SoCs, including their interrupts.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-b4-cs75xx-s2-v2-0-94f8c0a90cda@gmail.com?part=4