Re: [PATCH v1 1/2] dt-bindings: pinctrl: qcom,tlmm-common: Add wakeup-enable

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: custom property wakeup-enable lacks vendor prefix
--

commit 1b3617dbc4a7e1c4b006d9d99d89f2ff25a551bc
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

dt-bindings: pinctrl: qcom,tlmm-common: Add wakeup-enable

The TLMM can gate whether a toggle of a pad is transferred to the wake up
controller (PDC/MPM) while the system is in a low power mode. This commit
adds a pin configuration property so a pin can be armed from its own pin
configuration without being turned into a GPIO.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> index aec72e8c06214..95f5396116916 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
> @@ -87,6 +87,18 @@ $defs:
>        output-high: true
>        output-low: true
>  
> +      wakeup-enable:

[Severity: Low]
Does this hardware-specific property need a vendor prefix?

Since this controls Qualcomm's specific interaction with the PDC/MPM wakeup
controllers, defining it without a qcom, prefix risks namespace collisions
if the pinctrl subsystem later standardizes a generic wakeup-enable property
with different constraints.

If this is intended to be a generic capability, shouldn't it be added to the
core pincfg-node.yaml bindings instead?

> +        type: boolean
> +        description:
> +          Allow a toggle of the specified pins to be transferred to the wake up
> +          controller while the system is in a low power mode. The driver arms
> +          this on its own for pins requested as GPIO interrupts, so it is only
> +          needed for pins that stay muxed to a peripheral function and are
> +          toggled by an external device to request a wake up, such as a
> +          SoundWire data line driven by a codec while the bus is clock stopped.
> +          Only supported on pins that are marked as wakeup capable by the
> +          hardware.
> +
>      allOf:
>        - $ref: pincfg-node.yaml#
>        - $ref: pinmux-node.yaml#

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-tlmm_wakeup_gpio_support-v1-0-c6d6f37a7e51@oss.qualcomm.com?part=1